@cimpress/simple-auth-wrapper - npm Package Compare versions

Comparing version 6.3.0 to 6.3.1

lib/centralizedauth.js

@@ -191,5 +191,4 @@ 'use strict';
     switch (e.key) {
-      // TODO: namespace the key (e.g. "expires_at" -> "saw:expires_at") we are using since there is no way to tell
-      // if this event is coming from localStorage or sessionStorage - if applications are using "expires_at" in 
-      // sessionStorage, this will result in undefined behavior
+      // TODO: add storage namespace option (e.g. "expires_at" -> "saw:expires_at") apps will likely break this wrapper's
+      // behavior if they use any of the localStorage keys this wrapper relies on
       case 'expires_at':
@@ -203,4 +202,3 @@ // check to see if it's being removed or not
           } catch (e) {
-            // for JSON.parse: shouldn't happen unless people are modifying localStorage manually or using
-            //                 the "expires_at" key in sessionStorage
+            // for JSON.parse: shouldn't happen unless people are modifying storage manually
           }
@@ -207,0 +205,0 @@ }

package.json

 {
   "name": "@cimpress/simple-auth-wrapper",
-  "version": "6.3.0",
+  "version": "6.3.1",
   "description": "A simple utility class to wrap basic Auth0 functionality",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

src/centralizedauth.js

@@ -117,5 +117,4 @@ import Auth0 from 'auth0-js';
     switch(e.key) {
-      // TODO: namespace the key (e.g. "expires_at" -> "saw:expires_at") we are using since there is no way to tell
-      // if this event is coming from localStorage or sessionStorage - if applications are using "expires_at" in 
-      // sessionStorage, this will result in undefined behavior
+      // TODO: add storage namespace option (e.g. "expires_at" -> "saw:expires_at") apps will likely break this wrapper's
+      // behavior if they use any of the localStorage keys this wrapper relies on
       case 'expires_at': 
@@ -129,4 +128,3 @@ // check to see if it's being removed or not
           } catch (e) {
-            // for JSON.parse: shouldn't happen unless people are modifying localStorage manually or using
-            //                 the "expires_at" key in sessionStorage
+            // for JSON.parse: shouldn't happen unless people are modifying storage manually
           }
@@ -133,0 +131,0 @@ }

No alert changes

Worsened metrics

Total package byte prevSize

277523

decreased by-0.19%

Lines of code

1341

decreased by-0.3%

No dependency changes