@cityofphiladelphia/mapboard - npm Package Compare versions

Comparing version 0.1.2 to 0.1.3

examples/atlas/main.js

 const GATEKEEPER_KEY = '35ae5b7bf8f0ff2613134935ce6b4c1e';
-const BASE_CONFIG_URL = '//rawgit.com/rbrtmrtn/mapboard-base-config/2fbe59eb4bc61b782c5e3723e764945f7fffed85/config.js';
+const BASE_CONFIG_URL = '//rawgit.com/rbrtmrtn/mapboard-base-config/7e29af5f1e252afe9c562f4e13632ba4e7c6a0b2/config.js';
 
@@ -118,3 +118,7 @@ const ZONING_CODE_MAP = {
   rootStyle: {
-    height: '50cd0px'
+    position: 'absolute',
+    bottom: 0,
+    top: '87px',
+    left: 0,
+    right: 0,
   },
@@ -1104,3 +1108,3 @@ map: {
                 label: 'RCO',
-                value(state, item){
+                value(state, item) {
                   return '<b>' + item.properties.ORGANIZATION_NAME + '</b><br>'
@@ -1112,3 +1116,3 @@ + item.properties.ORGANIZATION_ADDRESS
                 label: 'Meeting Address',
-                value(state, item){
+                value(state, item) {
                   return item.properties.MEETING_LOCATION_ADDRESS
@@ -1119,3 +1123,3 @@ }
                 label: 'Primary Contact',
-                value(state, item){
+                value(state, item) {
                   // return item.properties.PRIMARY_PHONE
@@ -1122,0 +1126,0 @@ return item.properties.PRIMARY_NAME + '<br>'

examples/litter-index/main.js

@@ -5,3 +5,3 @@ var BASE_CONFIG_URL = '//rawgit.com/rbrtmrtn/mapboard-base-config/2fbe59eb4bc61b782c5e3723e764945f7fffed85/config.js',
 // TODO get user-entered address
-var searchInput = '1300 market street';
+// var searchInput = '1300 market street';
 
@@ -300,3 +300,3 @@ // mapping of rco polygon object ids to names
   // dataSources: {},
-  defaultAddress: searchInput,
+  // defaultAddress: searchInput,
   topics: [
@@ -306,3 +306,3 @@ {
       label: 'Litter',
-      icon: 'fa-trash-o',
+      // icon: 'fa-trash-o',
       components: [
@@ -326,3 +326,3 @@ // this is not ready for the first release of the litter index site
               {
-                label: 'Trash & Recycling Day',
+                label: '<a href="//philadelphiastreets.com/sanitation/residential/collection-schedules/">Trash & Recycling Day</a>',
                 value: function (state) {
@@ -341,3 +341,3 @@ var day = state.geocode.data.properties.rubbish_recycle_day;
               {
-                label: 'Recycling Diversion Rate',
+                label: '<a href="//philadelphiastreets.com/recycling/home-base-residential/">Recycling Diversion Rate</a>',
                 value: function (state) {
@@ -352,3 +352,3 @@ var rate = state.geocode.data.properties.recycling_diversion_rate,
               {
-                label: 'Sanitation District',
+                label: '<a href="//opendataphilly.org/dataset/sanitation-districts">Sanitation District</a>',
                 value: function (state) {
@@ -359,7 +359,7 @@ return state.geocode.data.properties.sanitation_district;
               // {
-              //   label: 'PMBC Representative',
+              //   label: '<a href="">PMBC Representative</a>',
               //   value: 'NOT READY'
               // },
               {
-                label: 'Sanitation Convenience Center',
+                label: '<a href="//philadelphiastreets.com/sanitation/residential/sanitation-convenience-centers/">Sanitation Convenience Center</a>',
                 value: function (state) {
@@ -370,3 +370,3 @@ return state.geocode.data.properties.sanitation_convenience_center;
               {
-                label: 'Clean Philly Block Captain',
+                label: '<a href="//philadelphiastreets.com/pmbc/">PMBC Block Captain</a>',
                 value: function (state) {
@@ -377,3 +377,3 @@ return state.geocode.data.properties.clean_philly_block_captain;
               {
-                label: 'PPR Friends Group',
+                label: '<a href="//phila.gov/ParksandRecreation/getinvolved/friendsgroups/Pages/default.aspx">PPR Friends Group</a>',
                 value: function (state) {
@@ -384,3 +384,3 @@ return state.geocode.data.properties.ppr_friends;
               {
-                label: 'Watershed Group',
+                label: '<a href="//phillywatersheds.org/what_were_doing/community_partnerships">Watershed Group</a>',
                 value: function (state) {
@@ -391,3 +391,3 @@ return state.geocode.data.properties.major_phila_watershed;
               {
-                label: 'Commercial Corridor',
+                label: '<a href="//phila.gov/commerce/neighborhoods/Pages/RevitalizingCorridors.aspx">Commercial Corridor Cleaning Program</a>',
                 value: function (state) {
@@ -398,3 +398,3 @@ return state.geocode.data.properties.commercial_corridor;
               {
-                label: 'Neighborhood Advisory Committee',
+                label: '<a href="//phila.gov/dhcd/neighborhood-resources/neighborhood-advisory-committees/">Neighborhood Advisory Committee</a>',
                 value: function (state) {
@@ -401,0 +401,0 @@ return state.geocode.data.properties.neighborhood_advisory_committee;

package.json

 {
   "name": "@cityofphiladelphia/mapboard",
   "description": "A Vue.js component for data-rich web mapping",
-  "version": "0.1.2",
+  "version": "0.1.3",
   "author": "City of Philadelphia <[e-mail]>",
@@ -6,0 +6,0 @@ "scripts": {

src/controller/data-manager.js

@@ -505,3 +505,6 @@ /*
       // this.geocode(features[0].properties.MAPREG);
-      this.controller.router.route(id);
+      const feature = features.length > 0 ? features[0] : {};
+      const props = feature.properties || {};
+      const id = props.MAPREG;
+      if (id) this.controller.router.route(id);
     } else {
@@ -508,0 +511,0 @@ this.fetchData();

No alert changes

Improved metrics

Total package byte prevSize

1707696

increased by0.14%

Lines of code

5476

increased by0.31%

No dependency changes