@ckeditor/ckeditor5-dev-utils - npm Package Compare versions

Comparing version 7.0.7 to 8.0.0

CHANGELOG.md

 Changelog
 =========
 
+## [8.0.0](https://github.com/ckeditor/ckeditor5-dev/compare/@ckeditor/ckeditor5-dev-utils@7.0.7...@ckeditor/ckeditor5-dev-utils@8.0.0) (2018-04-10)
+
+### Bug fixes
+
+* Enabled builds to work with RequireJS. Closes [ckeditor/ckeditor5#914](https://github.com/ckeditor/ckeditor5/issues/914). ([6c69057](https://github.com/ckeditor/ckeditor5-dev/commit/6c69057))
+
+### BREAKING CHANGES
+
+* Due to a new format of translation snippets the new version of `CKEditor5WebpackPlugin` will only be compatible with CKEditor 5 v1.0.0-beta.2 or later.
+
+
 ## [7.0.7](https://github.com/ckeditor/ckeditor5-dev/compare/@ckeditor/ckeditor5-dev-utils@7.0.6...@ckeditor/ckeditor5-dev-utils@7.0.7) (2018-03-27)
@@ -5,0 +16,0 @@

lib/translations/multiplelanguagetranslationservice.js

@@ -179,3 +179,2 @@ /**
 		const mainAssetName = compilationAssetNames[ 0 ];
-		const mainCompilationAsset = compilationAssets[ mainAssetName ];
 
@@ -185,4 +184,5 @@ const mainTranslationAsset = this._getTranslationAssets( outputDirectory, [ this._mainLanguage ] )[ 0 ];
 		const mergedCompilationAsset = {
-			outputBody: mainCompilationAsset.source() + '\n;' + mainTranslationAsset.outputBody,
-			outputPath: mainAssetName
+			outputBody: mainTranslationAsset.outputBody,
+			outputPath: mainAssetName,
+			shouldConcat: true
 		};
@@ -216,3 +216,12 @@
 
-			const outputBody = `CKEDITOR_TRANSLATIONS.add('${ language }',${ stringifiedTranslations })`;
+			const outputBody = (
+				// We need to ensure that the CKEDITOR_TRANSLATIONS variable exists and if it exists, we need to extend it.
+				// Use ES5 because this bit will not be transpiled!
+				'(function(d){' +
+					`d['${ language }']=Object.assign(` +
+						`d['${ language }']||{},` +
+						`${ stringifiedTranslations }` +
+					')' +
+				'})(window.CKEDITOR_TRANSLATIONS||(window.CKEDITOR_TRANSLATIONS={}));'
+			);
 
@@ -219,0 +228,0 @@ return { outputBody, outputPath };

package.json

 {
   "name": "@ckeditor/ckeditor5-dev-utils",
-  "version": "7.0.7",
+  "version": "8.0.0",
   "description": "Utils for CKEditor 5 development tools packages.",
@@ -5,0 +5,0 @@ "keywords": [],

tests/translations/multiplelanguagetranslationservice.js

@@ -220,7 +220,10 @@ /**
 						outputPath: 'ckeditor.js',
-						outputBody: 'source\n;CKEDITOR_TRANSLATIONS.add(\'pl\',{a:"Anuluj",b:"Zapisz"})'
+						outputBody: '(function(d){d[\'pl\']=Object.assign(d[\'pl\']||{},{a:"Anuluj",b:"Zapisz"})})' +
+							'(window.CKEDITOR_TRANSLATIONS||(window.CKEDITOR_TRANSLATIONS={}));',
+						shouldConcat: true
 					},
 					{
 						outputPath: path.join( 'lang', 'en.js' ),
-						outputBody: 'CKEDITOR_TRANSLATIONS.add(\'en\',{a:"Cancel",b:"Save"})'
+						outputBody: '(function(d){d[\'en\']=Object.assign(d[\'en\']||{},{a:"Cancel",b:"Save"})})' +
+							'(window.CKEDITOR_TRANSLATIONS||(window.CKEDITOR_TRANSLATIONS={}));'
 					}
@@ -287,7 +290,10 @@ ] );
 						outputPath: 'ckeditor.js',
-						outputBody: 'source\n;CKEDITOR_TRANSLATIONS.add(\'pl\',{a:"Anuluj",b:"Zapisz"})'
+						outputBody: '(function(d){d[\'pl\']=Object.assign(d[\'pl\']||{},{a:"Anuluj",b:"Zapisz"})})' +
+							'(window.CKEDITOR_TRANSLATIONS||(window.CKEDITOR_TRANSLATIONS={}));',
+						shouldConcat: true
 					},
 					{
 						outputPath: path.join( 'lang', 'xxx.js' ),
-						outputBody: 'CKEDITOR_TRANSLATIONS.add(\'xxx\',{a:"Cancel",b:"Save"})'
+						outputBody: '(function(d){d[\'xxx\']=Object.assign(d[\'xxx\']||{},{a:"Cancel",b:"Save"})})' +
+							'(window.CKEDITOR_TRANSLATIONS||(window.CKEDITOR_TRANSLATIONS={}));'
 					}
@@ -386,3 +392,5 @@ ] );
 						outputPath: 'ckeditor.js',
-						outputBody: 'source\n;CKEDITOR_TRANSLATIONS.add(\'pl\',{a:"Anuluj",b:"Zapisz"})'
+						outputBody: '(function(d){d[\'pl\']=Object.assign(d[\'pl\']||{},{a:"Anuluj",b:"Zapisz"})})' +
+							'(window.CKEDITOR_TRANSLATIONS||(window.CKEDITOR_TRANSLATIONS={}));',
+						shouldConcat: true
 					}
@@ -427,3 +435,4 @@ ] );
 						outputPath: path.join( 'lang', 'pl.js' ),
-						outputBody: 'CKEDITOR_TRANSLATIONS.add(\'pl\',{a:"Anuluj",b:"Zapisz"})'
+						outputBody: '(function(d){d[\'pl\']=Object.assign(d[\'pl\']||{},{a:"Anuluj",b:"Zapisz"})})' +
+							'(window.CKEDITOR_TRANSLATIONS||(window.CKEDITOR_TRANSLATIONS={}));'
 					}
@@ -464,7 +473,10 @@ ] );
 						outputPath: 'ckeditor.js',
-						outputBody: 'source\n;CKEDITOR_TRANSLATIONS.add(\'pl\',{a:"Anuluj"})'
+						outputBody: '(function(d){d[\'pl\']=Object.assign(d[\'pl\']||{},{a:"Anuluj"})})' +
+							'(window.CKEDITOR_TRANSLATIONS||(window.CKEDITOR_TRANSLATIONS={}));',
+						shouldConcat: true
 					},
 					{
 						outputPath: path.join( 'custom-lang-path', 'en.js' ),
-						outputBody: 'CKEDITOR_TRANSLATIONS.add(\'en\',{a:"Cancel"})'
+						outputBody: '(function(d){d[\'en\']=Object.assign(d[\'en\']||{},{a:"Cancel"})})' +
+							'(window.CKEDITOR_TRANSLATIONS||(window.CKEDITOR_TRANSLATIONS={}));'
 					}
@@ -546,7 +558,10 @@ ] );
 						outputPath: 'ckeditor.js',
-						outputBody: 'source\n;CKEDITOR_TRANSLATIONS.add(\'pl\',{a:"Zapisz"})'
+						outputBody: '(function(d){d[\'pl\']=Object.assign(d[\'pl\']||{},{a:"Zapisz"})})' +
+							'(window.CKEDITOR_TRANSLATIONS||(window.CKEDITOR_TRANSLATIONS={}));',
+						shouldConcat: true
 					},
 					{
 						outputPath: path.join( 'lang', 'de.js' ),
-						outputBody: 'CKEDITOR_TRANSLATIONS.add(\'de\',{a:"Speichern"})'
+						outputBody: '(function(d){d[\'de\']=Object.assign(d[\'de\']||{},{a:"Speichern"})})' +
+							'(window.CKEDITOR_TRANSLATIONS||(window.CKEDITOR_TRANSLATIONS={}));'
 					}
@@ -553,0 +568,0 @@ ] );

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

155603

increased by1.2%

Lines of code

3984

increased by0.61%

No dependency changes