@ckeditor/ckeditor5-list - npm Package Compare versions

Comparing version 35.3.2 to 35.4.0

package.json

 {
   "name": "@ckeditor/ckeditor5-list",
-  "version": "35.3.2",
+  "version": "35.4.0",
   "description": "Ordered and unordered lists feature to CKEditor 5.",
@@ -15,40 +15,40 @@ "keywords": [
   "dependencies": {
-    "ckeditor5": "^35.3.2",
-    "@ckeditor/ckeditor5-ui": "^35.3.2"
+    "ckeditor5": "^35.4.0",
+    "@ckeditor/ckeditor5-ui": "^35.4.0"
   },
   "devDependencies": {
-    "@ckeditor/ckeditor5-alignment": "^35.3.2",
-    "@ckeditor/ckeditor5-autoformat": "^35.3.2",
-    "@ckeditor/ckeditor5-basic-styles": "^35.3.2",
-    "@ckeditor/ckeditor5-block-quote": "^35.3.2",
-    "@ckeditor/ckeditor5-clipboard": "^35.3.2",
-    "@ckeditor/ckeditor5-cloud-services": "^35.3.2",
-    "@ckeditor/ckeditor5-code-block": "^35.3.2",
-    "@ckeditor/ckeditor5-core": "^35.3.2",
+    "@ckeditor/ckeditor5-alignment": "^35.4.0",
+    "@ckeditor/ckeditor5-autoformat": "^35.4.0",
+    "@ckeditor/ckeditor5-basic-styles": "^35.4.0",
+    "@ckeditor/ckeditor5-block-quote": "^35.4.0",
+    "@ckeditor/ckeditor5-clipboard": "^35.4.0",
+    "@ckeditor/ckeditor5-cloud-services": "^35.4.0",
+    "@ckeditor/ckeditor5-code-block": "^35.4.0",
+    "@ckeditor/ckeditor5-core": "^35.4.0",
     "@ckeditor/ckeditor5-dev-utils": "^31.0.0",
-    "@ckeditor/ckeditor5-easy-image": "^35.3.2",
-    "@ckeditor/ckeditor5-editor-classic": "^35.3.2",
-    "@ckeditor/ckeditor5-engine": "^35.3.2",
-    "@ckeditor/ckeditor5-enter": "^35.3.2",
-    "@ckeditor/ckeditor5-essentials": "^35.3.2",
-    "@ckeditor/ckeditor5-font": "^35.3.2",
-    "@ckeditor/ckeditor5-heading": "^35.3.2",
-    "@ckeditor/ckeditor5-highlight": "^35.3.2",
-    "@ckeditor/ckeditor5-horizontal-line": "^35.3.2",
-    "@ckeditor/ckeditor5-html-embed": "^35.3.2",
-    "@ckeditor/ckeditor5-html-support": "^35.3.2",
-    "@ckeditor/ckeditor5-image": "^35.3.2",
-    "@ckeditor/ckeditor5-indent": "^35.3.2",
-    "@ckeditor/ckeditor5-link": "^35.3.2",
-    "@ckeditor/ckeditor5-media-embed": "^35.3.2",
-    "@ckeditor/ckeditor5-page-break": "^35.3.2",
-    "@ckeditor/ckeditor5-paragraph": "^35.3.2",
-    "@ckeditor/ckeditor5-remove-format": "^35.3.2",
-    "@ckeditor/ckeditor5-source-editing": "^35.3.2",
-    "@ckeditor/ckeditor5-table": "^35.3.2",
-    "@ckeditor/ckeditor5-theme-lark": "^35.3.2",
-    "@ckeditor/ckeditor5-typing": "^35.3.2",
-    "@ckeditor/ckeditor5-undo": "^35.3.2",
-    "@ckeditor/ckeditor5-utils": "^35.3.2",
-    "@ckeditor/ckeditor5-widget": "^35.3.2",
+    "@ckeditor/ckeditor5-easy-image": "^35.4.0",
+    "@ckeditor/ckeditor5-editor-classic": "^35.4.0",
+    "@ckeditor/ckeditor5-engine": "^35.4.0",
+    "@ckeditor/ckeditor5-enter": "^35.4.0",
+    "@ckeditor/ckeditor5-essentials": "^35.4.0",
+    "@ckeditor/ckeditor5-font": "^35.4.0",
+    "@ckeditor/ckeditor5-heading": "^35.4.0",
+    "@ckeditor/ckeditor5-highlight": "^35.4.0",
+    "@ckeditor/ckeditor5-horizontal-line": "^35.4.0",
+    "@ckeditor/ckeditor5-html-embed": "^35.4.0",
+    "@ckeditor/ckeditor5-html-support": "^35.4.0",
+    "@ckeditor/ckeditor5-image": "^35.4.0",
+    "@ckeditor/ckeditor5-indent": "^35.4.0",
+    "@ckeditor/ckeditor5-link": "^35.4.0",
+    "@ckeditor/ckeditor5-media-embed": "^35.4.0",
+    "@ckeditor/ckeditor5-page-break": "^35.4.0",
+    "@ckeditor/ckeditor5-paragraph": "^35.4.0",
+    "@ckeditor/ckeditor5-remove-format": "^35.4.0",
+    "@ckeditor/ckeditor5-source-editing": "^35.4.0",
+    "@ckeditor/ckeditor5-table": "^35.4.0",
+    "@ckeditor/ckeditor5-theme-lark": "^35.4.0",
+    "@ckeditor/ckeditor5-typing": "^35.4.0",
+    "@ckeditor/ckeditor5-undo": "^35.4.0",
+    "@ckeditor/ckeditor5-utils": "^35.4.0",
+    "@ckeditor/ckeditor5-widget": "^35.4.0",
     "webpack": "^5.58.1",
@@ -55,0 +55,0 @@ "webpack-cli": "^4.9.0"

src/documentlist/documentlistediting.js

@@ -19,2 +19,3 @@ /**
 import DocumentListSplitCommand from './documentlistsplitcommand';
+import DocumentListUtils from '../documentlist/documentlistutils';
 import {
@@ -45,2 +46,3 @@ bogusParagraphCreator,
 } from './utils/view';
+
 import ListWalker, {
@@ -50,3 +52,2 @@ iterateSiblingListBlocks,
 } from './utils/listwalker';
-
 import '../../theme/documentlist.css';
@@ -78,3 +79,3 @@
 	static get requires() {
-		return [ Enter, Delete ];
+		return [ Enter, Delete, DocumentListUtils ];
 	}
@@ -81,0 +82,0 @@

src/documentlist/utils/postfixers.js

@@ -33,3 +33,11 @@ /**
 
-		for ( { node: listHead } of iterateSiblingListBlocks( listHead, 'backward' ) ) {
+		// Previously, the loop below was defined like this:
+		//
+		// 		for ( { node: listHead } of iterateSiblingListBlocks( listHead, 'backward' ) )
+		//
+		// Unfortunately, such a destructuring is incorrectly transpiled by Babel and the loop never ends.
+		// See: https://github.com/ckeditor/ckeditor5-react/issues/345.
+		for ( const { node } of iterateSiblingListBlocks( listHead, 'backward' ) ) {
+			listHead = node;
+
 			if ( itemToListHead.has( listHead ) ) {
@@ -36,0 +44,0 @@ return;

src/documentlistproperties/documentlistpropertiesediting.js

@@ -23,2 +23,3 @@ /**
 } from './utils/style';
+import DocumentListPropertiesUtils from './documentlistpropertiesutils';
 
@@ -40,3 +41,3 @@ const DEFAULT_LIST_TYPE = 'default';
 	static get requires() {
-		return [ DocumentListEditing ];
+		return [ DocumentListEditing, DocumentListPropertiesUtils ];
 	}
@@ -365,3 +366,3 @@
 			setAttributeOnDowncast( writer, listStart, element ) {
-				if ( listStart && listStart > 1 ) {
+				if ( listStart == 0 || listStart > 1 ) {
 					writer.setAttribute( 'start', listStart, element );
@@ -374,3 +375,5 @@ } else {
 			getAttributeOnUpcast( listParent ) {
-				return listParent.getAttribute( 'start' ) || 1;
+				const startAttributeValue = listParent.getAttribute( 'start' );
+
+				return startAttributeValue >= 0 ? startAttributeValue : 1;
 			}
@@ -377,0 +380,0 @@ } );

src/documentlistproperties/documentliststartcommand.js

@@ -53,3 +53,3 @@ /**
 			for ( const block of blocks ) {
-				writer.setAttribute( 'listStart', options.startIndex || 1, block );
+				writer.setAttribute( 'listStart', options.startIndex >= 0 ? options.startIndex : 1, block );
 			}
@@ -56,0 +56,0 @@ } );

src/index.js

@@ -14,2 +14,4 @@ /**
 export { default as DocumentListPropertiesEditing } from './documentlistproperties/documentlistpropertiesediting';
+export { default as DocumentListUtils } from './documentlist/documentlistutils';
+export { default as DocumentListPropertiesUtils } from './documentlistproperties/documentlistpropertiesutils';
 export { default as List } from './list';
@@ -19,2 +21,3 @@ export { default as ListEditing } from './list/listediting';
 export { default as ListProperties } from './listproperties';
+export { default as ListUtils } from './list/listutils';
 export { default as ListPropertiesEditing } from './listproperties/listpropertiesediting';
@@ -21,0 +24,0 @@ export { default as ListPropertiesUI } from './listproperties/listpropertiesui';

src/list/listediting.js

@@ -12,2 +12,3 @@ /**
 import IndentCommand from './indentcommand';
+import ListUtils from './listutils';
 
@@ -54,3 +55,3 @@ import { Plugin } from 'ckeditor5/src/core';
 	static get requires() {
-		return [ Enter, Delete ];
+		return [ Enter, Delete, ListUtils ];
 	}
@@ -57,0 +58,0 @@

src/listproperties/listpropertiesediting.js

@@ -338,3 +338,3 @@ /**
 			setAttributeOnDowncast( writer, listStart, element ) {
-				if ( listStart != 1 ) {
+				if ( listStart == 0 || listStart > 1 ) {
 					writer.setAttribute( 'start', listStart, element );
@@ -347,3 +347,5 @@ } else {
 			getAttributeOnUpcast( listParent ) {
-				return listParent.getAttribute( 'start' ) || 1;
+				const startAttributeValue = listParent.getAttribute( 'start' );
+
+				return startAttributeValue >= 0 ? startAttributeValue : 1;
 			}
@@ -350,0 +352,0 @@ } );

src/listproperties/liststartcommand.js

@@ -43,3 +43,3 @@ /**
 			for ( const item of listItems ) {
-				writer.setAttribute( 'listStart', options.startIndex || 1, item );
+				writer.setAttribute( 'listStart', options.startIndex >= 0 ? options.startIndex : 1, item );
 			}
@@ -46,0 +46,0 @@ } );

src/listproperties/ui/listpropertiesview.js

@@ -206,3 +206,4 @@ /**
 					.split( ' ' )
-					.length
+					.length,
+				uiLanguageDirection: this.locale && this.locale.uiLanguageDirection
 			} );
@@ -372,3 +373,3 @@ }
 		startIndexFieldView.fieldView.set( {
-			min: 1,
+			min: 0,
 			step: 1,
@@ -375,0 +376,0 @@ value: 1,

No alert changes

Improved metrics

Number of package files

192

increased by1.05%

Lines of code

8394

increased by2.3%

Worsened metrics

Total package byte prevSize

847643

decreased by-34.03%

Dependency changes

• Updated@ckeditor/ckeditor5-ui@^35.4.0

• Updatedckeditor5@^35.4.0