@ckeditor/ckeditor5-table - npm Package Compare versions

Comparing version 35.3.2 to 35.4.0

package.json

 {
   "name": "@ckeditor/ckeditor5-table",
-  "version": "35.3.2",
+  "version": "35.4.0",
   "description": "Table feature for CKEditor 5.",
@@ -15,30 +15,30 @@ "keywords": [
   "dependencies": {
-    "ckeditor5": "^35.3.2",
+    "ckeditor5": "^35.4.0",
     "lodash-es": "^4.17.15"
   },
   "devDependencies": {
-    "@ckeditor/ckeditor5-alignment": "^35.3.2",
-    "@ckeditor/ckeditor5-basic-styles": "^35.3.2",
-    "@ckeditor/ckeditor5-block-quote": "^35.3.2",
-    "@ckeditor/ckeditor5-clipboard": "^35.3.2",
-    "@ckeditor/ckeditor5-core": "^35.3.2",
+    "@ckeditor/ckeditor5-alignment": "^35.4.0",
+    "@ckeditor/ckeditor5-basic-styles": "^35.4.0",
+    "@ckeditor/ckeditor5-block-quote": "^35.4.0",
+    "@ckeditor/ckeditor5-clipboard": "^35.4.0",
+    "@ckeditor/ckeditor5-core": "^35.4.0",
     "@ckeditor/ckeditor5-dev-utils": "^31.0.0",
-    "@ckeditor/ckeditor5-editor-classic": "^35.3.2",
-    "@ckeditor/ckeditor5-engine": "^35.3.2",
-    "@ckeditor/ckeditor5-highlight": "^35.3.2",
-    "@ckeditor/ckeditor5-horizontal-line": "^35.3.2",
-    "@ckeditor/ckeditor5-html-support": "^35.3.2",
-    "@ckeditor/ckeditor5-image": "^35.3.2",
-    "@ckeditor/ckeditor5-indent": "^35.3.2",
-    "@ckeditor/ckeditor5-link": "^35.3.2",
-    "@ckeditor/ckeditor5-list": "^35.3.2",
-    "@ckeditor/ckeditor5-media-embed": "^35.3.2",
-    "@ckeditor/ckeditor5-paragraph": "^35.3.2",
-    "@ckeditor/ckeditor5-theme-lark": "^35.3.2",
-    "@ckeditor/ckeditor5-typing": "^35.3.2",
-    "@ckeditor/ckeditor5-ui": "^35.3.2",
-    "@ckeditor/ckeditor5-undo": "^35.3.2",
-    "@ckeditor/ckeditor5-utils": "^35.3.2",
-    "@ckeditor/ckeditor5-widget": "^35.3.2",
-    "@ckeditor/ckeditor5-source-editing": "^35.3.2",
+    "@ckeditor/ckeditor5-editor-classic": "^35.4.0",
+    "@ckeditor/ckeditor5-engine": "^35.4.0",
+    "@ckeditor/ckeditor5-highlight": "^35.4.0",
+    "@ckeditor/ckeditor5-horizontal-line": "^35.4.0",
+    "@ckeditor/ckeditor5-html-support": "^35.4.0",
+    "@ckeditor/ckeditor5-image": "^35.4.0",
+    "@ckeditor/ckeditor5-indent": "^35.4.0",
+    "@ckeditor/ckeditor5-link": "^35.4.0",
+    "@ckeditor/ckeditor5-list": "^35.4.0",
+    "@ckeditor/ckeditor5-media-embed": "^35.4.0",
+    "@ckeditor/ckeditor5-paragraph": "^35.4.0",
+    "@ckeditor/ckeditor5-theme-lark": "^35.4.0",
+    "@ckeditor/ckeditor5-typing": "^35.4.0",
+    "@ckeditor/ckeditor5-ui": "^35.4.0",
+    "@ckeditor/ckeditor5-undo": "^35.4.0",
+    "@ckeditor/ckeditor5-utils": "^35.4.0",
+    "@ckeditor/ckeditor5-widget": "^35.4.0",
+    "@ckeditor/ckeditor5-source-editing": "^35.4.0",
     "json-diff": "^0.5.4",
@@ -45,0 +45,0 @@ "webpack": "^5.58.1",

src/converters/tableproperties.js

@@ -20,5 +20,6 @@ /**
  * @param {Boolean} [options.reduceBoxSides=false]
+ * @param {Function} [options.shouldUpcast] The function which returns `true` if style should be upcasted from this element.
  */
 export function upcastStyleToAttribute( conversion, options ) {
-	const { viewElement, defaultValue, modelAttribute, styleName, reduceBoxSides = false } = options;
+	const { viewElement, defaultValue, modelAttribute, styleName, reduceBoxSides = false, shouldUpcast = () => true } = options;
 
@@ -35,2 +36,6 @@ conversion.for( 'upcast' ).attributeToAttribute( {
 			value: viewElement => {
+				if ( !shouldUpcast( viewElement ) ) {
+					return;
+				}
+
 				const normalized = viewElement.getNormalizedStyle( styleName );
@@ -37,0 +42,0 @@ const value = reduceBoxSides ? reduceBoxSidesValue( normalized ) : normalized;

src/converters/upcasttable.js

@@ -32,3 +32,3 @@ /**
 
-			// Find an table element inside the figure element.
+			// Find a table element inside the figure element.
 			const viewTable = getViewTableFromFigure( data.viewItem );
@@ -35,0 +35,0 @@

src/tablecolumnresize/tablewidthresizecommand.js

@@ -42,4 +42,4 @@ /**
 	 * @param {Object} options
-	 * @param {String} [options.tableWidth] The new table width.
-	 * @param {String} [options.columnWidths] The new table column widths.
+	 * @param {String} [options.tableWidth] The new table width. If skipped, the model attribute will be removed.
+	 * @param {String} [options.columnWidths] The new table column widths. If skipped, the model attribute will be removed.
 	 * @param {module:engine/model/element~Element} [options.table] The table that is affected by the resize.
@@ -55,8 +55,13 @@ */
 				writer.setAttribute( this.attributeName, tableWidth, table );
-				writer.setAttribute( 'columnWidths', columnWidths, table );
 			} else {
 				writer.removeAttribute( this.attributeName, table );
 			}
+
+			if ( columnWidths ) {
+				writer.setAttribute( 'columnWidths', columnWidths, table );
+			} else {
+				writer.removeAttribute( 'columnWidths', table );
+			}
 		} );
 	}
 }

src/tableproperties/tablepropertiesediting.js

@@ -245,4 +245,10 @@ /**
 	} );
-	upcastStyleToAttribute( conversion, { viewElement: /^(table|figure)$/, ...options } );
+
+	upcastStyleToAttribute( conversion, {
+		viewElement: /^(table|figure)$/,
+		shouldUpcast: element => !( element.name == 'table' && element.parent.name == 'figure' ),
+		...options
+	} );
+
 	downcastAttributeToStyle( conversion, { modelElement: 'table', ...options } );
 }

src/tablewalker.js

@@ -10,3 +10,3 @@ /**
 
-// @if CK_DEBUG // import { CKEditorError } from 'ckeditor5/src/utils';
+// @if CK_DEBUG // const { CKEditorError } = require( 'ckeditor5/src/utils' );
 
@@ -13,0 +13,0 @@ /**

src/ui/inserttableview.js

@@ -161,3 +161,4 @@ /**
 			gridItems: this.items,
-			numberOfColumns: 10
+			numberOfColumns: 10,
+			uiLanguageDirection: this.locale && this.locale.uiLanguageDirection
 		} );
@@ -164,0 +165,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

13962

increased by0.09%

Worsened metrics

Total package byte prevSize

1395025

decreased by-34.73%

Number of package files

217

decreased by-0.46%

Dependency changes

• Updatedckeditor5@^35.4.0