@clappr/core - npm Package Compare versions

Comparing version 0.4.14 to 0.4.15

package.json

 {
   "name": "@clappr/core",
-  "version": "0.4.14",
+  "version": "0.4.15",
   "description": "Core components of the extensible media player for the web",
@@ -5,0 +5,0 @@ "main": "./dist/clappr-core.js",

src/components/container/container.js

@@ -176,2 +176,3 @@ // Copyright 2014 Globo.com Player authors. All rights reserved.
     this.listenTo(this.playback, Events.PLAYBACK_MEDIACONTROL_ENABLE, this.enableMediaControl)
+    this.listenTo(this.playback, Events.PLAYBACK_SEEK, this.onSeek)
     this.listenTo(this.playback, Events.PLAYBACK_SEEKED, this.onSeeked)
@@ -376,6 +377,9 @@ this.listenTo(this.playback, Events.PLAYBACK_ENDED, this.onEnded)
   seek(time) {
-    this.trigger(Events.CONTAINER_SEEK, time, this.name)
     this.playback.seek(time)
   }
 
+  onSeek(time) {
+    this.trigger(Events.CONTAINER_SEEK, time, this.name)
+  }
+
   onSeeked() {
@@ -382,0 +386,0 @@ this.trigger(Events.CONTAINER_SEEKED, this.name)

src/components/container/container.test.js

@@ -77,2 +77,17 @@ import Container from './container'
 
+  test('listens to playback:seek event', (done) => {
+    let playback = new HTML5Playback({ src: '/base/test/fixtures/SampleVideo_360x240_1mb.mp4' })
+    let container = new Container({ playback: playback })
+    let callback = jest.fn()
+
+    container.bindEvents()
+    container.on(Events.CONTAINER_SEEK, callback)
+    container.on(Events.CONTAINER_SEEK, () => {
+      expect(callback).toHaveBeenCalled()
+      done()
+    })
+
+    playback.el.dispatchEvent(new Event('seeking'))
+  })
+
   test('listens to playback:seeked event', (done) => {
@@ -79,0 +94,0 @@ let playback = new HTML5Playback({ src: '/base/test/fixtures/SampleVideo_360x240_1mb.mp4' })

src/playbacks/html5_video/html5_video.js

@@ -428,4 +428,4 @@ // Copyright 2014 Globo.com Player authors. All rights reserved.
   _onSeeking() {
+    this.trigger(Events.PLAYBACK_SEEK, this.getCurrentTime())
     this._handleBufferingEvents()
-    this.trigger(Events.PLAYBACK_SEEK)
   }
@@ -432,0 +432,0 @@

New alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1875808

increased by0.08%

Lines of code

25493

increased by0.1%

Worsened metrics

Number of medium supply chain risk alerts

1

increased byInfinity%

No dependency changes