@codecademy/brand-components - npm Package Compare versions

Comparing version 0.6.0 to 0.6.1-alpha.08f6f0.0

dist/Byline/__tests__/Byline-test.js

@@ -29,7 +29,7 @@ import { mount } from 'enzyme';
       classNames: {
-        occupation: 'evenCoolerStyleDawg'
+        jobContainer: 'evenCoolerStyleDawg'
       }
     }));
-    var occupation = wrapper.find('span[aria-label="Occupation"]');
-    expect(occupation.prop('className')).toBe('evenCoolerStyleDawg');
+    var jobContainer = wrapper.find('div[data-testid="job-container"]');
+    expect(jobContainer.prop('className')).toBe('evenCoolerStyleDawg');
   });
@@ -36,0 +36,0 @@ it('combines a passed down className with the default styles for the author span element', function () {

dist/Byline/index.d.ts

@@ -5,3 +5,3 @@ import React from 'react';
     name?: string;
-    occupation?: string;
+    jobContainer?: string;
     location?: string;
@@ -14,4 +14,5 @@ };
     classNames?: BylineClassNamesProps;
+    company?: string;
 };
 export declare const Byline: React.FC<BylineProps>;
 export default Byline;

dist/Byline/index.js

@@ -10,3 +10,4 @@ import React from 'react';
       _ref$classNames = _ref.classNames,
-      classNames = _ref$classNames === void 0 ? {} : _ref$classNames;
+      classNames = _ref$classNames === void 0 ? {} : _ref$classNames,
+      company = _ref.company;
   return React.createElement("div", {
@@ -17,6 +18,11 @@ className: cx(s.bylineContainer, classNames.bylineContainer)
     className: cx(s.name, classNames.name)
-  }, name), React.createElement("span", {
-    "aria-label": "Occupation",
-    className: classNames.occupation
-  }, occupation), location && React.createElement("div", {
+  }, name), React.createElement("div", {
+    "data-testid": "job-container",
+    className: classNames.jobContainer
+  }, React.createElement("span", {
+    "aria-label": "Occupation"
+  }, occupation), React.createElement("span", {
+    "aria-label": "Company",
+    className: s.company
+  }, " @ ".concat(company))), location && React.createElement("div", {
     className: s.locationContainer
@@ -23,0 +29,0 @@ }, React.createElement("img", {

dist/Testimonial/index.js

@@ -18,3 +18,6 @@ function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
       quote = testimonial.quote,
-      imageUrl = testimonial.imageUrl;
+      imageUrl = testimonial.imageUrl,
+      company = testimonial.company;
+  var fullName = "".concat(firstName, " ").concat(lastName);
+  var fullNameOverLimit = fullName.length > 22;
   return React.createElement("div", {
@@ -36,4 +39,5 @@ className: cx(s.testimonialWrapper, (_cx = {}, _defineProperty(_cx, s.darkWrapper, theme === VisualTheme.DarkMode), _defineProperty(_cx, s.lightWrapper, theme === VisualTheme.LightMode), _cx))
   }, React.createElement(Byline, {
-    name: "".concat(firstName, " ").concat(lastName),
-    occupation: occupation
+    name: fullNameOverLimit ? firstName : fullName,
+    occupation: occupation,
+    company: company
   })), React.createElement("div", {
@@ -40,0 +44,0 @@ className: s.quoteContainer

package.json

 {
   "name": "@codecademy/brand-components",
   "description": "Brand component library for Codecademy",
-  "version": "0.6.0",
+  "version": "0.6.1-alpha.08f6f0.0+08f6f051",
   "author": "Codecademy Engineering <[e-mail]>",
@@ -34,3 +34,3 @@ "sideEffects": [
   "license": "MIT",
-  "gitHead": "c66522a5cb5619da91fe34fa5f2a679c61f99e4e"
+  "gitHead": "08f6f0511105d8d1704b974d3eac37904545048a"
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Manifest confusion

Supply chain risk

This package has inconsistent metadata. This could be malicious or caused by an error when publishing the package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

35212

increased by1.63%

Lines of code

422

increased by2.68%

Worsened metrics

Number of medium supply chain risk alerts

1

increased byInfinity%

No dependency changes