@codecademy/brand-components - npm Package Compare versions

Comparing version 1.5.12-alpha.70ae99.0 to 1.5.12-alpha.e4f9e9.0

CHANGELOG.md

@@ -6,5 +6,6 @@ # Change Log
 
-## <small>1.5.12-alpha.70ae99.0 (2020-05-11)</small>
+## <small>1.5.12-alpha.e4f9e9.0 (2020-05-11)</small>
 
-* Ported common Loading icon to Brand/Labs ([70ae994](https://github.com/Codecademy/client-modules/commit/70ae994))
+* Merge branch 'master' into rb-headertab-A11Y-369 ([e4f9e96](https://github.com/Codecademy/client-modules/commit/e4f9e96))
+* remove appbartab and make headertab simpler ([d707d37](https://github.com/Codecademy/client-modules/commit/d707d37))
 
@@ -11,0 +12,0 @@

dist/Header/HeaderTab/index.d.ts

 import React, { HTMLAttributes } from 'react';
 export declare type HeaderTabProps = HTMLAttributes<HTMLElement> & {
-    onClick?: (event: React.MouseEvent) => void;
     className?: string;
     id?: string;
+    testId?: string;
 };
 export declare const HeaderTab: React.FC<HeaderTabProps>;
 export default HeaderTab;

dist/Header/HeaderTab/index.js

@@ -5,29 +5,13 @@ import React from 'react';
 export var HeaderTab = function HeaderTab(_ref) {
-  var onClick = _ref.onClick,
-      className = _ref.className,
+  var className = _ref.className,
       children = _ref.children,
-      id = _ref.id;
-
-  var handleClick = function handleClick(e) {
-    if (onClick) {
-      e.preventDefault();
-      onClick(e);
-    }
-  };
-
+      id = _ref.id,
+      testId = _ref.testId;
   var classes = cx(s.headerTab, className);
   return React.createElement("div", {
-    role: "tab",
-    tabIndex: 0,
-    key: id,
-    onClick: handleClick,
+    id: id,
     className: classes,
-    onKeyDown: function onKeyDown(e) {
-      // https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_link_role
-      if (e.key === ' ' || e.key === 'Enter') {
-        handleClick(e);
-      }
-    }
+    "data-testid": testId
   }, children);
 };
 export default HeaderTab;

dist/index.d.ts

 export * from './Avatar';
 export * from './Byline';
 export * from './EditorialMolecules';
-export * from './Loading';
 export * from './Logo';
@@ -6,0 +5,0 @@ export * from './Quote';

dist/index.js

 export * from './Avatar';
 export * from './Byline';
 export * from './EditorialMolecules';
-export * from './Loading';
 export * from './Logo';
@@ -6,0 +5,0 @@ export * from './Quote';

package.json

 {
   "name": "@codecademy/brand-components",
   "description": "Brand component library for Codecademy",
-  "version": "1.5.12-alpha.70ae99.0",
+  "version": "1.5.12-alpha.e4f9e9.0",
   "author": "Codecademy Engineering <[e-mail]>",
@@ -21,3 +21,3 @@ "sideEffects": [
   "dependencies": {
-    "@codecademy/gamut": "^7.7.0",
+    "@codecademy/gamut": "^7.7.1-alpha.e4f9e9.0",
     "@codecademy/gamut-styles": "^3.3.1",
@@ -35,3 +35,3 @@ "classnames": "^2.2.5"
   "license": "MIT",
-  "gitHead": "dedf42b808f4353f0e02cb5e6a31f6760a382ad2"
+  "gitHead": "bb91690daff680dcf0bf445bc6f23caf9dfae9a8"
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

400272

decreased by-1.57%

Number of package files

77

decreased by-3.75%

Lines of code

829

decreased by-11.53%

Dependency changes

• Updated@codecademy/gamut@^7.7.1-alpha.e4f9e9.0