@compas/server - npm Package Compare versions

Comparing version 0.10.6 to 0.11.0

package.json

 {
   "name": "@compas/server",
-  "version": "0.10.6",
+  "version": "0.11.0",
   "description": "Koa server and common middleware",
@@ -24,3 +24,3 @@ "exports": {
   "dependencies": {
-    "@compas/stdlib": "0.10.6",
+    "@compas/stdlib": "0.11.0",
     "@types/formidable": "2.0.6",
@@ -27,0 +27,0 @@ "@types/koa": "2.15.0",

src/middleware/error.js

@@ -41,20 +41,13 @@ import { _compasSentryExport, AppError, isProduction } from "@compas/stdlib";
 
-      if (err.status >= 500) {
-        if (_compasSentryExport) {
-          if (err === origErr) {
-            // An AppError.serverError was thrown.
-            _compasSentryExport.captureException(
-              new Error(err.key, {
-                cause: err,
-              }),
-            );
-          } else {
-            // Something else was thrown.
-            _compasSentryExport.captureException(origErr);
-          }
-        }
+      const isUnexpectedError = err.status >= 500;
 
+      if (isUnexpectedError) {
+        // Upgrade to error logging, developer probably has alerting on error logs.
         log = ctx.log.error;
       }
 
+      if (_compasSentryExport && isUnexpectedError) {
+        _compasSentryExport.captureException(origErr);
+      }
+
       ctx.status = err.status;
@@ -70,4 +63,10 @@
         if (isProduction()) {
+          // Delete generic internals
           delete formatted.stack;
           delete formatted.cause;
+
+          if (isUnexpectedError) {
+            // Remove any possible internal details. In explicit 400's for example, info is useful to the caller.
+            delete formatted.info;
+          }
         }
@@ -74,0 +73,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

39995

increased by0.2%

Worsened metrics

Lines of code

1135

decreased by-0.26%

Dependency changes

• + Added@compas/stdlib@0.11.0(transitive)

• - Removed@compas/stdlib@0.10.6(transitive)

• Updated@compas/stdlib@0.11.0