@connext/apps - npm Package Compare versions

Comparing version 6.7.1 to 7.0.0-alpha.0

dist/index-iife.js

@@ -101,10 +101,10 @@ this.window = this.window || {};
           ? await provider.getBalance(multisigAddress)
-          : await new ethers.Contract(initialState.assetId, contracts.ERC20.abi, provider).functions.balanceOf(multisigAddress);
+          : await new ethers.Contract(initialState.assetId, contracts.ERC20.abi, provider).balanceOf(multisigAddress);
       const multisig = new ethers.Contract(multisigAddress, contracts.MinimumViableMultisig.abi, provider);
       let startingTotalAmountWithdrawn;
       try {
-          startingTotalAmountWithdrawn = await multisig.functions.totalAmountWithdrawn(initialState.assetId);
+          startingTotalAmountWithdrawn = await multisig.totalAmountWithdrawn(initialState.assetId);
       }
       catch (e) {
-          const NOT_DEPLOYED_ERR = `contract not deployed (contractAddress="${multisigAddress}"`;
+          const NOT_DEPLOYED_ERR = `CALL_EXCEPTION`;
           if (!e.message.includes(NOT_DEPLOYED_ERR)) {
@@ -131,3 +131,3 @@ throw new Error(e);
           ? await provider.getBalance(stateChannel.multisigAddress)
-          : await new types.Contract(latestState.assetId, contracts.ERC20.abi, provider).functions.balanceOf(stateChannel.multisigAddress);
+          : await new types.Contract(latestState.assetId, contracts.ERC20.abi, provider).balanceOf(stateChannel.multisigAddress);
       if (currentMultisigBalance.lt(latestState.startingMultisigBalance)) {
@@ -144,4 +144,4 @@ throw new Error(`Refusing to uninstall, current multisig balance (${currentMultisigBalance.toString()}) is less than starting multisig balance (${latestState.startingMultisigBalance.toString()})`);
       const depositApp = stateChannel.appInstances.find(([id, app]) => {
-          return (app.appInterface.addr === proposal.appDefinition &&
-              app.latestState["assetId"] === proposal.initialState["assetId"]);
+          return (app.appDefinition === proposal.appDefinition &&
+              app.latestState["assetId"] === proposal.latestState["assetId"]);
       });
@@ -301,3 +301,3 @@ if (depositApp) {
               value: 0,
-              data: iface.functions.withdrawWrapper.encode([
+              data: iface.encodeFunctionData("withdrawWrapper", [
                   this.recipient,
@@ -327,3 +327,2 @@ this.assetId,
 
-  const { bigNumberify } = ethers.utils;
   const ALLOWED_DISCREPANCY_PCT = 5;
@@ -340,3 +339,3 @@ const validateSimpleSwapApp = (params, allowedSwaps, ourRate) => {
       const allowedDiscrepancy = calculated
-          .mul(bigNumberify(100).sub(ALLOWED_DISCREPANCY_PCT))
+          .mul(ethers.BigNumber.from(100).sub(ALLOWED_DISCREPANCY_PCT))
           .div(100);
@@ -401,3 +400,3 @@ if (calculatedToActualDiscrepancy.gt(allowedDiscrepancy)) {
       const { appInstance } = middlewareContext;
-      const appDef = appInstance.appInterface.addr;
+      const appDef = appInstance.appDefinition;
       switch (appDef) {
@@ -404,0 +403,0 @@ case network.contractAddresses.DepositApp: {

dist/index.esm.js

@@ -1,2 +0,2 @@
-import { constants, Contract, utils } from 'ethers';
+import { constants, Contract, utils, BigNumber } from 'ethers';
 import { DepositAppName, OutcomeType, DepositAppStateEncoding, CONVENTION_FOR_ETH_ASSET_ID, Contract as Contract$1, ProtocolRoles, HashLockTransferAppName, HashLockTransferAppActionEncoding, HashLockTransferAppStateEncoding, SimpleLinkedTransferAppActionEncoding, SimpleLinkedTransferAppName, SimpleLinkedTransferAppStateEncoding, SimpleSignedTransferAppName, SimpleSignedTransferAppStateEncoding, SimpleSignedTransferAppActionEncoding, WithdrawAppName, WithdrawAppStateEncoding, WithdrawAppActionEncoding, MultisigOperation, SimpleTwoPartySwapAppName, SimpleSwapAppStateEncoding, ProtocolNames } from '@connext/types';
@@ -102,10 +102,10 @@ import { toBN, getAddressFromAssetId, stringify, getSignerAddressFromPublicIdentifier, bigNumberifyJson, recoverAddressFromChannelMessage, calculateExchange } from '@connext/utils';
         ? await provider.getBalance(multisigAddress)
-        : await new Contract(initialState.assetId, ERC20.abi, provider).functions.balanceOf(multisigAddress);
+        : await new Contract(initialState.assetId, ERC20.abi, provider).balanceOf(multisigAddress);
     const multisig = new Contract(multisigAddress, MinimumViableMultisig.abi, provider);
     let startingTotalAmountWithdrawn;
     try {
-        startingTotalAmountWithdrawn = await multisig.functions.totalAmountWithdrawn(initialState.assetId);
+        startingTotalAmountWithdrawn = await multisig.totalAmountWithdrawn(initialState.assetId);
     }
     catch (e) {
-        const NOT_DEPLOYED_ERR = `contract not deployed (contractAddress="${multisigAddress}"`;
+        const NOT_DEPLOYED_ERR = `CALL_EXCEPTION`;
         if (!e.message.includes(NOT_DEPLOYED_ERR)) {
@@ -132,3 +132,3 @@ throw new Error(e);
         ? await provider.getBalance(stateChannel.multisigAddress)
-        : await new Contract$1(latestState.assetId, ERC20.abi, provider).functions.balanceOf(stateChannel.multisigAddress);
+        : await new Contract$1(latestState.assetId, ERC20.abi, provider).balanceOf(stateChannel.multisigAddress);
     if (currentMultisigBalance.lt(latestState.startingMultisigBalance)) {
@@ -145,4 +145,4 @@ throw new Error(`Refusing to uninstall, current multisig balance (${currentMultisigBalance.toString()}) is less than starting multisig balance (${latestState.startingMultisigBalance.toString()})`);
     const depositApp = stateChannel.appInstances.find(([id, app]) => {
-        return (app.appInterface.addr === proposal.appDefinition &&
-            app.latestState["assetId"] === proposal.initialState["assetId"]);
+        return (app.appDefinition === proposal.appDefinition &&
+            app.latestState["assetId"] === proposal.latestState["assetId"]);
     });
@@ -302,3 +302,3 @@ if (depositApp) {
             value: 0,
-            data: iface.functions.withdrawWrapper.encode([
+            data: iface.encodeFunctionData("withdrawWrapper", [
                 this.recipient,
@@ -328,3 +328,2 @@ this.assetId,
 
-const { bigNumberify } = utils;
 const ALLOWED_DISCREPANCY_PCT = 5;
@@ -341,3 +340,3 @@ const validateSimpleSwapApp = (params, allowedSwaps, ourRate) => {
     const allowedDiscrepancy = calculated
-        .mul(bigNumberify(100).sub(ALLOWED_DISCREPANCY_PCT))
+        .mul(BigNumber.from(100).sub(ALLOWED_DISCREPANCY_PCT))
         .div(100);
@@ -402,3 +401,3 @@ if (calculatedToActualDiscrepancy.gt(allowedDiscrepancy)) {
     const { appInstance } = middlewareContext;
-    const appDef = appInstance.appInterface.addr;
+    const appDef = appInstance.appDefinition;
     switch (appDef) {
@@ -405,0 +404,0 @@ case network.contractAddresses.DepositApp: {

dist/index.js

@@ -106,10 +106,10 @@ 'use strict';
         ? await provider.getBalance(multisigAddress)
-        : await new ethers.Contract(initialState.assetId, contracts.ERC20.abi, provider).functions.balanceOf(multisigAddress);
+        : await new ethers.Contract(initialState.assetId, contracts.ERC20.abi, provider).balanceOf(multisigAddress);
     const multisig = new ethers.Contract(multisigAddress, contracts.MinimumViableMultisig.abi, provider);
     let startingTotalAmountWithdrawn;
     try {
-        startingTotalAmountWithdrawn = await multisig.functions.totalAmountWithdrawn(initialState.assetId);
+        startingTotalAmountWithdrawn = await multisig.totalAmountWithdrawn(initialState.assetId);
     }
     catch (e) {
-        const NOT_DEPLOYED_ERR = `contract not deployed (contractAddress="${multisigAddress}"`;
+        const NOT_DEPLOYED_ERR = `CALL_EXCEPTION`;
         if (!e.message.includes(NOT_DEPLOYED_ERR)) {
@@ -136,3 +136,3 @@ throw new Error(e);
         ? await provider.getBalance(stateChannel.multisigAddress)
-        : await new types.Contract(latestState.assetId, contracts.ERC20.abi, provider).functions.balanceOf(stateChannel.multisigAddress);
+        : await new types.Contract(latestState.assetId, contracts.ERC20.abi, provider).balanceOf(stateChannel.multisigAddress);
     if (currentMultisigBalance.lt(latestState.startingMultisigBalance)) {
@@ -149,4 +149,4 @@ throw new Error(`Refusing to uninstall, current multisig balance (${currentMultisigBalance.toString()}) is less than starting multisig balance (${latestState.startingMultisigBalance.toString()})`);
     const depositApp = stateChannel.appInstances.find(([id, app]) => {
-        return (app.appInterface.addr === proposal.appDefinition &&
-            app.latestState["assetId"] === proposal.initialState["assetId"]);
+        return (app.appDefinition === proposal.appDefinition &&
+            app.latestState["assetId"] === proposal.latestState["assetId"]);
     });
@@ -306,3 +306,3 @@ if (depositApp) {
             value: 0,
-            data: iface.functions.withdrawWrapper.encode([
+            data: iface.encodeFunctionData("withdrawWrapper", [
                 this.recipient,
@@ -332,3 +332,2 @@ this.assetId,
 
-const { bigNumberify } = ethers.utils;
 const ALLOWED_DISCREPANCY_PCT = 5;
@@ -345,3 +344,3 @@ const validateSimpleSwapApp = (params, allowedSwaps, ourRate) => {
     const allowedDiscrepancy = calculated
-        .mul(bigNumberify(100).sub(ALLOWED_DISCREPANCY_PCT))
+        .mul(ethers.BigNumber.from(100).sub(ALLOWED_DISCREPANCY_PCT))
         .div(100);
@@ -406,3 +405,3 @@ if (calculatedToActualDiscrepancy.gt(allowedDiscrepancy)) {
     const { appInstance } = middlewareContext;
-    const appDef = appInstance.appInterface.addr;
+    const appDef = appInstance.appDefinition;
     switch (appDef) {
@@ -409,0 +408,0 @@ case network.contractAddresses.DepositApp: {

dist/src/DepositApp/middleware.js

@@ -13,3 +13,3 @@ import { Contract, CONVENTION_FOR_ETH_ASSET_ID, ProtocolRoles, } from "@connext/types";
         ? await provider.getBalance(stateChannel.multisigAddress)
-        : await new Contract(latestState.assetId, ERC20.abi, provider).functions.balanceOf(stateChannel.multisigAddress);
+        : await new Contract(latestState.assetId, ERC20.abi, provider).balanceOf(stateChannel.multisigAddress);
     if (currentMultisigBalance.lt(latestState.startingMultisigBalance)) {
@@ -26,4 +26,4 @@ throw new Error(`Refusing to uninstall, current multisig balance (${currentMultisigBalance.toString()}) is less than starting multisig balance (${latestState.startingMultisigBalance.toString()})`);
     const depositApp = stateChannel.appInstances.find(([id, app]) => {
-        return (app.appInterface.addr === proposal.appDefinition &&
-            app.latestState["assetId"] === proposal.initialState["assetId"]);
+        return (app.appDefinition === proposal.appDefinition &&
+            app.latestState["assetId"] === proposal.latestState["assetId"]);
     });
@@ -30,0 +30,0 @@ if (depositApp) {

dist/src/DepositApp/registry.d.ts

 import { AppRegistryInfo } from "../shared";
 export declare const DepositAppRegistryInfo: AppRegistryInfo;
-export declare const DEPOSIT_STATE_TIMEOUT: import("ethers/utils").BigNumber;
+export declare const DEPOSIT_STATE_TIMEOUT: import("ethers").BigNumber;
 //# sourceMappingURL=registry.d.ts.map

dist/src/DepositApp/validation.js

@@ -34,10 +34,10 @@ import { CONVENTION_FOR_ETH_ASSET_ID, } from "@connext/types";
         ? await provider.getBalance(multisigAddress)
-        : await new Contract(initialState.assetId, ERC20.abi, provider).functions.balanceOf(multisigAddress);
+        : await new Contract(initialState.assetId, ERC20.abi, provider).balanceOf(multisigAddress);
     const multisig = new Contract(multisigAddress, MinimumViableMultisig.abi, provider);
     let startingTotalAmountWithdrawn;
     try {
-        startingTotalAmountWithdrawn = await multisig.functions.totalAmountWithdrawn(initialState.assetId);
+        startingTotalAmountWithdrawn = await multisig.totalAmountWithdrawn(initialState.assetId);
     }
     catch (e) {
-        const NOT_DEPLOYED_ERR = `contract not deployed (contractAddress="${multisigAddress}"`;
+        const NOT_DEPLOYED_ERR = `CALL_EXCEPTION`;
         if (!e.message.includes(NOT_DEPLOYED_ERR)) {
@@ -44,0 +44,0 @@ throw new Error(e);

dist/src/HashLockTransferApp/registry.d.ts

 import { AppRegistryInfo } from "../shared";
 export declare const HashLockTransferAppRegistryInfo: AppRegistryInfo;
-export declare const HASHLOCK_TRANSFER_STATE_TIMEOUT: import("ethers/utils").BigNumber;
+export declare const HASHLOCK_TRANSFER_STATE_TIMEOUT: import("ethers").BigNumber;
 //# sourceMappingURL=registry.d.ts.map

dist/src/index.d.ts

@@ -1,2 +0,2 @@
-export declare const TRANSFER_TIMEOUT: import("ethers/utils").BigNumber;
+export declare const TRANSFER_TIMEOUT: import("ethers").BigNumber;
 export * from "./DepositApp";
@@ -3,0 +3,0 @@ export * from "./HashLockTransferApp";

dist/src/middleware.js

@@ -51,3 +51,3 @@ import { ProtocolNames, } from "@connext/types";
     const { appInstance } = middlewareContext;
-    const appDef = appInstance.appInterface.addr;
+    const appDef = appInstance.appDefinition;
     switch (appDef) {
@@ -54,0 +54,0 @@ case network.contractAddresses.DepositApp: {

dist/src/shared/registry.d.ts

@@ -10,4 +10,4 @@ import { OutcomeType, SupportedApplicationNames } from "@connext/types";
 export declare type AppRegistryType = AppRegistryInfo[];
-export declare const DEFAULT_APP_TIMEOUT: import("ethers/utils").BigNumber;
-export declare const MINIMUM_APP_TIMEOUT: import("ethers/utils").BigNumber;
+export declare const DEFAULT_APP_TIMEOUT: import("ethers").BigNumber;
+export declare const MINIMUM_APP_TIMEOUT: import("ethers").BigNumber;
 //# sourceMappingURL=registry.d.ts.map

dist/src/shared/validation.d.ts

 import { CoinTransfer, ProtocolParams } from "@connext/types";
-import { utils } from "ethers";
+import { BigNumber } from "ethers";
 import { AppRegistryInfo } from "./registry";
-export declare const baseCoinTransferValidation: (initiatorDeposit: utils.BigNumber, responderDeposit: utils.BigNumber, initiatorTransfer: CoinTransfer, responderTransfer: CoinTransfer) => void;
-export declare const unidirectionalCoinTransferValidation: (initiatorDeposit: utils.BigNumber, responderDeposit: utils.BigNumber, initiatorTransfer: CoinTransfer, responderTransfer: CoinTransfer) => void;
+export declare const baseCoinTransferValidation: (initiatorDeposit: BigNumber, responderDeposit: BigNumber, initiatorTransfer: CoinTransfer, responderTransfer: CoinTransfer) => void;
+export declare const unidirectionalCoinTransferValidation: (initiatorDeposit: BigNumber, responderDeposit: BigNumber, initiatorTransfer: CoinTransfer, responderTransfer: CoinTransfer) => void;
 export declare const commonAppProposalValidation: (params: ProtocolParams.Propose, appRegistryInfo: AppRegistryInfo, supportedTokenAddresses: string[]) => void;
 //# sourceMappingURL=validation.d.ts.map

dist/src/SimpleLinkedTransferApp/registry.d.ts

 import { AppRegistryInfo } from "../shared";
 export declare const SimpleLinkedTransferAppRegistryInfo: AppRegistryInfo;
-export declare const LINKED_TRANSFER_STATE_TIMEOUT: import("ethers/utils").BigNumber;
+export declare const LINKED_TRANSFER_STATE_TIMEOUT: import("ethers").BigNumber;
 //# sourceMappingURL=registry.d.ts.map

dist/src/SimpleSignedTransferApp/registry.d.ts

 import { AppRegistryInfo } from "../shared";
 export declare const SimpleSignedTransferAppRegistryInfo: AppRegistryInfo;
-export declare const SIGNED_TRANSFER_STATE_TIMEOUT: import("ethers/utils").BigNumber;
+export declare const SIGNED_TRANSFER_STATE_TIMEOUT: import("ethers").BigNumber;
 //# sourceMappingURL=registry.d.ts.map

dist/src/SimpleTwoPartySwapApp/registry.d.ts

 import { AppRegistryInfo } from "../shared";
 export declare const SimpleTwoPartySwapAppRegistryInfo: AppRegistryInfo;
-export declare const SWAP_STATE_TIMEOUT: import("ethers/utils").BigNumber;
+export declare const SWAP_STATE_TIMEOUT: import("ethers").BigNumber;
 //# sourceMappingURL=registry.d.ts.map

dist/src/SimpleTwoPartySwapApp/validation.js

 import { calculateExchange, getAddressFromAssetId, stringify } from "@connext/utils";
-import { utils } from "ethers";
-const { bigNumberify } = utils;
+import { BigNumber } from "ethers";
 const ALLOWED_DISCREPANCY_PCT = 5;
@@ -15,3 +14,3 @@ export const validateSimpleSwapApp = (params, allowedSwaps, ourRate) => {
     const allowedDiscrepancy = calculated
-        .mul(bigNumberify(100).sub(ALLOWED_DISCREPANCY_PCT))
+        .mul(BigNumber.from(100).sub(ALLOWED_DISCREPANCY_PCT))
         .div(100);
@@ -18,0 +17,0 @@ if (calculatedToActualDiscrepancy.gt(allowedDiscrepancy)) {

dist/src/WithdrawApp/registry.d.ts

 import { AppRegistryInfo } from "../shared";
 export declare const WithdrawAppRegistryInfo: AppRegistryInfo;
-export declare const WITHDRAW_STATE_TIMEOUT: import("ethers/utils").BigNumber;
+export declare const WITHDRAW_STATE_TIMEOUT: import("ethers").BigNumber;
 //# sourceMappingURL=registry.d.ts.map

dist/src/WithdrawApp/withdrawCommitment.d.ts

 import { MultisigCommitment } from "@connext/contracts";
 import { MultisigTransaction, ContractAddresses } from "@connext/types";
-import { utils } from "ethers";
+import { BigNumberish } from "ethers";
 export declare class WithdrawCommitment extends MultisigCommitment {
@@ -10,7 +10,7 @@ readonly contractAddresses: ContractAddresses;
     readonly assetId: string;
-    readonly amount: utils.BigNumberish;
+    readonly amount: BigNumberish;
     readonly nonce: string;
-    constructor(contractAddresses: ContractAddresses, multisigAddress: string, multisigOwners: string[], recipient: string, assetId: string, amount: utils.BigNumberish, nonce: string);
+    constructor(contractAddresses: ContractAddresses, multisigAddress: string, multisigOwners: string[], recipient: string, assetId: string, amount: BigNumberish, nonce: string);
     getTransactionDetails(): MultisigTransaction;
 }
 //# sourceMappingURL=withdrawCommitment.d.ts.map

dist/src/WithdrawApp/withdrawCommitment.js

@@ -21,3 +21,3 @@ import { MultisigCommitment, ConditionalTransactionDelegateTarget } from "@connext/contracts";
             value: 0,
-            data: iface.functions.withdrawWrapper.encode([
+            data: iface.encodeFunctionData("withdrawWrapper", [
                 this.recipient,
@@ -24,0 +24,0 @@ this.assetId,

package.json

 {
   "name": "@connext/apps",
-  "version": "6.7.1",
+  "version": "7.0.0-alpha.0",
   "description": "Connext Counterfactual Apps",
@@ -21,6 +21,6 @@ "main": "dist/index.js",
   "devDependencies": {
-    "@connext/contracts": "3.2.1",
-    "@connext/utils": "6.7.1",
-    "@connext/types": "6.7.1",
-    "ethers": "4.0.47",
+    "@connext/contracts": "3.2.2",
+    "@connext/utils": "7.0.0-alpha.0",
+    "@connext/types": "7.0.0-alpha.0",
+    "ethers": "5.0.0-beta.190",
     "rollup": "2.12.1",
@@ -27,0 +27,0 @@ "@rollup/plugin-json": "4.0.3",

src/DepositApp/middleware.ts

@@ -34,3 +34,3 @@ import {
       ? await provider.getBalance(stateChannel.multisigAddress)
-      : await new Contract(latestState.assetId, ERC20.abi as any, provider).functions.balanceOf(
+      : await new Contract(latestState.assetId, ERC20.abi, provider).balanceOf(
           stateChannel.multisigAddress,
@@ -62,4 +62,4 @@ );
     return (
-      app.appInterface.addr === proposal.appDefinition &&
-      app.latestState["assetId"] === proposal.initialState["assetId"]
+      app.appDefinition === proposal.appDefinition &&
+      app.latestState["assetId"] === proposal.latestState["assetId"]
     );
@@ -66,0 +66,0 @@ });

src/DepositApp/validation.ts

@@ -81,14 +81,10 @@ import {
       ? await provider.getBalance(multisigAddress)
-      : await new Contract(initialState.assetId, ERC20.abi as any, provider).functions.balanceOf(
-          multisigAddress,
-        );
+      : await new Contract(initialState.assetId, ERC20.abi, provider).balanceOf(multisigAddress);
 
-  const multisig = new Contract(multisigAddress, MinimumViableMultisig.abi as any, provider);
+  const multisig = new Contract(multisigAddress, MinimumViableMultisig.abi, provider);
   let startingTotalAmountWithdrawn;
   try {
-    startingTotalAmountWithdrawn = await multisig.functions.totalAmountWithdrawn(
-      initialState.assetId,
-    );
+    startingTotalAmountWithdrawn = await multisig.totalAmountWithdrawn(initialState.assetId);
   } catch (e) {
-    const NOT_DEPLOYED_ERR = `contract not deployed (contractAddress="${multisigAddress}"`;
+    const NOT_DEPLOYED_ERR = `CALL_EXCEPTION`;
     if (!e.message.includes(NOT_DEPLOYED_ERR)) {
@@ -95,0 +91,0 @@ throw new Error(e);

src/middleware.ts

@@ -93,3 +93,3 @@ import {
   const { appInstance } = middlewareContext;
-  const appDef = appInstance.appInterface.addr;
+  const appDef = appInstance.appDefinition;
   switch (appDef) {
@@ -96,0 +96,0 @@ case network.contractAddresses.DepositApp: {

src/shared/validation.ts

 import { CoinTransfer, DepositAppName, ProtocolParams } from "@connext/types";
 import { getAddressFromAssetId, stringify } from "@connext/utils";
-import { constants, utils } from "ethers";
+import { BigNumber, constants } from "ethers";
 
@@ -42,4 +42,4 @@ import { AppRegistryInfo, DEFAULT_APP_TIMEOUT, MINIMUM_APP_TIMEOUT } from "./registry";
 export const baseCoinTransferValidation = (
-  initiatorDeposit: utils.BigNumber,
-  responderDeposit: utils.BigNumber,
+  initiatorDeposit: BigNumber,
+  responderDeposit: BigNumber,
   initiatorTransfer: CoinTransfer,
@@ -73,4 +73,4 @@ responderTransfer: CoinTransfer,
 export const unidirectionalCoinTransferValidation = (
-  initiatorDeposit: utils.BigNumber,
-  responderDeposit: utils.BigNumber,
+  initiatorDeposit: BigNumber,
+  responderDeposit: BigNumber,
   initiatorTransfer: CoinTransfer,
@@ -77,0 +77,0 @@ responderTransfer: CoinTransfer,

src/SimpleTwoPartySwapApp/validation.ts

 import { AllowedSwap, SwapRate, ProtocolParams } from "@connext/types";
 import { calculateExchange, getAddressFromAssetId, stringify } from "@connext/utils";
-import { utils } from "ethers";
+import { BigNumber } from "ethers";
 
-const { bigNumberify } = utils;
-
 const ALLOWED_DISCREPANCY_PCT = 5;
@@ -43,3 +41,3 @@
   const allowedDiscrepancy = calculated
-    .mul(bigNumberify(100).sub(ALLOWED_DISCREPANCY_PCT))
+    .mul(BigNumber.from(100).sub(ALLOWED_DISCREPANCY_PCT))
     .div(100);
@@ -46,0 +44,0 @@

src/WithdrawApp/withdrawCommitment.ts

 import { MultisigCommitment, ConditionalTransactionDelegateTarget } from "@connext/contracts";
 import { MultisigTransaction, MultisigOperation, ContractAddresses } from "@connext/types";
-import { utils } from "ethers";
+import { BigNumberish, utils } from "ethers";
 
@@ -15,3 +15,3 @@ const { Interface } = utils;
     public readonly assetId: string,
-    public readonly amount: utils.BigNumberish,
+    public readonly amount: BigNumberish,
     public readonly nonce: string,
@@ -26,3 +26,3 @@ ) {
       value: 0,
-      data: iface.functions.withdrawWrapper.encode([
+      data: iface.encodeFunctionData("withdrawWrapper", [
         this.recipient,
@@ -29,0 +29,0 @@ this.assetId,

New alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

703778

increased by8.33%

Worsened metrics

Lines of code

2783

decreased by-0.32%

Number of low quality alerts

3

increased by50%

No dependency changes