@creamery/socket.io-rpc - npm Package Compare versions

Comparing version 1.0.9 to 1.0.10

lib/common.d.ts

@@ -30,1 +30,6 @@ /// <reference types="socket.io-client" />
 }
+export interface Disposable {
+    dispose(): void;
+}
+export declare function createDisposable(func: () => void): Disposable;
+export declare function isDisposable(disposable: any): any;

lib/common.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+function createDisposable(func) {
+    return {
+        dispose: func,
+    };
+}
+exports.createDisposable = createDisposable;
+function isDisposable(disposable) {
+    return disposable && disposable.dispose;
+}
+exports.isDisposable = isDisposable;
 //# sourceMappingURL=common.js.map

lib/index.js

@@ -6,4 +6,5 @@ "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+__export(require("./common"));
 __export(require("./rpc-client"));
 __export(require("./rpc-server"));
 //# sourceMappingURL=index.js.map

lib/rpc-server.d.ts

@@ -26,3 +26,3 @@ import SocketIO from 'socket.io';
 export declare class SocketIORPC {
-    private readonly pool;
+    private readonly vendors;
     register(vendor: Vendor): void;
@@ -29,0 +29,0 @@ join(client: SocketIO.Socket): void;

lib/rpc-server.js

@@ -7,2 +7,5 @@ "use strict";
 const socket_io_1 = __importDefault(require("socket.io"));
+const common_1 = require("./common");
+const disposable_1 = require("./disposable");
+const util_1 = require("util");
 function createCallback({ seq, id, method }, client) {
@@ -17,4 +20,2 @@ function cb(...result) {
         }
-        else {
-        }
     }
@@ -56,8 +57,9 @@ return cb;
     constructor() {
-        this.pool = new Map();
+        this.vendors = new Map();
     }
     register(vendor) {
-        this.pool.set(vendor.id, vendor);
+        this.vendors.set(vendor.id, vendor);
     }
     join(client) {
+        client.toDispose = new disposable_1.DisposableCollection();
         client.on('call', (message, callback) => {
@@ -69,6 +71,10 @@ this.call(message, callback);
         });
+        client.on('disconnect', () => {
+            const toDispose = client.toDispose;
+            toDispose.dispose();
+        });
     }
     notify(msg, client) {
         const { id, channel, params, seq } = msg;
-        const vendor = this.pool.get(id);
+        const vendor = this.vendors.get(id);
         if (!vendor) {
@@ -79,6 +85,10 @@ console.info('not found vendor', id);
         const method = `on${channel}`;
-        if (typeof vendor[method] === 'function') {
+        if (util_1.isFunction(vendor[method])) {
             try {
-                params.push(createCallback({ seq, id, method }, client));
-                vendor[method](...params);
+                const cb = createCallback({ seq, id, method }, client);
+                params.push(cb);
+                const disposable = vendor[method](...params);
+                if (common_1.isDisposable(disposable)) {
+                    client.toDispose.push(disposable);
+                }
             }
@@ -93,3 +103,3 @@ catch (err) {
         const { id, method, params } = msg;
-        const vendor = this.pool.get(id);
+        const vendor = this.vendors.get(id);
         if (!vendor) {
@@ -101,3 +111,3 @@ console.info('not found vendor', id);
             const p = vendor[method](...params);
-            if (typeof p.then === 'function' && typeof p.catch === 'function') {
+            if (util_1.isFunction(p.then) && util_1.isFunction(p.catch)) {
                 p.then((result) => {
@@ -104,0 +114,0 @@ callback(SuccessResponse(id, method, result));

package.json

 {
   "name": "@creamery/socket.io-rpc",
-  "version": "1.0.9",
+  "version": "1.0.10",
   "description": "RPC for SocketIO",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

20917

increased by18.73%

Number of package files

18

increased by20%

Lines of code

371

increased by20.45%

No dependency changes