@cubejs-backend/query-orchestrator - npm Package Compare versions

Comparing version 0.18.0 to 0.18.1

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+## [0.18.1](https://github.com/cube-js/cube.js/compare/v0.18.0...v0.18.1) (2020-03-01)
+
+
+### Bug Fixes
+
+* Remove user facing errors for pre-aggregations refreshes ([d15c551](https://github.com/cube-js/cube.js/commit/d15c551))
+
+
+
+
+
 # [0.18.0](https://github.com/cube-js/cube.js/compare/v0.17.10...v0.18.0) (2020-03-01)
@@ -8,0 +19,0 @@

orchestrator/PreAggregations.js

@@ -289,10 +289,3 @@ const crypto = require('crypto');
         } else {
-          if (
-            this.preAggregations.refreshErrors[newVersionEntry.table_name] &&
-            this.preAggregations.refreshErrors[newVersionEntry.table_name][newVersionEntry.content_version] &&
-            this.preAggregations.refreshErrors[newVersionEntry.table_name][newVersionEntry.content_version].counter > 10) {
-            throw this.preAggregations.refreshErrors[newVersionEntry.table_name][newVersionEntry.content_version].error;
-          } else {
-            this.scheduleRefresh(invalidationKeys, newVersionEntry);
-          }
+          this.scheduleRefresh(invalidationKeys, newVersionEntry);
         }
@@ -351,14 +344,4 @@ }
     this.executeInQueue(invalidationKeys, this.priority(0), newVersionEntry)
-      .then(() => {
-        delete this.preAggregations.refreshErrors[newVersionEntry.table_name];
-      })
       .catch(e => {
         if (!(e instanceof ContinueWaitError)) {
-          this.preAggregations.refreshErrors[newVersionEntry.table_name] = this.preAggregations.refreshErrors[newVersionEntry.table_name] || {};
-          if (!this.preAggregations.refreshErrors[newVersionEntry.table_name][newVersionEntry.content_version]) {
-            this.preAggregations.refreshErrors[newVersionEntry.table_name][newVersionEntry.content_version] = { error: e, counter: 1 };
-          } else {
-            this.preAggregations.refreshErrors[newVersionEntry.table_name][newVersionEntry.content_version].error = e;
-            this.preAggregations.refreshErrors[newVersionEntry.table_name][newVersionEntry.content_version].counter += 1;
-          }
           this.logger('Error refreshing pre-aggregation', {
@@ -546,3 +529,2 @@ error: (e.stack || e), preAggregation: this.preAggregation, requestId: this.requestId
     this.queryCache = queryCache;
-    this.refreshErrors = {}; // TODO should be in redis
     this.cacheDriver = options.cacheAndQueueDriver === 'redis' ?
@@ -549,0 +531,0 @@ new RedisCacheDriver(options.redisPool) :

package.json

@@ -5,3 +5,3 @@ {
   "author": "Statsbot, Inc.",
-  "version": "0.18.0",
+  "version": "0.18.1",
   "repository": {
@@ -29,3 +29,3 @@ "type": "git",
   "license": "Apache-2.0",
-  "gitHead": "dceaf46e6bf44c7279a3834315f2e8121df0af6d"
+  "gitHead": "7bcb941bbe21b1bc89992134439a79b51634b2cd"
 }

No alert changes

Worsened metrics

Total package byte prevSize

158567

decreased by-0.68%

Lines of code

2285

decreased by-0.78%

No dependency changes