@cycle/dom - npm Package Compare versions

Comparing version 20.0.0 to 20.1.0

CHANGELOG.md

@@ -0,1 +1,11 @@
+<a name="20.1.0"></a>
+# 20.1.0 (2017-11-11)
+
+
+### Bug Fixes
+
+* **dom:** fix race condition between DOM ready and cycle/run replication ([9fcec3c](https://github.com/cyclejs/cyclejs/commit/9fcec3c))
+
+
+
 <a name="20.0.0"></a>
@@ -2,0 +12,0 @@ # 20.0.0 (2017-11-10)

lib/cjs/makeDOMDriver.js

@@ -85,2 +85,9 @@ "use strict";
         });
+        // We need to subscribe to the sink (i.e. vnode$) synchronously inside this
+        // driver, and not later in the map().flatten() because this sink is in
+        // reality a SinkProxy from @cycle/run, and we don't want to miss the first
+        // emission when the main() is connected to the drivers.
+        // Read more in issue #739.
+        var rememberedVNode$ = vnode$.remember();
+        rememberedVNode$.addListener({});
         // The mutation observer internal to mutationConfirmed$ should
@@ -92,3 +99,3 @@ // exist before elementAfterPatch$ calls mutationObserver.observe()
             return xstream_1.default
-                .merge(vnode$.endWhen(sanitation$), sanitation$)
+                .merge(rememberedVNode$.endWhen(sanitation$), sanitation$)
                 .map(function (vnode) { return vnodeWrapper.call(vnode); })
@@ -95,0 +102,0 @@ .fold(patch, tovnode_1.toVNode(firstRoot))

lib/es6/makeDOMDriver.js

@@ -83,2 +83,9 @@ import { init } from 'snabbdom';
         });
+        // We need to subscribe to the sink (i.e. vnode$) synchronously inside this
+        // driver, and not later in the map().flatten() because this sink is in
+        // reality a SinkProxy from @cycle/run, and we don't want to miss the first
+        // emission when the main() is connected to the drivers.
+        // Read more in issue #739.
+        var rememberedVNode$ = vnode$.remember();
+        rememberedVNode$.addListener({});
         // The mutation observer internal to mutationConfirmed$ should
@@ -90,3 +97,3 @@ // exist before elementAfterPatch$ calls mutationObserver.observe()
             return xs
-                .merge(vnode$.endWhen(sanitation$), sanitation$)
+                .merge(rememberedVNode$.endWhen(sanitation$), sanitation$)
                 .map(function (vnode) { return vnodeWrapper.call(vnode); })
@@ -93,0 +100,0 @@ .fold(patch, toVNode(firstRoot))

package.json

 {
   "name": "@cycle/dom",
-  "version": "20.0.0",
+  "version": "20.1.0",
   "description": "The standard DOM Driver for Cycle.js, based on Snabbdom",
@@ -5,0 +5,0 @@ "license": "MIT",

src/makeDOMDriver.ts

@@ -109,2 +109,10 @@ import {Driver, FantasyObservable} from '@cycle/run';
 
+    // We need to subscribe to the sink (i.e. vnode$) synchronously inside this
+    // driver, and not later in the map().flatten() because this sink is in
+    // reality a SinkProxy from @cycle/run, and we don't want to miss the first
+    // emission when the main() is connected to the drivers.
+    // Read more in issue #739.
+    const rememberedVNode$ = vnode$.remember();
+    rememberedVNode$.addListener({});
+
     // The mutation observer internal to mutationConfirmed$ should
@@ -118,3 +126,3 @@ // exist before elementAfterPatch$ calls mutationObserver.observe()
           xs
-            .merge(vnode$.endWhen(sanitation$), sanitation$)
+            .merge(rememberedVNode$.endWhen(sanitation$), sanitation$)
             .map(vnode => vnodeWrapper.call(vnode))
@@ -121,0 +129,0 @@ .fold(patch, toVNode(firstRoot))

No alert changes

Improved metrics

Total package byte prevSize

1188285

increased by0.2%

Lines of code

26684

increased by0.11%

No dependency changes