@cycle/dom - npm Package Compare versions

Comparing version 8.0.0-rc2 to 8.0.0-rc3

lib/render-dom.js

@@ -100,4 +100,5 @@ "use strict";
       }
-      var classList = el.className.split(" ");
-      if (classList.some(classIsForeign)) {
+
+      var classList = el.classList || el.className.split(" ");
+      if (Array.prototype.some.call(classList, classIsForeign)) {
         return false;
@@ -104,0 +105,0 @@ }

package.json

 {
   "name": "@cycle/dom",
-  "version": "8.0.0-rc2",
+  "version": "8.0.0-rc3",
   "author": "Andre Staltz",
@@ -5,0 +5,0 @@ "description": "The standard DOM Driver for Cycle.js, based on virtual-dom, and other helpers",

src/render-dom.js

@@ -85,4 +85,5 @@ let Rx = require(`rx`)
       }
-      const classList = el.className.split(` `)
-      if (classList.some(classIsForeign)) {
+
+      const classList = el.classList || el.className.split(` `)
+      if (Array.prototype.some.call(classList, classIsForeign)) {
         return false
@@ -89,0 +90,0 @@ }

test/browser/render.js

@@ -9,3 +9,3 @@ /** @jsx hJSX */
 let Rx = require('rx');
-let {h, div, p, span, h2, h3, h4, hJSX, select, option, makeDOMDriver} = CycleDOM;
+let {h, svg, div, p, span, h2, h3, h4, hJSX, select, option, makeDOMDriver} = CycleDOM;
 
@@ -651,2 +651,33 @@ function createRenderTarget(id = null) {
       });
+
+      it('should select svg element', function (done) {
+        function app() {
+          let svgTriangle = svg('svg', {width: 150, height: 150}, [
+            svg('polygon', {
+              class: 'triangle',
+              attributes: {
+                points: '20 0 20 150 150 20'
+              }
+            }),
+          ]);
+
+          return {
+            DOM: Rx.Observable.just(h('div', svgTriangle))
+          };
+        }
+
+        let {sinks, sources} = Cycle.run(app, {
+          DOM: makeDOMDriver(createRenderTarget())
+        });
+
+        // Make assertions
+        const selection = sources.DOM.select('.triangle').observable.skip(1).take(1).subscribe(elements => {
+          assert.strictEqual(elements.length, 1);
+          let triangleElement = elements[0];
+          assert.notStrictEqual(triangleElement, null);
+          assert.notStrictEqual(typeof triangleElement, 'undefined');
+          assert.strictEqual(triangleElement.tagName, 'polygon');
+          done();
+        });
+      });
     });
@@ -653,0 +684,0 @@

No alert changes

Improved metrics

Total package byte prevSize

326940

increased by0.36%

Lines of code

6061

increased by0.45%

No dependency changes