@datagrok/bio - npm Package Compare versions

Comparing version 2.16.8 to 2.16.9

CHANGELOG.md

 # Bio changelog
 
+## 2.16.9 (2024-11-01)
+
+Correct package initialization
+
 ## 2.16.8 (2024-10-31)
@@ -4,0 +8,0 @@

package.json

@@ -8,3 +8,3 @@ {
   },
-  "version": "2.16.8",
+  "version": "2.16.9",
   "description": "Bioinformatics support (import/export of sequences, conversion, visualization, analysis). [See more](https://github.com/datagrok-ai/public/blob/master/packages/Bio/README.md) for details.",
@@ -41,3 +41,3 @@ "repository": {
     "@biowasm/aioli": "^3.1.0",
-    "@datagrok-libraries/bio": "^5.45.6",
+    "@datagrok-libraries/bio": "^5.45.7",
     "@datagrok-libraries/chem-meta": "^1.2.7",
@@ -44,0 +44,0 @@ "@datagrok-libraries/math": "^1.2.2",

src/package.ts

@@ -105,5 +105,5 @@ /* eslint max-lines: "off" */
 export async function initBio(): Promise<void> {
-  if (initBioPromise === null) {
+  if (initBioPromise === null)
     initBioPromise = initBioInt();
-  }
+
   await initBioPromise;
@@ -115,35 +115,27 @@ }
   _package.logger.debug(`${logPrefix}, start`);
-  let monomerLib!: IMonomerLib;
-  let monomerSets!: IMonomerSet;
-  let rdKitModule!: RDModule;
-  let libHelper!: MonomerLibManager;
   const t1: number = window.performance.now();
-  await Promise.all([
-    (async () => {
-      libHelper = await MonomerLibManager.getInstance();
-      // Fix user lib settings for explicit stuck from a terminated test
-      const libSettings = await getUserLibSettings();
-      if (libSettings.explicit) {
-        libSettings.explicit = [];
-        await setUserLibSettings(libSettings);
-      }
-      libHelper.awaitLoaded(Infinity).then(() => {
-        // Do not wait for monomers and sets loaded
-        return Promise.all([libHelper.loadMonomerLib(), libHelper.loadMonomerSets()]);
-      });
-      monomerLib = libHelper.getMonomerLib();
-      monomerSets = libHelper.getMonomerSets();
-    })(),
-    (async () => {
-      const pkgProps = await _package.getProperties();
-      const bioPkgProps = new BioPackageProperties(pkgProps);
-      _package.properties = bioPkgProps;
-    })(),
-    (async () => { rdKitModule = await getRdKitModule(); })(),
-  ]).finally(() => {
-    const t2: number = window.performance.now();
-    _package.logger.debug(`${logPrefix}, loading ET: ${t2 - t1} ms`);
+  // very important that loading should happen in correct order!
+  // first make sure chem and rdkit module are loaded
+  const rdKitModule = await getRdKitModule();
+  // then load package settings
+  const pkgProps = await _package.getProperties();
+  const bioPkgProps = new BioPackageProperties(pkgProps);
+  _package.properties = bioPkgProps;
+  // then load monomer lib
+  const libHelper = await MonomerLibManager.getInstance();
+  // Fix user lib settings for explicit stuck from a terminated test
+  const libSettings = await getUserLibSettings();
+  if (libSettings.explicit) {
+    libSettings.explicit = [];
+    await setUserLibSettings(libSettings);
+  }
+  libHelper.awaitLoaded(Infinity).then(() => {
+    // Do not wait for monomers and sets loaded
+    return Promise.all([libHelper.loadMonomerLib(), libHelper.loadMonomerSets()]);
   });
-  const seqHelper = new SeqHelper(libHelper, rdKitModule);
-  _package.completeInit(seqHelper, monomerLib, monomerSets, rdKitModule);
+  const monomerLib = libHelper.getMonomerLib();
+  const monomerSets = libHelper.getMonomerSets();
+  // finally log
+  const t2: number = window.performance.now();
+  _package.logger.debug(`${logPrefix}, loading ET: ${t2 - t1} ms`);
 
@@ -153,2 +145,4 @@ const monomers: string[] = [];
 
+  const seqHelper = new SeqHelper(libHelper, rdKitModule);
+  _package.completeInit(seqHelper, monomerLib, monomerSets, rdKitModule);
   const series = monomerLib!.getMonomerMolsByPolymerType('PEPTIDE')!;
@@ -1222,2 +1216,3 @@ Object.keys(series).forEach((symbol) => {
 export async function getSeqHelper(): Promise<ISeqHelper> {
+  await initBio();
   return _package.seqHelper;
@@ -1224,0 +1219,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

23325278

Worsened metrics

Lines of code

44948

decreased by-0.02%

Dependency changes

• Updated@datagrok-libraries/bio@^5.45.7