@deephaven/console - npm Package Compare versions

Comparing version 0.2.1 to 0.3.0

dist/common/index.d.ts

 export { default as ObjectIcon } from './ObjectIcon';
 export { default as Code } from './Code';
+export { default as ConsoleConstants } from './ConsoleConstants';
+export { default as ConsoleUtils } from './ConsoleUtils';
 //# sourceMappingURL=index.d.ts.map

dist/common/index.js

 export { default as ObjectIcon } from './ObjectIcon';
 export { default as Code } from './Code';
+export { default as ConsoleConstants } from './ConsoleConstants';
+export { default as ConsoleUtils } from './ConsoleUtils';
 //# sourceMappingURL=index.js.map

dist/console-history/ConsoleHistoryResultErrorMessage.d.ts

@@ -8,7 +8,7 @@ export default ConsoleHistoryResultErrorMessage;
     handleMouseMove(event: any): void;
-    handleMouseUp(): void;
+    handleMouseUp(event: any): void;
     handleToggleError(): void;
     mouseX: any;
     mouseY: any;
-    isDragging: boolean;
+    isClicking: boolean;
 }
@@ -15,0 +15,0 @@ declare namespace ConsoleHistoryResultErrorMessage {

dist/console-history/ConsoleHistoryResultErrorMessage.js

@@ -52,3 +52,3 @@ function _typeof(obj) { "@babel/helpers - typeof"; if (typeof Symbol === "function" && typeof Symbol.iterator === "symbol") { _typeof = function _typeof(obj) { return typeof obj; }; } else { _typeof = function _typeof(obj) { return obj && typeof Symbol === "function" && obj.constructor === Symbol && obj !== Symbol.prototype ? "symbol" : typeof obj; }; } return _typeof(obj); }
     _this.mouseY = null;
-    _this.isDragging = false;
+    _this.isClicking = false;
     _this.state = {
@@ -81,3 +81,3 @@ isExpanded: false
       this.mouseY = event.clientY;
-      this.isDragging = false;
+      this.isClicking = true;
     }
@@ -89,4 +89,7 @@ }, {
         if (Math.abs(event.clientX - this.mouseX) >= ConsoleHistoryResultErrorMessage.mouseDragThreshold || Math.abs(event.clientY - this.mouseY) >= ConsoleHistoryResultErrorMessage.mouseDragThreshold) {
-          this.isDragging = true;
+          this.isClicking = false;
         }
+      } else if (this.isClicking) {
+        // Rare case - could happen if you mouse down, switch window focus, release the mouse, then come back, mouse down outside of the error, drag into the error, then release the mouse
+        this.isClicking = false;
       }
@@ -96,4 +99,6 @@ }
     key: "handleMouseUp",
-    value: function handleMouseUp() {
-      if (!this.isDragging) {
+    value: function handleMouseUp(event) {
+      // We don't want to expand/collapse the error if user is holding shift or an alt key
+      // They may be trying to adjust their selection
+      if (this.isClicking && !event.shiftKey && !event.metaKey && !event.altKey) {
         this.handleToggleError();
@@ -104,3 +109,3 @@ }
       this.mouseY = null;
-      this.isDragging = false;
+      this.isClicking = false;
     }
@@ -107,0 +112,0 @@ }, {

dist/Console.d.ts

@@ -42,3 +42,2 @@ export class Console extends React.PureComponent<any, any, any> {
     handleScrollPaneScroll(): void;
-    handleScrollPaneClick(e: any): void;
     handleToggleAutoLaunchPanels(): void;
@@ -101,2 +100,3 @@ handleToggleClosePanelsOnDisconnect(): void;
             onLogMessage: PropTypes.Requireable<(...args: any[]) => any>;
+            getTable: PropTypes.Validator<(...args: any[]) => any>;
             runCode: PropTypes.Validator<(...args: any[]) => any>;
@@ -103,0 +103,0 @@ }>>;

dist/Console.js

@@ -104,3 +104,2 @@ function _typeof(obj) { "@babel/helpers - typeof"; if (typeof Symbol === "function" && typeof Symbol.iterator === "symbol") { _typeof = function _typeof(obj) { return typeof obj; }; } else { _typeof = function _typeof(obj) { return obj && typeof Symbol === "function" && obj.constructor === Symbol && obj !== Symbol.prototype ? "symbol" : typeof obj; }; } return _typeof(obj); }
     _this.handleScrollPaneScroll = _this.handleScrollPaneScroll.bind(_assertThisInitialized(_this));
-    _this.handleScrollPaneClick = _this.handleScrollPaneClick.bind(_assertThisInitialized(_this));
     _this.handleToggleAutoLaunchPanels = _this.handleToggleAutoLaunchPanels.bind(_assertThisInitialized(_this));
@@ -550,9 +549,2 @@ _this.handleToggleClosePanelsOnDisconnect = _this.handleToggleClosePanelsOnDisconnect.bind(_assertThisInitialized(_this));
   }, {
-    key: "handleScrollPaneClick",
-    value: function handleScrollPaneClick(e) {
-      if (e.target === e.currentTarget && this.consoleInput.current != null) {
-        this.consoleInput.current.focus();
-      }
-    }
-  }, {
     key: "handleToggleAutoLaunchPanels",
@@ -795,3 +787,5 @@ value: function handleToggleAutoLaunchPanels() {
         var session = this.props.session;
-        session.runCode(command);
+        session.runCode(command)["catch"](function (error) {
+          log.error('There was an error initiating the command', error);
+        });
       } else {
@@ -947,3 +941,2 @@ // Empty command, just pump a blank line out to history
         }),
-        onClick: this.handleScrollPaneClick,
         onScroll: this.handleScrollPaneScroll,
@@ -950,0 +943,0 @@ ref: this.consoleHistoryScrollPane

dist/ConsoleStatusBar.d.ts

@@ -17,2 +17,3 @@ export class ConsoleStatusBar extends React.PureComponent<any, any, any> {
             onLogMessage: PropTypes.Requireable<(...args: any[]) => any>;
+            getTable: PropTypes.Validator<(...args: any[]) => any>;
             runCode: PropTypes.Validator<(...args: any[]) => any>;
@@ -19,0 +20,0 @@ }>>;

dist/index.d.ts

@@ -5,5 +5,2 @@ export { default as ConsoleInput } from "./ConsoleInput";
 export { default as ConsoleStatusBar } from "./ConsoleStatusBar";
-export { default as Code } from "./common/Code";
-export { default as ConsoleConstants } from "./common/ConsoleConstants";
-export { default as ConsoleUtils } from "./common/ConsoleUtils";
 export { default as MonacoUtils } from "./monaco/MonacoUtils";
@@ -13,2 +10,3 @@ export { default as Editor } from "./notebook/Editor";
 export { default as ScriptEditorUtils } from "./notebook/ScriptEditorUtils";
+export * from "./common";
 export * from "./command-history";
@@ -15,0 +13,0 @@ export * from "./console-history";

dist/index.js

@@ -6,5 +6,2 @@ export { default as Console } from './Console';
 export { default as ConsoleStatusBar } from './ConsoleStatusBar';
-export { default as Code } from './common/Code';
-export { default as ConsoleConstants } from './common/ConsoleConstants';
-export { default as ConsoleUtils } from './common/ConsoleUtils';
 export { default as MonacoUtils } from './monaco/MonacoUtils';
@@ -14,2 +11,3 @@ export { default as Editor } from './notebook/Editor';
 export { default as ScriptEditorUtils } from './notebook/ScriptEditorUtils';
+export * from './common';
 export * from './command-history';
@@ -16,0 +14,0 @@ export * from './console-history';

dist/log/LogView.d.ts

@@ -72,2 +72,3 @@ export default LogView;
             onLogMessage: import("prop-types").Requireable<(...args: any[]) => any>;
+            getTable: import("prop-types").Validator<(...args: any[]) => any>;
             runCode: import("prop-types").Validator<(...args: any[]) => any>;
@@ -74,0 +75,0 @@ }>>;

package.json

 {
   "name": "@deephaven/console",
-  "version": "0.2.1",
+  "version": "0.3.0",
   "description": "Deephaven Console",
@@ -35,4 +35,2 @@ "author": "Deephaven Data Labs LLC",
     "start": "cross-env NODE_ENV=development npm run watch",
-    "test": "jest --watch",
-    "test:ci": "jest --ci",
     "predeploy": "cd example && npm install && npm run build",
@@ -73,18 +71,14 @@ "deploy": "gh-pages -d example/build"
   "devDependencies": {
-    "@babel/cli": "^7.14.3",
-    "@deephaven/components": "^0.2.1",
-    "@deephaven/icons": "^0.2.1",
-    "@deephaven/jsapi-shim": "^0.2.1",
-    "@deephaven/log": "^0.2.1",
-    "@deephaven/mocks": "^0.2.1",
-    "@deephaven/redux": "^0.2.1",
-    "@deephaven/storage": "^0.2.1",
-    "@deephaven/tsconfig": "^0.2.1",
-    "@deephaven/utils": "^0.2.1",
+    "@babel/cli": "^7.14.8",
+    "@deephaven/components": "^0.3.0",
+    "@deephaven/icons": "^0.3.0",
+    "@deephaven/jsapi-shim": "^0.3.0",
+    "@deephaven/log": "^0.3.0",
+    "@deephaven/mocks": "^0.3.0",
+    "@deephaven/redux": "^0.3.0",
+    "@deephaven/storage": "^0.3.0",
+    "@deephaven/tsconfig": "^0.3.0",
+    "@deephaven/utils": "^0.3.0",
     "@fortawesome/fontawesome-svg-core": "^1.2.32",
     "@fortawesome/react-fontawesome": "^0.1.12",
-    "@testing-library/react": "^11.2.7",
-    "@types/enzyme": "^3.10.7",
-    "@types/enzyme-adapter-react-16": "^1.0.6",
-    "@types/jest": "^26.0.23",
     "@types/react": "^16.14.8",
@@ -95,6 +89,3 @@ "@types/react-dom": "^16.9.13",
     "cross-env": "^7.0.2",
-    "enzyme": "^3.11.0",
-    "enzyme-adapter-react-16": "^1.15.2",
     "gh-pages": "^2.2.0",
-    "jest": "26.6.0",
     "jszip": "3.2.2",
@@ -113,7 +104,5 @@ "lodash.debounce": "^4.0.8",
     "react-redux": "^6.0.1",
-    "regenerator-runtime": "^0.13.7",
     "rimraf": "^3.0.2",
     "sass": "1.32.13",
     "shortid": "^2.2.15",
-    "ts-jest": "^26.5.6",
     "typescript": "^4.3.2"
@@ -130,3 +119,3 @@ },
   },
-  "gitHead": "7356846da144a095b82eaf49780ce495c578e1fc"
+  "gitHead": "1dd8d174cf5a65fdc78ab8d7864abc64883e0b03"
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

907861

increased by0.09%

Dev dependency count

35

decreased by-20.45%

Lines of code

9484

increased by0.01%

No dependency changes