@denimlabs/fb-position-validation - npm Package Compare versions

Comparing version 1.0.7 to 1.0.8

dist/index.js

@@ -19,4 +19,3 @@ "use strict";
   facebook_positions: ['feed', 'suggested_video', 'instant_article', 'instream_video', 'story'],
-  instagram_positions: ['stream'],
-  messenger_positions: ['messenger_home']
+  instagram_positions: ['stream']
 };
@@ -73,3 +72,3 @@ var ConversionPlacments = {
 var VALID_DEVICE_PLATFORMS = ['mobile', 'desktop'];
-var VALID_FACEBOOK_POSITIONS = ['feed', 'right_hand_column', 'instant_article', 'marketplace', 'story'];
+var VALID_FACEBOOK_POSITIONS = ['feed', 'right_hand_column', 'instant_article', 'marketplace', 'story', 'instream_video'];
 var VALID_PUBLISHER_PLATFORMS = ['facebook', 'instagram', 'messenger', 'audience_network'];
@@ -201,2 +200,6 @@ var VALID_INSTAGRAM_POSTIONS = ['story', 'stream'];
       publisher_platforms = _positioning$publishe2 === void 0 ? [] : _positioning$publishe2;
+  console.log({
+    publisher_platforms: publisher_platforms,
+    validPublisherPlatforms: validPublisherPlatforms
+  });
 
@@ -203,0 +206,0 @@ if ((publisher_platforms || []).length > 0 && !containsOnlyValid(publisher_platforms, validPublisherPlatforms)) {

index.js

@@ -22,4 +22,3 @@ const AwarenessPlacments = {
   ],
-  instagram_positions: ['stream'],
-  messenger_positions: ['messenger_home']
+  instagram_positions: ['stream']
 }
@@ -99,3 +98,4 @@
   'marketplace',
-  'story'
+  'story',
+  'instream_video'
 ]
@@ -329,3 +329,3 @@
   const { publisher_platforms = [] } = positioning
-
+  console.log({ publisher_platforms, validPublisherPlatforms })
   if (
@@ -332,0 +332,0 @@ (publisher_platforms || []).length > 0 &&

index.spec.js

@@ -45,5 +45,2 @@ import {
   ],
-  "messenger_positions": Array [
-    "messenger_home",
-  ],
 }
@@ -358,3 +355,20 @@ `)
     ).not.toThrowError(Error('invalid publisher platform for objective'))
+
+    expect(() =>
+      validateAllRulesByObjective('Engagement', {
+        device_platforms: [],
+        publisher_platforms: ['facebook'],
+        facebook_positions: [
+          'feed',
+          'suggested_video',
+          'instant_article',
+          'instream_video',
+          'story'
+        ],
+        instagram_positions: [],
+        audience_network_positions: [],
+        messenger_positions: []
+      })
+    ).not.toThrow()
   })
 })

package.json

 {
   "name": "@denimlabs/fb-position-validation",
-  "version": "1.0.7",
+  "version": "1.0.8",
   "description": "Validate facebook positions against denim campaign objectives.",
@@ -5,0 +5,0 @@ "main": "dist/index.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

57308

increased by1.14%

Lines of code

911

increased by1.9%

No dependency changes