@dydxprotocol/starkex-lib - npm Package Compare versions

Comparing version 0.10.1 to 0.10.2

__tests__/signable/conditional-transfer.test.ts

@@ -35,4 +35,4 @@ /**
 const mockSignature = (
-  '062b0cfbb1540d1eca1c465a29d7a12b080366055ea56ccdebfb06b450c1d38a' +
-  '0712a5d857cc9c5a7c7ba2d3a798a670e616b9a48b68f20908c47948e676576d'
+  '04814c5d3501863134108802cab5d12df4b959654332103b837252549d24e9a6' +
+  '06bc01225e9f1690b08b63de2a3b179fb2927d4564b3440bbb0da4c37caf597e'
 );
@@ -39,0 +39,0 @@

build/__tests__/signable/conditional-transfer.test.js

@@ -30,4 +30,4 @@ "use strict";
 };
-const mockSignature = ('062b0cfbb1540d1eca1c465a29d7a12b080366055ea56ccdebfb06b450c1d38a' +
-    '0712a5d857cc9c5a7c7ba2d3a798a670e616b9a48b68f20908c47948e676576d');
+const mockSignature = ('04814c5d3501863134108802cab5d12df4b959654332103b837252549d24e9a6' +
+    '06bc01225e9f1690b08b63de2a3b179fb2927d4564b3440bbb0da4c37caf597e');
 describe('SignableConditionalTransfer', () => {
@@ -34,0 +34,0 @@ describe('verifySignature()', () => {

build/src/signable/conditional-transfer.js

@@ -15,5 +15,5 @@ "use strict";
 // Note: Fees are not supported for conditional transfers.
-const FEE_POSITION_ID_BN = new bn_js_1.default(0);
 const MAX_AMOUNT_FEE_BN = new bn_js_1.default(0);
 const COLLATERAL_ASSET_ID_BN = util_1.hexToBn(constants_1.COLLATERAL_ASSET_ID);
+const FEE_ASSET_ID_BN = new bn_js_1.default(0);
 const CONDITIONAL_TRANSFER_PREFIX = 5;
@@ -71,9 +71,10 @@ const CONDITIONAL_TRANSFER_PADDING_BITS = 81;
         }
-        // The transfer asset and fee asset are always the collateral asset.
+        // The transfer asset is always the collateral asset.
         // Fees are not supported for conditional transfers.
-        const assetIds = await hashes_1.getCacheablePedersenHash(COLLATERAL_ASSET_ID_BN, COLLATERAL_ASSET_ID_BN);
+        const assetIds = await hashes_1.getCacheablePedersenHash(COLLATERAL_ASSET_ID_BN, FEE_ASSET_ID_BN);
         const transferPart1 = await hashes_1.getPedersenHash(await hashes_1.getPedersenHash(assetIds, receiverPublicKeyBn), conditionBn);
-        const transferPart2 = new bn_js_1.default(senderPositionIdBn)
+        // Note: Use toString() to avoid mutating senderPositionIdBn.
+        const transferPart2 = new bn_js_1.default(senderPositionIdBn.toString())
             .iushln(constants_2.CONDITIONAL_TRANSFER_FIELD_BIT_LENGTHS.positionId).iadd(receiverPositionIdBn)
-            .iushln(constants_2.CONDITIONAL_TRANSFER_FIELD_BIT_LENGTHS.positionId).iadd(FEE_POSITION_ID_BN)
+            .iushln(constants_2.CONDITIONAL_TRANSFER_FIELD_BIT_LENGTHS.positionId).iadd(senderPositionIdBn)
             .iushln(constants_2.CONDITIONAL_TRANSFER_FIELD_BIT_LENGTHS.nonce).iadd(nonceBn);
@@ -92,2 +93,2 @@ const transferPart3 = new bn_js_1.default(CONDITIONAL_TRANSFER_PREFIX)
 exports.SignableConditionalTransfer = SignableConditionalTransfer;
-//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiY29uZGl0aW9uYWwtdHJhbnNmZXIuanMiLCJzb3VyY2VSb290IjoiIiwic291cmNlcyI6WyIuLi8uLi8uLi9zcmMvc2lnbmFibGUvY29uZGl0aW9uYWwtdHJhbnNmZXIudHMiXSwibmFtZXMiOltdLCJtYXBwaW5ncyI6Ijs7Ozs7O0FBQUEsa0RBQXVCO0FBRXZCLDRDQUdzQjtBQUN0Qix3Q0FJb0I7QUFDcEIsc0NBS3FCO0FBS3JCLDJDQUFxRTtBQUNyRSxxQ0FHa0I7QUFDbEIscURBQWlEO0FBRWpELDBEQUEwRDtBQUMxRCxNQUFNLGtCQUFrQixHQUFHLElBQUksZUFBRSxDQUFDLENBQUMsQ0FBQyxDQUFDO0FBQ3JDLE1BQU0saUJBQWlCLEdBQUcsSUFBSSxlQUFFLENBQUMsQ0FBQyxDQUFDLENBQUM7QUFFcEMsTUFBTSxzQkFBc0IsR0FBRyxjQUFPLENBQUMsK0JBQW1CLENBQUMsQ0FBQztBQUM1RCxNQUFNLDJCQUEyQixHQUFHLENBQUMsQ0FBQztBQUN0QyxNQUFNLGlDQUFpQyxHQUFHLEVBQUUsQ0FBQztBQUU3Qzs7R0FFRztBQUNILE1BQWEsMkJBQTRCLFNBQVEsOEJBQTJDO0lBRTFGLFlBQ0UsUUFBbUM7UUFFbkMsTUFBTSxLQUFLLEdBQUcsMkJBQWlCLENBQUMsUUFBUSxDQUFDLFFBQVEsQ0FBQyxDQUFDO1FBRW5ELHFEQUFxRDtRQUNyRCxNQUFNLGNBQWMsR0FBRyx5QkFBZSxDQUFDLFFBQVEsQ0FBQyxXQUFXLEVBQUUsNEJBQWdCLENBQUMsQ0FBQztRQUUvRSwwQ0FBMEM7UUFDMUMsTUFBTSxvQkFBb0IsR0FBRyxrQ0FBd0IsQ0FBQyxRQUFRLENBQUMsc0JBQXNCLENBQUMsQ0FBQztRQUV2RixLQUFLLENBQUM7WUFDSixnQkFBZ0IsRUFBRSxRQUFRLENBQUMsZ0JBQWdCO1lBQzNDLGtCQUFrQixFQUFFLFFBQVEsQ0FBQyxrQkFBa0I7WUFDL0MsaUJBQWlCLEVBQUUsUUFBUSxDQUFDLGlCQUFpQjtZQUM3QyxTQUFTLEVBQUUsc0JBQWUsQ0FBQyxRQUFRLENBQUMsbUJBQW1CLEVBQUUsUUFBUSxDQUFDLElBQUksQ0FBQztZQUN2RSxjQUFjO1lBQ2QsS0FBSztZQUNMLG9CQUFvQjtTQUNyQixDQUFDLENBQUM7SUFDTCxDQUFDO0lBRVMsS0FBSyxDQUFDLGFBQWE7UUFDM0IsTUFBTSxrQkFBa0IsR0FBRyxjQUFPLENBQUMsSUFBSSxDQUFDLE9BQU8sQ0FBQyxnQkFBZ0IsQ0FBQyxDQUFDO1FBQ2xFLE1BQU0sb0JBQW9CLEdBQUcsY0FBTyxDQUFDLElBQUksQ0FBQyxPQUFPLENBQUMsa0JBQWtCLENBQUMsQ0FBQztRQUN0RSxNQUFNLG1CQUFtQixHQUFHLGNBQU8sQ0FBQyxJQUFJLENBQUMsT0FBTyxDQUFDLGlCQUFpQixDQUFDLENBQUM7UUFDcEUsTUFBTSxXQUFXLEdBQUcsY0FBTyxDQUFDLElBQUksQ0FBQyxPQUFPLENBQUMsU0FBUyxDQUFDLENBQUM7UUFDcEQsTUFBTSxnQkFBZ0IsR0FBRyxjQUFPLENBQUMsSUFBSSxDQUFDLE9BQU8sQ0FBQyxjQUFjLENBQUMsQ0FBQztRQUM5RCxNQUFNLE9BQU8sR0FBRyxjQUFPLENBQUMsSUFBSSxDQUFDLE9BQU8sQ0FBQyxLQUFLLENBQUMsQ0FBQztRQUM1QyxNQUFNLHNCQUFzQixHQUFHLGNBQU8sQ0FBQyxJQUFJLENBQUMsT0FBTyxDQUFDLG9CQUFvQixDQUFDLENBQUM7UUFFMUUsSUFBSSxrQkFBa0IsQ0FBQyxTQUFTLEVBQUUsR0FBRyxrREFBc0MsQ0FBQyxVQUFVLEVBQUU7WUFDdEYsTUFBTSxJQUFJLEtBQUssQ0FBQyx5REFBeUQsQ0FBQyxDQUFDO1NBQzVFO1FBQ0QsSUFDRSxvQkFBb0IsQ0FBQyxTQUFTLEVBQUUsR0FBRyxrREFBc0MsQ0FBQyxVQUFVLEVBQ3BGO1lBQ0EsTUFBTSxJQUFJLEtBQUssQ0FBQywyREFBMkQsQ0FBQyxDQUFDO1NBQzlFO1FBQ0QsSUFDRSxtQkFBbUIsQ0FBQyxTQUFTLEVBQUUsR0FBRyxrREFBc0MsQ0FBQyxpQkFBaUIsRUFDMUY7WUFDQSxNQUFNLElBQUksS0FBSyxDQUFDLDBEQUEwRCxDQUFDLENBQUM7U0FDN0U7UUFDRCxJQUFJLFdBQVcsQ0FBQyxTQUFTLEVBQUUsR0FBRyxrREFBc0MsQ0FBQyxTQUFTLEVBQUU7WUFDOUUsTUFBTSxJQUFJLEtBQUssQ0FBQyxrREFBa0QsQ0FBQyxDQUFDO1NBQ3JFO1FBQ0QsSUFBSSxnQkFBZ0IsQ0FBQyxTQUFTLEVBQUUsR0FBRyxrREFBc0MsQ0FBQyxjQUFjLEVBQUU7WUFDeEYsTUFBTSxJQUFJLEtBQUssQ0FBQyx1REFBdUQsQ0FBQyxDQUFDO1NBQzFFO1FBQ0QsSUFBSSxPQUFPLENBQUMsU0FBUyxFQUFFLEdBQUcsa0RBQXNDLENBQUMsS0FBSyxFQUFFO1lBQ3RFLE1BQU0sSUFBSSxLQUFLLENBQUMsOENBQThDLENBQUMsQ0FBQztTQUNqRTtRQUNELElBQ0Usc0JBQXNCLENBQUMsU0FBUyxFQUFFO1lBQ2xDLGtEQUFzQyxDQUFDLG9CQUFvQixFQUMzRDtZQUNBLE1BQU0sSUFBSSxLQUFLLENBQUMsNkRBQTZELENBQUMsQ0FBQztTQUNoRjtRQUVELG9FQUFvRTtRQUNwRSxvREFBb0Q7UUFDcEQsTUFBTSxRQUFRLEdBQUcsTUFBTSxpQ0FBd0IsQ0FBQyxzQkFBc0IsRUFBRSxzQkFBc0IsQ0FBQyxDQUFDO1FBRWhHLE1BQU0sYUFBYSxHQUFHLE1BQU0sd0JBQWUsQ0FDekMsTUFBTSx3QkFBZSxDQUNuQixRQUFRLEVBQ1IsbUJBQW1CLENBQ3BCLEVBQ0QsV0FBVyxDQUNaLENBQUM7UUFDRixNQUFNLGFBQWEsR0FBRyxJQUFJLGVBQUUsQ0FBQyxrQkFBa0IsQ0FBQzthQUM3QyxNQUFNLENBQUMsa0RBQXNDLENBQUMsVUFBVSxDQUFDLENBQUMsSUFBSSxDQUFDLG9CQUFvQixDQUFDO2FBQ3BGLE1BQU0sQ0FBQyxrREFBc0MsQ0FBQyxVQUFVLENBQUMsQ0FBQyxJQUFJLENBQUMsa0JBQWtCLENBQUM7YUFDbEYsTUFBTSxDQUFDLGtEQUFzQyxDQUFDLEtBQUssQ0FBQyxDQUFDLElBQUksQ0FBQyxPQUFPLENBQUMsQ0FBQztRQUN0RSxNQUFNLGFBQWEsR0FBRyxJQUFJLGVBQUUsQ0FBQywyQkFBMkIsQ0FBQzthQUN0RCxNQUFNLENBQUMsa0RBQXNDLENBQUMsY0FBYyxDQUFDLENBQUMsSUFBSSxDQUFDLGdCQUFnQixDQUFDO2FBQ3BGLE1BQU0sQ0FBQyxrREFBc0MsQ0FBQyxjQUFjLENBQUMsQ0FBQyxJQUFJLENBQUMsaUJBQWlCLENBQUM7YUFDckYsTUFBTSxDQUFDLGtEQUFzQyxDQUFDLG9CQUFvQixDQUFDLENBQUMsSUFBSSxDQUN2RSxzQkFBc0IsQ0FDdkI7YUFDQSxNQUFNLENBQUMsaUNBQWlDLENBQUMsQ0FBQztRQUU3QyxPQUFPLHdCQUFlLENBQ3BCLE1BQU0sd0JBQWUsQ0FDbkIsYUFBYSxFQUNiLGFBQWEsQ0FDZCxFQUNELGFBQWEsQ0FDZCxDQUFDO0lBQ0osQ0FBQztJQUVELFdBQVc7UUFDVCxPQUFPLElBQUksQ0FBQyxPQUFPLENBQUM7SUFDdEIsQ0FBQztDQUNGO0FBakdELGtFQWlHQyJ9
+//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiY29uZGl0aW9uYWwtdHJhbnNmZXIuanMiLCJzb3VyY2VSb290IjoiIiwic291cmNlcyI6WyIuLi8uLi8uLi9zcmMvc2lnbmFibGUvY29uZGl0aW9uYWwtdHJhbnNmZXIudHMiXSwibmFtZXMiOltdLCJtYXBwaW5ncyI6Ijs7Ozs7O0FBQUEsa0RBQXVCO0FBRXZCLDRDQUdzQjtBQUN0Qix3Q0FJb0I7QUFDcEIsc0NBS3FCO0FBS3JCLDJDQUFxRTtBQUNyRSxxQ0FHa0I7QUFDbEIscURBQWlEO0FBRWpELDBEQUEwRDtBQUMxRCxNQUFNLGlCQUFpQixHQUFHLElBQUksZUFBRSxDQUFDLENBQUMsQ0FBQyxDQUFDO0FBRXBDLE1BQU0sc0JBQXNCLEdBQUcsY0FBTyxDQUFDLCtCQUFtQixDQUFDLENBQUM7QUFDNUQsTUFBTSxlQUFlLEdBQUcsSUFBSSxlQUFFLENBQUMsQ0FBQyxDQUFDLENBQUM7QUFDbEMsTUFBTSwyQkFBMkIsR0FBRyxDQUFDLENBQUM7QUFDdEMsTUFBTSxpQ0FBaUMsR0FBRyxFQUFFLENBQUM7QUFFN0M7O0dBRUc7QUFDSCxNQUFhLDJCQUE0QixTQUFRLDhCQUEyQztJQUUxRixZQUNFLFFBQW1DO1FBRW5DLE1BQU0sS0FBSyxHQUFHLDJCQUFpQixDQUFDLFFBQVEsQ0FBQyxRQUFRLENBQUMsQ0FBQztRQUVuRCxxREFBcUQ7UUFDckQsTUFBTSxjQUFjLEdBQUcseUJBQWUsQ0FBQyxRQUFRLENBQUMsV0FBVyxFQUFFLDRCQUFnQixDQUFDLENBQUM7UUFFL0UsMENBQTBDO1FBQzFDLE1BQU0sb0JBQW9CLEdBQUcsa0NBQXdCLENBQUMsUUFBUSxDQUFDLHNCQUFzQixDQUFDLENBQUM7UUFFdkYsS0FBSyxDQUFDO1lBQ0osZ0JBQWdCLEVBQUUsUUFBUSxDQUFDLGdCQUFnQjtZQUMzQyxrQkFBa0IsRUFBRSxRQUFRLENBQUMsa0JBQWtCO1lBQy9DLGlCQUFpQixFQUFFLFFBQVEsQ0FBQyxpQkFBaUI7WUFDN0MsU0FBUyxFQUFFLHNCQUFlLENBQUMsUUFBUSxDQUFDLG1CQUFtQixFQUFFLFFBQVEsQ0FBQyxJQUFJLENBQUM7WUFDdkUsY0FBYztZQUNkLEtBQUs7WUFDTCxvQkFBb0I7U0FDckIsQ0FBQyxDQUFDO0lBQ0wsQ0FBQztJQUVTLEtBQUssQ0FBQyxhQUFhO1FBQzNCLE1BQU0sa0JBQWtCLEdBQUcsY0FBTyxDQUFDLElBQUksQ0FBQyxPQUFPLENBQUMsZ0JBQWdCLENBQUMsQ0FBQztRQUNsRSxNQUFNLG9CQUFvQixHQUFHLGNBQU8sQ0FBQyxJQUFJLENBQUMsT0FBTyxDQUFDLGtCQUFrQixDQUFDLENBQUM7UUFDdEUsTUFBTSxtQkFBbUIsR0FBRyxjQUFPLENBQUMsSUFBSSxDQUFDLE9BQU8sQ0FBQyxpQkFBaUIsQ0FBQyxDQUFDO1FBQ3BFLE1BQU0sV0FBVyxHQUFHLGNBQU8sQ0FBQyxJQUFJLENBQUMsT0FBTyxDQUFDLFNBQVMsQ0FBQyxDQUFDO1FBQ3BELE1BQU0sZ0JBQWdCLEdBQUcsY0FBTyxDQUFDLElBQUksQ0FBQyxPQUFPLENBQUMsY0FBYyxDQUFDLENBQUM7UUFDOUQsTUFBTSxPQUFPLEdBQUcsY0FBTyxDQUFDLElBQUksQ0FBQyxPQUFPLENBQUMsS0FBSyxDQUFDLENBQUM7UUFDNUMsTUFBTSxzQkFBc0IsR0FBRyxjQUFPLENBQUMsSUFBSSxDQUFDLE9BQU8sQ0FBQyxvQkFBb0IsQ0FBQyxDQUFDO1FBRTFFLElBQUksa0JBQWtCLENBQUMsU0FBUyxFQUFFLEdBQUcsa0RBQXNDLENBQUMsVUFBVSxFQUFFO1lBQ3RGLE1BQU0sSUFBSSxLQUFLLENBQUMseURBQXlELENBQUMsQ0FBQztTQUM1RTtRQUNELElBQ0Usb0JBQW9CLENBQUMsU0FBUyxFQUFFLEdBQUcsa0RBQXNDLENBQUMsVUFBVSxFQUNwRjtZQUNBLE1BQU0sSUFBSSxLQUFLLENBQUMsMkRBQTJELENBQUMsQ0FBQztTQUM5RTtRQUNELElBQ0UsbUJBQW1CLENBQUMsU0FBUyxFQUFFLEdBQUcsa0RBQXNDLENBQUMsaUJBQWlCLEVBQzFGO1lBQ0EsTUFBTSxJQUFJLEtBQUssQ0FBQywwREFBMEQsQ0FBQyxDQUFDO1NBQzdFO1FBQ0QsSUFBSSxXQUFXLENBQUMsU0FBUyxFQUFFLEdBQUcsa0RBQXNDLENBQUMsU0FBUyxFQUFFO1lBQzlFLE1BQU0sSUFBSSxLQUFLLENBQUMsa0RBQWtELENBQUMsQ0FBQztTQUNyRTtRQUNELElBQUksZ0JBQWdCLENBQUMsU0FBUyxFQUFFLEdBQUcsa0RBQXNDLENBQUMsY0FBYyxFQUFFO1lBQ3hGLE1BQU0sSUFBSSxLQUFLLENBQUMsdURBQXVELENBQUMsQ0FBQztTQUMxRTtRQUNELElBQUksT0FBTyxDQUFDLFNBQVMsRUFBRSxHQUFHLGtEQUFzQyxDQUFDLEtBQUssRUFBRTtZQUN0RSxNQUFNLElBQUksS0FBSyxDQUFDLDhDQUE4QyxDQUFDLENBQUM7U0FDakU7UUFDRCxJQUNFLHNCQUFzQixDQUFDLFNBQVMsRUFBRTtZQUNsQyxrREFBc0MsQ0FBQyxvQkFBb0IsRUFDM0Q7WUFDQSxNQUFNLElBQUksS0FBSyxDQUFDLDZEQUE2RCxDQUFDLENBQUM7U0FDaEY7UUFFRCxxREFBcUQ7UUFDckQsb0RBQW9EO1FBQ3BELE1BQU0sUUFBUSxHQUFHLE1BQU0saUNBQXdCLENBQUMsc0JBQXNCLEVBQUUsZUFBZSxDQUFDLENBQUM7UUFFekYsTUFBTSxhQUFhLEdBQUcsTUFBTSx3QkFBZSxDQUN6QyxNQUFNLHdCQUFlLENBQ25CLFFBQVEsRUFDUixtQkFBbUIsQ0FDcEIsRUFDRCxXQUFXLENBQ1osQ0FBQztRQUNGLDZEQUE2RDtRQUM3RCxNQUFNLGFBQWEsR0FBRyxJQUFJLGVBQUUsQ0FBQyxrQkFBa0IsQ0FBQyxRQUFRLEVBQUUsQ0FBQzthQUN4RCxNQUFNLENBQUMsa0RBQXNDLENBQUMsVUFBVSxDQUFDLENBQUMsSUFBSSxDQUFDLG9CQUFvQixDQUFDO2FBQ3BGLE1BQU0sQ0FBQyxrREFBc0MsQ0FBQyxVQUFVLENBQUMsQ0FBQyxJQUFJLENBQUMsa0JBQWtCLENBQUM7YUFDbEYsTUFBTSxDQUFDLGtEQUFzQyxDQUFDLEtBQUssQ0FBQyxDQUFDLElBQUksQ0FBQyxPQUFPLENBQUMsQ0FBQztRQUN0RSxNQUFNLGFBQWEsR0FBRyxJQUFJLGVBQUUsQ0FBQywyQkFBMkIsQ0FBQzthQUN0RCxNQUFNLENBQUMsa0RBQXNDLENBQUMsY0FBYyxDQUFDLENBQUMsSUFBSSxDQUFDLGdCQUFnQixDQUFDO2FBQ3BGLE1BQU0sQ0FBQyxrREFBc0MsQ0FBQyxjQUFjLENBQUMsQ0FBQyxJQUFJLENBQUMsaUJBQWlCLENBQUM7YUFDckYsTUFBTSxDQUFDLGtEQUFzQyxDQUFDLG9CQUFvQixDQUFDLENBQUMsSUFBSSxDQUN2RSxzQkFBc0IsQ0FDdkI7YUFDQSxNQUFNLENBQUMsaUNBQWlDLENBQUMsQ0FBQztRQUU3QyxPQUFPLHdCQUFlLENBQ3BCLE1BQU0sd0JBQWUsQ0FDbkIsYUFBYSxFQUNiLGFBQWEsQ0FDZCxFQUNELGFBQWEsQ0FDZCxDQUFDO0lBQ0osQ0FBQztJQUVELFdBQVc7UUFDVCxPQUFPLElBQUksQ0FBQyxPQUFPLENBQUM7SUFDdEIsQ0FBQztDQUNGO0FBbEdELGtFQWtHQyJ9

package.json

 {
   "name": "@dydxprotocol/starkex-lib",
-  "version": "0.10.1",
+  "version": "0.10.2",
   "description": "Cryptographic functions for use with StarkEx",
@@ -5,0 +5,0 @@ "main": "build/src/index.js",

src/signable/conditional-transfer.ts

@@ -30,6 +30,6 @@ import BN from 'bn.js';
 // Note: Fees are not supported for conditional transfers.
-const FEE_POSITION_ID_BN = new BN(0);
 const MAX_AMOUNT_FEE_BN = new BN(0);
 
 const COLLATERAL_ASSET_ID_BN = hexToBn(COLLATERAL_ASSET_ID);
+const FEE_ASSET_ID_BN = new BN(0);
 const CONDITIONAL_TRANSFER_PREFIX = 5;
@@ -103,5 +103,5 @@ const CONDITIONAL_TRANSFER_PADDING_BITS = 81;
 
-    // The transfer asset and fee asset are always the collateral asset.
+    // The transfer asset is always the collateral asset.
     // Fees are not supported for conditional transfers.
-    const assetIds = await getCacheablePedersenHash(COLLATERAL_ASSET_ID_BN, COLLATERAL_ASSET_ID_BN);
+    const assetIds = await getCacheablePedersenHash(COLLATERAL_ASSET_ID_BN, FEE_ASSET_ID_BN);
 
@@ -115,5 +115,6 @@ const transferPart1 = await getPedersenHash(
     );
-    const transferPart2 = new BN(senderPositionIdBn)
+    // Note: Use toString() to avoid mutating senderPositionIdBn.
+    const transferPart2 = new BN(senderPositionIdBn.toString())
       .iushln(CONDITIONAL_TRANSFER_FIELD_BIT_LENGTHS.positionId).iadd(receiverPositionIdBn)
-      .iushln(CONDITIONAL_TRANSFER_FIELD_BIT_LENGTHS.positionId).iadd(FEE_POSITION_ID_BN)
+      .iushln(CONDITIONAL_TRANSFER_FIELD_BIT_LENGTHS.positionId).iadd(senderPositionIdBn)
       .iushln(CONDITIONAL_TRANSFER_FIELD_BIT_LENGTHS.nonce).iadd(nonceBn);
@@ -120,0 +121,0 @@ const transferPart3 = new BN(CONDITIONAL_TRANSFER_PREFIX)

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

530764

increased by0.03%

Lines of code

9722

increased by0.02%

No dependency changes