@ebay/ebayui-core - npm Package Compare versions

Comparing version 2.0.3 to 2.0.4-canary.1ad023e0

dist/components/ebay-textbox/index.js

@@ -21,2 +21,4 @@ 'use strict';var markoWidgets = require('marko-widgets');
     var htmlAttributes = processHtmlAttributes(input);
+    var textboxTag = Boolean(input.multiline) ? 'textarea' : 'input';
+    var textareaValue = '';
     if (displayIcon && iconPostfix) {
@@ -28,2 +30,6 @@ rootClasses.push('textbox--icon-end');
     }
+    if (textboxTag === 'textarea' && htmlAttributes.value) {
+        textareaValue = htmlAttributes.value;
+        htmlAttributes.value = null;
+    }
 
@@ -42,6 +48,7 @@ return {
         tag: input.fluid ? 'div' : 'span',
-        textboxTag: Boolean(input.multiline) ? 'textarea' : 'input',
+        textboxTag: textboxTag,
         invalid: String(Boolean(input.invalid)),
         floatingLabel: input.floatingLabel,
-        labelClasses: labelClasses };
+        labelClasses: labelClasses,
+        textareaValue: textareaValue };
 
@@ -55,7 +62,11 @@ }
 function init() {
-    if (this.state.floatingLabel) {
-        this.floatingLabel = new FloatingLabel(this.el);
+    if (this.state.floatingLabel && !this.floatingLabel) {
+        window.addEventListener('load', initFloatingLabel.bind(this));
     }
 }
 
+function initFloatingLabel() {
+    this.floatingLabel = new FloatingLabel(this.el);
+}
+
 function handleEvent(originalEvent, eventName) {
@@ -62,0 +73,0 @@ emitAndFire(this, 'textbox-' + eventName, { originalEvent: originalEvent, value: originalEvent.target.value });

package.json

 {
   "name": "@ebay/ebayui-core",
-  "version": "2.0.3",
+  "version": "2.0.4-canary.1ad023e0",
   "description": "Collection of core eBay components; considered to be the building blocks for all composite structures, pages & apps.",
@@ -62,4 +62,4 @@ "scripts": {
     "@ebay/skin": "^7.0.1",
-    "@lasso/marko-taglib": "^1.0.9",
-    "async": "^2.6.0",
+    "@lasso/marko-taglib": "^1.0.15",
+    "async": "^2.6.2",
     "babel-cli": "^6.26.0",
@@ -71,8 +71,8 @@ "babel-plugin-transform-object-assign": "^6.22.0",
     "cheerio": "^1.0.0-rc.2",
-    "coveralls": "^3.0.1",
-    "eslint": "^5.13.0",
+    "coveralls": "^3.0.3",
+    "eslint": "^5.14.1",
     "eslint-config-ebay": "^1.0.0",
-    "eslint-plugin-compat": "^2.6.3",
+    "eslint-plugin-compat": "^2.7.0",
     "eslint-plugin-import": "^2.16.0",
-    "eslint-plugin-mocha": "^5.0.0",
+    "eslint-plugin-mocha": "^5.3.0",
     "express": "^4.16.2",
@@ -97,7 +97,7 @@ "gh-highlight": "^0.1.3",
     "mocha": "^5.1.1",
-    "nyc": "^13.1.0",
+    "nyc": "^13.3.0",
     "opn-cli": "^4.0.0",
     "pre-push": "^0.1.1",
     "rimraf": "^2.6.2",
-    "sinon": "^7.2.3",
+    "sinon": "^7.2.4",
     "stylelint": "^9.10.1",
@@ -104,0 +104,0 @@ "supertest": "^3.4.2",

New alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

931548

increased by0.92%

Number of package files

824

increased by0.12%

Lines of code

6549

increased by0.15%

Worsened metrics

Number of low quality alerts

2

increased by100%

No dependency changes