@eclipse-che/che-theia-devworkspace-handler - npm Package Compare versions

Comparing version 0.0.1-1642005330 to 0.0.1-1642585378

lib/devfile/devworkspace-updater.js

@@ -67,3 +67,3 @@ "use strict";
         if (extensionsForDevContainer) {
-            this.devContainerComponentUpdater.insert(devfileContext, extensionsForDevContainer);
+            await this.devContainerComponentUpdater.insert(devfileContext, extensionsForDevContainer);
         }
@@ -70,0 +70,0 @@ // and add them

lib/devfile/sidecar-components-creator.js

@@ -31,3 +31,4 @@ "use strict";
         return extensionsWithSidecars.map(entry => {
-            const sidecarName = entry.sidecarName || `sidecar-${entry.id.replace(/[^\w\s]/gi, '-')}`;
+            // ensure it's max 63 characters
+            const sidecarName = (entry.sidecarName || `sidecar-${entry.id.replace(/[^\w\s]/gi, '-')}`).substring(0, 63);
             // eslint-disable-next-line @typescript-eslint/no-explicit-any
@@ -34,0 +35,0 @@ const attributes = {

package.json

 {
   "name": "@eclipse-che/che-theia-devworkspace-handler",
-  "version": "0.0.1-1642005330",
+  "version": "0.0.1-1642585378",
   "private": false,
@@ -5,0 +5,0 @@ "description": "Handle management of che-theia-plugins and devWorkspace templates",

src/devfile/devworkspace-updater.ts

@@ -83,3 +83,3 @@ /**********************************************************************
     if (extensionsForDevContainer) {
-      this.devContainerComponentUpdater.insert(devfileContext, extensionsForDevContainer);
+      await this.devContainerComponentUpdater.insert(devfileContext, extensionsForDevContainer);
     }
@@ -86,0 +86,0 @@

src/devfile/sidecar-components-creator.ts

@@ -30,3 +30,5 @@ /**********************************************************************
     return extensionsWithSidecars.map(entry => {
-      const sidecarName = entry.sidecarName || `sidecar-${entry.id.replace(/[^\w\s]/gi, '-')}`;
+      // ensure it's max 63 characters
+      const sidecarName = (entry.sidecarName || `sidecar-${entry.id.replace(/[^\w\s]/gi, '-')}`).substring(0, 63);
+
       // eslint-disable-next-line @typescript-eslint/no-explicit-any
@@ -33,0 +35,0 @@ const attributes: { [key: string]: any } = {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Unidentified License

License

(Experimental) Something that seems like a license was found, but its contents could not be matched with a known license.

Found 2 instances in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Unidentified License

License

(Experimental) Something that seems like a license was found, but its contents could not be matched with a known license.

Found 2 instances in 1 package

Improved metrics

Total package byte prevSize

214284

increased by0.09%

Lines of code

3433

increased by0.06%

No dependency changes