@embroider/shared-internals - npm Package Compare versions

Comparing version 2.6.0 to 2.6.1-unstable.3d20631

package.json

 {
   "name": "@embroider/shared-internals",
-  "version": "2.6.0",
+  "version": "2.6.1-unstable.3d20631",
   "private": false,
@@ -27,2 +27,5 @@ "description": "Utilities shared among the other embroider packages",
   ],
+  "scripts": {
+    "test": "jest"
+  },
   "dependencies": {
@@ -42,2 +45,3 @@ "babel-import-util": "^2.0.0",
     "broccoli-node-api": "^1.7.0",
+    "@embroider/test-support": "workspace:*",
     "@types/babel__core": "^7.1.14",
@@ -54,11 +58,7 @@ "@types/babel__traverse": "^7.18.5",
     "tmp": "^0.1.0",
-    "typescript": "^5.1.6",
-    "@embroider/test-support": "0.36.0"
+    "typescript": "^5.1.6"
   },
   "engines": {
     "node": "12.* || 14.* || >= 16"
-  },
-  "scripts": {
-    "test": "jest"
   }
-}
+}

src/ember-standard-modules.js

@@ -51,2 +51,4 @@ "use strict";
 exports.emberVirtualPackages.add('@glimmer/manager');
+// ember-data pre 4.12 failed to declare this as a peer dependency of @ember-data/debug
+exports.emberVirtualPeerDeps.add('@ember-data/store');
 // These are the known names that people use to import template precomiplation
@@ -53,0 +55,0 @@ // macros from.

src/index.d.ts

 export { AppMeta, AddonMeta, PackageInfo } from './metadata';
-export { explicitRelative, extensionsPattern, unrelativize, cleanUrl, correspondingTemplate } from './paths';
+export { explicitRelative, extensionsPattern, unrelativize, cleanUrl, getUrlQueryParams, correspondingTemplate, } from './paths';
 export { getOrCreate } from './get-or-create';
@@ -4,0 +4,0 @@ export { default as Package, V2AddonPackage as AddonPackage, V2AppPackage as AppPackage, V2Package } from './package';

src/index.js

@@ -20,3 +20,3 @@ "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.locateEmbroiderWorkingDir = exports.cacheBustingPluginVersion = exports.cacheBustingPluginPath = exports.cacheBustingPlugin = exports.templateColocationPluginPath = exports.templateColocationPlugin = exports.hbsToJS = exports.tmpdir = exports.packageName = exports.babelFilter = exports.RewrittenPackageCache = exports.PackageCache = exports.Package = exports.getOrCreate = exports.correspondingTemplate = exports.cleanUrl = exports.unrelativize = exports.extensionsPattern = exports.explicitRelative = void 0;
+exports.locateEmbroiderWorkingDir = exports.cacheBustingPluginVersion = exports.cacheBustingPluginPath = exports.cacheBustingPlugin = exports.templateColocationPluginPath = exports.templateColocationPlugin = exports.hbsToJS = exports.tmpdir = exports.packageName = exports.babelFilter = exports.RewrittenPackageCache = exports.PackageCache = exports.Package = exports.getOrCreate = exports.correspondingTemplate = exports.getUrlQueryParams = exports.cleanUrl = exports.unrelativize = exports.extensionsPattern = exports.explicitRelative = void 0;
 var paths_1 = require("./paths");
@@ -27,2 +27,3 @@ Object.defineProperty(exports, "explicitRelative", { enumerable: true, get: function () { return paths_1.explicitRelative; } });
 Object.defineProperty(exports, "cleanUrl", { enumerable: true, get: function () { return paths_1.cleanUrl; } });
+Object.defineProperty(exports, "getUrlQueryParams", { enumerable: true, get: function () { return paths_1.getUrlQueryParams; } });
 Object.defineProperty(exports, "correspondingTemplate", { enumerable: true, get: function () { return paths_1.correspondingTemplate; } });
@@ -29,0 +30,0 @@ var get_or_create_1 = require("./get-or-create");

src/package-cache.js

@@ -66,3 +66,3 @@ "use strict";
     ownerOfFile(filename) {
-        let segments = filename.split(path_1.sep);
+        let segments = filename.replace(/\\/g, '/').split(path_1.posix.sep);
         // first we look through our cached packages for any that are rooted right
@@ -77,7 +77,7 @@ // at or above the file.
             let usedSegments = segments.slice(0, length);
-            let candidate = usedSegments.join(path_1.sep);
+            let candidate = usedSegments.join(path_1.posix.sep);
             if (this.rootCache.has(candidate)) {
                 return this.rootCache.get(candidate);
             }
-            if (getCachedExists([...usedSegments, 'package.json'].join(path_1.sep))) {
+            if (getCachedExists([...usedSegments, 'package.json'].join(path_1.posix.sep))) {
                 return this.get(candidate);
@@ -84,0 +84,0 @@ }

src/paths.d.ts

@@ -5,3 +5,4 @@ import type Package from './package';
 export declare function unrelativize(pkg: Package, specifier: string, fromFile: string): string;
-export declare function cleanUrl(url: string): string;
+export declare function cleanUrl(url: string, includeHashSign?: boolean): string;
+export declare function getUrlQueryParams(url: string, includeHashSign?: boolean): string;
 export declare function correspondingTemplate(filename: string): string;

src/paths.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.correspondingTemplate = exports.cleanUrl = exports.unrelativize = exports.extensionsPattern = exports.explicitRelative = void 0;
+exports.correspondingTemplate = exports.getUrlQueryParams = exports.cleanUrl = exports.unrelativize = exports.extensionsPattern = exports.explicitRelative = void 0;
 const path_1 = require("path");
@@ -46,8 +46,22 @@ // by "explicit", I mean that we want "./local/thing" instead of "local/thing"
 const postfixRE = /[?#].*$/s;
+// this pattern includes URL query params (ex: ?direct)
+// but excludes specifiers starting with # (ex: #embroider_compats/components/fancy)
+// so when using this pattern, #embroider_compat/fancy would be consider a pathname
+// without any params.
+const postfixREQueryParams = /[?].*$/s;
 // this is the same implementation Vite uses internally to keep its
 // cache-busting query params from leaking where they shouldn't.
-function cleanUrl(url) {
-    return url.replace(postfixRE, '');
+// includeHashSign true means #my-specifier is considered part of the pathname
+function cleanUrl(url, includeHashSign = false) {
+    const regexp = includeHashSign ? postfixREQueryParams : postfixRE;
+    return url.replace(regexp, '');
 }
 exports.cleanUrl = cleanUrl;
+// includeHashSign true means #my-specifier is considered part of the pathname
+function getUrlQueryParams(url, includeHashSign = false) {
+    var _a, _b;
+    const regexp = includeHashSign ? postfixREQueryParams : postfixRE;
+    return (_b = (_a = url.match(regexp)) === null || _a === void 0 ? void 0 : _a[0]) !== null && _b !== void 0 ? _b : '';
+}
+exports.getUrlQueryParams = getUrlQueryParams;
 // given a filename, returns it with the hbs extension
@@ -54,0 +68,0 @@ // for instance, passing filename.js returns filename.hbs

New alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

156219

increased by1.2%

Lines of code

1574

increased by1.16%

Worsened metrics

Number of package files

58

decreased by-1.69%

Number of low quality alerts

2

increased by100%

No dependency changes