@empiricalrun/reporter - npm Package Compare versions

Comparing version 0.23.0 to 0.23.1

CHANGELOG.md

 # @empiricalrun/reporter
 
+## 0.23.1
+
+### Patch Changes
+
+- 9a81634: fix: updated implementation for fetching commit SHA
+- f2c3344: fix: hitting maxFailures is not an error scenario
+
 ## 0.23.0
@@ -4,0 +11,0 @@

dist/sources/base.d.ts

@@ -25,3 +25,3 @@ export type Results = {
     reportExists(): Promise<boolean>;
-    hasRunFailed(): boolean;
+    hasRunFailedWithError(): boolean;
     resultsSummary(): Results;
@@ -28,0 +28,0 @@ failedTests(): FailedTestWithLink[];

dist/sources/playwright.d.ts

@@ -18,3 +18,3 @@ import { JSONReport as PlaywrightJSONReport } from "@playwright/test/reporter";
     getTestIdForTestName(testName: string): string;
-    hasRunFailed(): boolean;
+    hasRunFailedWithError(): boolean;
     failedTests(): FailedTestWithLink[];
@@ -21,0 +21,0 @@ reportLink(filter?: PlaywrightReportFilter): string;

dist/sources/playwright.js

@@ -75,5 +75,16 @@ "use strict";
     }
-    hasRunFailed() {
-        const results = (0, utils_1.parseJsonReport)(this.srcFile);
-        return results?.errors?.length > 0;
+    hasRunFailedWithError() {
+        try {
+            const results = (0, utils_1.parseJsonReport)(this.srcFile);
+            // This can be non-zero if the run hits maxFailure config. We don't consider
+            // that as an error scenario
+            const totalTestsExecuted = results.stats.expected + results.stats.unexpected + results.stats.flaky;
+            const noTestsWereExecuted = totalTestsExecuted === 0;
+            // Top level errors include: hitting maxFailures, no tests were found for filter
+            const hasTopLevelError = results?.errors?.length > 0;
+            return hasTopLevelError && noTestsWereExecuted;
+        }
+        catch (err) {
+            return true;
+        }
     }
@@ -80,0 +91,0 @@ failedTests() {

dist/workflow/test-run.js

@@ -48,3 +48,3 @@ "use strict";
                 const reportNotGenerated = !(await reportSource.reportExists());
-                if (reportNotGenerated || reportSource.hasRunFailed()) {
+                if (reportNotGenerated || reportSource.hasRunFailedWithError()) {
                     await Promise.all(sinks.map((s) => s.sendMessageForError()));
@@ -51,0 +51,0 @@ }

package.json

 {
   "name": "@empiricalrun/reporter",
-  "version": "0.23.0",
+  "version": "0.23.1",
   "publishConfig": {
@@ -5,0 +5,0 @@ "registry": "https://registry.npmjs.org/",

No alert changes

Improved metrics

Total package byte prevSize

51896

increased by1.49%

Lines of code

928

increased by1.2%

No dependency changes