@financial-times/o-ads - npm Package Compare versions

Comparing version 12.1.0 to 12.2.0

dist/js/data-providers/krux.js

@@ -253,4 +253,2 @@ "use strict";
   if ((0, _config.default)('krux') && (0, _config.default)('krux').consentState) {
-    _utils.default.broadcast('kruxConsentOptinOK');
-
     const kuid = localStorage && localStorage.getItem('kxkuid');
@@ -262,20 +260,6 @@
         timeout: 2000
-      }).then(data => {
-        if (data.ok) {
-          _utils.default.broadcast('kruxKuidAck');
-
-          return;
-        }
-
-        throw new Error('error confirming kuid consent by krux');
-      }).catch(() => {
-        _utils.default.broadcast('kruxKuidError');
-
-        Promise.resolve(_utils.default.log.warn('Fetch request failed to GET krux consent api'));
-      });
+      }).catch(() => Promise.resolve(_utils.default.log.warn('Fetch request failed to GET krux consent api')));
     } else {
       window.setTimeout(Krux.prototype.consents.bind(Krux), 1000);
     }
-  } else {
-    _utils.default.broadcast('kruxConsentOptinFailed');
   }
@@ -282,0 +266,0 @@ };

dist/js/data-providers/moat.js

@@ -34,2 +34,5 @@ "use strict";
       clearInterval(intervalId);
+
+      _utils.default.broadcast('moatTimeout');
+
       reject(new Error('Timeout while fetching moat invalid traffic script'));
@@ -36,0 +39,0 @@ }, 1000);

dist/js/version.js

 "use strict";
 
 // generated by genversion
-module.exports = '12.1.0';
+module.exports = '12.2.0';

origami.json

 {
-	"description": "Advertising",
+	"description": "Enables advertising from Google's DFP Ad server, and provides customised demographic, behavioural (via Krux), and contextual (via Admantx) targeting.",
+	"keywords": [ "adverts" ],
 	"origamiType": "module",
@@ -4,0 +5,0 @@ "origamiCategory": "components",

package.json

@@ -26,3 +26,3 @@ {
 	"name": "@financial-times/o-ads",
-	"version": "12.1.0",
+	"version": "12.2.0",
 	"dependencies": {
@@ -29,0 +29,0 @@ "ftdomdelegate": ">=2.2.0 <4.0.0",

README.md

 # oAds [![CircleCI Status](https://circleci.com/gh/Financial-Times/o-ads.svg?style=shield&circle-token=36a37c6ca27a08408c2575c7834f5f6f5c5c9d21)](https://circleci.com/gh/Financial-Times/o-ads/tree/master)
 
-This is an Origami module that enables display advertising from [Googles DFP Ad server](http://www.google.com/dfp), and provides customised demographic, behavioural (via [Krux](http://www.krux.com/)), and contextual (via [Admantx](http://admantx.com/)) targeting.
+This is an Origami module that enables advertising from [Google's DFP Ad server](http://www.google.com/dfp), and provides customised demographic, behavioural (via [Krux](http://www.krux.com/)), and contextual (via [Admantx](http://admantx.com/)) targeting.
 
@@ -68,3 +68,3 @@ ## Requirements
 
-2. **`o-Ads` exposes a new `setupMetrics` method that simplifies obtaining performance metrics.** `setupMetrics` accepts two parameters:
+2. **`o-ads` exposes a new `setupMetrics` method that simplifies obtaining performance metrics.** `setupMetrics` accepts two parameters:
  - An array of objects containing the configuration of the different metrics that need to be tracked.
@@ -78,16 +78,19 @@ - A callback function to be called whenever any of the trigger events of any of those configuration objects is dispatched.
 :--:|:--:
-startInitialisation|initialising
-moatIVTcomplete|IVTComplete
-apiRequestsComplete|adsAPIComplete
-adServerLoadSuccess|serverScriptLoaded
-ready|slotReady
-render|slotCanRender 
-gptDisplay|slotGoRender
-rendered|slotRenderStart
-complete|slotExpand
-adIframeLoaded|slotRenderEnded
+startInitialisation | initialising
+moatIVTcomplete | IVTComplete
+apiRequestsComplete |  adsAPIComplete
+adServerLoadSuccess |  serverScriptLoaded
+ready | slotReady
+render |slotCanRender 
+gptDisplay |slotGoRender
+rendered | slotRenderStart
+complete | slotExpand
+adIframeLoaded | slotRenderEnded
 
-A guide to the new names can also be found in this two diagrams:
+A guide can to the new names can also be found in this two diagrams:
 
-- [event renaming 1](https://github.com/Financial-Times/o-ads/blob/master/docs/assets/v12_event_renaming_1.png)
-- [event renaming 2](https://github.com/Financial-Times/o-ads/blob/master/docs/assets/v12_event_renaming_2.png)
+#### Event renaming pt. 1
+![event renaming 1](https://github.com/Financial-Times/o-ads/blob/master/docs/assets/v12_event_renaming_1.png)
+
+#### Event renaming pt. 2
+![event renaming 2](https://github.com/Financial-Times/o-ads/blob/master/docs/assets/v12_event_renaming_2.png)

No alert changes

Improved metrics

Number of lines in readme file

95

increased by3.26%

Worsened metrics

Total package byte prevSize

115729

decreased by-0.09%

Lines of code

3082

decreased by-0.32%

No dependency changes