@financial-times/o-ads - npm Package Compare versions

Comparing version 12.8.5 to 12.9.1

dist/.eslintrc.json

 {
+  "parserOptions": {
+    "ecmaVersion": 6
+  },
   "rules": {
     "valid-jsdoc": 0,
-    "no-prototype-builtins": 0,
-    "parserOptions": {
-      "ecmaFeatures": {
-        "experimentalObjectRestSpread": true
-      }
-    }
+    "no-prototype-builtins": 0
   }
 }

dist/js/slot.js

@@ -426,6 +426,9 @@ "use strict";
     creativeId: gpt.creativeId || '',
-    isEmpty: typeof gpt.isEmpty === 'undefined' ? '' : "".concat(gpt.isEmpty),
     slot: this
   };
 
+  if (typeof gpt.isEmpty === 'boolean') {
+    details.isEmpty = gpt.isEmpty;
+  }
+
   if (_utils.default.isPlainObject(data)) {
@@ -432,0 +435,0 @@ _utils.default.extend(details, data);

dist/js/utils/index.js

@@ -575,2 +575,3 @@ "use strict";
   setupMetrics: _metrics.setupMetrics,
+  clearPerfMarks: _metrics.clearPerfMarks,
   inSample,
@@ -577,0 +578,0 @@ perfMark: _events.perfMark,

dist/js/utils/metrics.js

@@ -6,2 +6,3 @@ "use strict";
 });
+exports.clearPerfMarks = clearPerfMarks;
 exports.setupMetrics = setupMetrics;
@@ -33,2 +34,24 @@
 }
+
+function clearPerfMarks(metricsDefinitions, groupsToClear) {
+  if (!performance || !performance.getEntriesByType) {
+    return;
+  }
+
+  var relevantGroups = metricsDefinitions.filter(group => groupsToClear.includes(group.spoorAction));
+  var relevantGroupsMarks = relevantGroups.map(group => group.marks); // Because relevantGroupsMarks is a 2D array ...
+
+  var eventsToClear = [].concat(...relevantGroupsMarks);
+  var perfMarks = performance.getEntriesByType('mark');
+  perfMarks.forEach((_ref) => {
+    var {
+      name
+    } = _ref;
+    eventsToClear.forEach(eventName => {
+      if (name.match("oAds.".concat(eventName))) {
+        performance.clearMarks(name);
+      }
+    });
+  });
+}
 /* istanbul ignore next */
@@ -101,5 +124,8 @@
       size: eventDetails.size && eventDetails.size.toString(),
-      creativeId: eventDetails.creativeId || 0,
-      isEmpty: "".concat(eventDetails.isEmpty) || ''
+      creativeId: eventDetails.creativeId || 0
     };
+
+    if (typeof eventDetails.isEmpty === 'boolean') {
+      eventPayload.creative.isEmpty = eventDetails.isEmpty;
+    }
   }
@@ -106,0 +132,0 @@

dist/js/version.js

 "use strict";
 
 // generated by genversion
-module.exports = '12.8.5';
+module.exports = '12.9.1';

package.json

 {
-  "browser": "browser.js",
-  "files": [
-    "svg/",
-    "dist/",
-    "browser.js",
-    "src/",
-    "!src/**/*.js",
-    "main.scss",
-    "img",
-    "*.json",
-    "scss",
-    "!bower.json",
-    "!.bower.json"
-  ],
-  "eslintIgnore": [
-    "browser.js",
-    "dist/"
-  ],
-  "keywords": [
-    "origami",
-    "component",
-    "ft"
-  ],
-  "name": "@financial-times/o-ads",
-  "version": "12.8.5",
-  "dependencies": {
-    "ftdomdelegate": ">=2.2.0 <4.0.0",
-    "@financial-times/o-viewport": ">=1.5.0 < 4",
-    "@financial-times/o-grid": "^4.0.0",
-    "@financial-times/o-visual-effects": "^2.0.0",
-    "@financial-times/o-colors": "^4.0.0"
-  },
-  "component": "o-ads",
-  "scripts": {
-    "demo-server": "obt demo --runServer --port=3002",
-    "nightwatch-bs": "node ./test/nightwatch/config/nightwatch-local.js -c ./test/nightwatch/config/nightwatch.conf.bs.js",
-    "test": "npm run test-unit",
-    "test-unit": "karma start karma.conf.js --single-run",
-    "test-cy:run": "cypress run -r spec --record false",
-    "test-cy:open": "cypress open",
-    "test-nw": "npm run test-nw:basic && npm run test-nw:extended",
-    "test-nw:local": "nightwatch -c ./test/nightwatch/config/nightwatch.conf.local.js",
-    "test-nw:basic": "npm run nightwatch-bs -- --group basic --env chrome,firefox,safari,edge,galaxy_s8",
-    "test-nw:extended": "npm run nightwatch-bs -- --group extended --env chrome",
-    "coverage": "export COVERAGE=true && karma start && unset COVERAGE",
-    "ci": "export COVERAGE=true && export CI=true && karma start && unset COVERAGE && unset CI",
-    "verify": "obt verify",
-    "lint": "eslint .",
-    "lint-complexity": "eslint . -c .eslintrc-complexity.js",
-    "release": "release-it",
-    "version": "genversion --semi src/js/version.js",
-    "obt": "obt",
-    "checksizes": "bundlesize",
-    "prepare": "npx snyk protect || npx snyk protect -d || true",
-    "commit": "commit-wizard"
-  },
-  "devDependencies": {
-    "@cypress/webpack-preprocessor": "^2.0.0",
-    "@financial-times/secret-squirrel": "^2.11.0",
-    "bower-resolve-webpack-plugin": "^1.0.5",
-    "browserstack-local": "^1.3.5",
-    "bundlesize": "^0.17.2",
-    "cypress": "^3.1.5",
-    "dotenv": "^8.0.0",
-    "eslint": "^5.16.0",
-    "fetch-mock": "^5.1.1",
-    "geckodriver": "^1.16.1",
-    "genversion": "^2.1.0",
-    "isomorphic-fetch": "^2.0.0",
-    "istanbul": "^0.4.2",
-    "istanbul-instrumenter-loader": "^3.0.1",
-    "karma": "^4.1.0",
-    "karma-chrome-launcher": "^0.2.2",
-    "karma-cli": "^0.1.1",
-    "karma-coverage": "^1.1.2",
-    "karma-coverage-istanbul-reporter": "^2.0.4",
-    "karma-qunit": "^0.1.8",
-    "karma-webpack": "^3.0.5",
-    "nightwatch": "[e-mail]:Financial-Times/nightwatch.git",
-    "origami-build-tools": "^8.0.0",
-    "pre-git": "^3.17.1",
-    "qunitjs": "^1.20.0",
-    "release-it": "^12.3.3",
-    "snyk": "^1.169.1",
-    "watchify": "^3.11.0",
-    "webpack": "^4.26.1"
-  },
-  "release": {
-    "analyzeCommits": "simple-commit-message"
-  },
-  "config": {
-    "pre-git": {
-      "commit-msg": "simple",
-      "pre-commit": [],
-      "pre-push": [],
-      "post-commit": [],
-      "post-checkout": [],
-      "post-merge": []
-    }
-  }
+	"browser": "browser.js",
+	"files": [
+		"svg/",
+		"dist/",
+		"browser.js",
+		"src/",
+		"!src/**/*.js",
+		"main.scss",
+		"img",
+		"*.json",
+		"scss",
+		"!bower.json",
+		"!.bower.json"
+	],
+	"eslintIgnore": [
+		"browser.js",
+		"dist/"
+	],
+	"keywords": [
+		"origami",
+		"component",
+		"ft"
+	],
+	"name": "@financial-times/o-ads",
+	"version": "12.9.1",
+	"dependencies": {
+		"ftdomdelegate": ">=2.2.0 <4.0.0",
+		"@financial-times/o-viewport": ">=1.5.0 < 4",
+		"@financial-times/o-grid": "^4.0.0",
+		"@financial-times/o-visual-effects": "^2.0.0",
+		"@financial-times/o-colors": "^4.0.0"
+	},
+	"component": "o-ads",
+	"scripts": {
+		"demo-server": "obt demo --runServer --port=3002",
+		"nightwatch-bs": "node ./test/nightwatch/config/nightwatch-local.js -c ./test/nightwatch/config/nightwatch.conf.bs.js",
+		"test": "npm run test-unit",
+		"test-unit": "karma start karma.conf.js --single-run && jest",
+		"test-cy:run": "cypress run -r spec --record false",
+		"test-cy:open": "cypress open",
+		"test-nw": "npm run test-nw:basic && npm run test-nw:extended",
+		"test-nw:local": "nightwatch -c ./test/nightwatch/config/nightwatch.conf.local.js",
+		"test-nw:basic": "npm run nightwatch-bs -- --group basic --env chrome,firefox,safari,edge,galaxy_s8",
+		"test-nw:extended": "npm run nightwatch-bs -- --group extended --env chrome",
+		"jest": "jest",
+		"coverage": "export COVERAGE=true && karma start && unset COVERAGE",
+		"ci": "export COVERAGE=true && export CI=true && karma start && unset COVERAGE && unset CI",
+		"verify": "obt verify",
+		"lint": "eslint .",
+		"lint-complexity": "eslint . -c .eslintrc-complexity.js",
+		"release": "release-it",
+		"version": "genversion --semi src/js/version.js",
+		"obt": "obt",
+		"checksizes": "bundlesize",
+		"prepare": "npx snyk protect || npx snyk protect -d || true"
+	},
+	"devDependencies": {
+		"@babel/core": "^7.4.5",
+		"@babel/preset-env": "^7.4.5",
+		"@cypress/webpack-preprocessor": "^2.0.0",
+		"@financial-times/secret-squirrel": "^2.12.4",
+		"babel-jest": "^24.8.0",
+		"bower-resolve-webpack-plugin": "^1.0.5",
+		"browserstack-local": "^1.3.5",
+		"bundlesize": "^0.18.0",
+		"cypress": "^3.4.0",
+		"dotenv": "^8.0.0",
+		"eslint": "^6.0.1",
+		"eslint-plugin-jest": "^22.7.1",
+		"fetch-mock": "^5.1.1",
+		"geckodriver": "^1.16.1",
+		"genversion": "^2.1.0",
+		"isomorphic-fetch": "^2.0.0",
+		"istanbul": "^0.4.2",
+		"istanbul-instrumenter-loader": "^3.0.1",
+		"jest": "^24.8.0",
+		"karma": "^4.1.0",
+		"karma-chrome-launcher": "^0.2.2",
+		"karma-cli": "^0.1.1",
+		"karma-coverage": "^1.1.2",
+		"karma-coverage-istanbul-reporter": "^2.0.4",
+		"karma-qunit": "^0.1.8",
+		"karma-webpack": "^3.0.5",
+		"nightwatch": "[e-mail]:Financial-Times/nightwatch.git",
+		"origami-build-tools": "^8.0.0",
+		"pre-git": "^3.17.1",
+		"qunitjs": "^1.20.0",
+		"release-it": "^12.3.3",
+		"snyk": "^1.169.1",
+		"watchify": "^3.11.0",
+		"webpack": "^4.36.0"
+	}
 }

src/.eslintrc.json

 {
+  "parserOptions": {
+    "ecmaVersion": 6
+  },
   "rules": {
     "valid-jsdoc": 0,
-    "no-prototype-builtins": 0,
-    "parserOptions": {
-      "ecmaFeatures": {
-        "experimentalObjectRestSpread": true
-      }
-    }
+    "no-prototype-builtins": 0
   }
 }

New alerts

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Fixed alerts

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Improved metrics

Number of downloads

84

increased by140%

Worsened metrics

Total package byte prevSize

118766

decreased by-86.19%

Dev dependency count

34

increased by17.24%

Number of package files

26

decreased by-3.7%

Lines of code

3149

decreased by-86.62%

No dependency changes