@financial-times/o-ads - npm Package Compare versions

Comparing version 13.3.0 to 13.4.0

dist/js/ad-servers/gpt.js

@@ -552,2 +552,7 @@ "use strict";
   }
+} //https://developers.google.com/doubleclick-gpt/common_implementation_mistakes#scenario-2:-checking-the-googletag-object-to-know-whether-gpt-is-ready
+
+
+function hasGPTLoaded() {
+  return window.googletag && window.googletag.apiReady;
 }
@@ -573,6 +578,7 @@
   clearPageTargetingForKey,
-  debug,
-  loadGPT
+  hasGPTLoaded,
+  loadGPT,
+  debug
 };
 exports.default = _default;
 module.exports = exports.default;

dist/js/slot.js

@@ -408,3 +408,8 @@ "use strict";
     this.destroySlot();
-    this.container.removeChild(this.outer);
+
+    if (this.outer.parentElement === this.container) {
+      this.container.removeChild(this.outer);
+    } else {
+      console.error('Error destroying ad slot. The parent node has already been removed.'); // eslint-disable-line no-console
+    }
   }
@@ -411,0 +416,0 @@

dist/js/version.js

 "use strict";
 
 // generated by genversion
-module.exports = '13.3.0';
+module.exports = '13.4.0';

package.json

@@ -28,3 +28,3 @@ {
 	"name": "@financial-times/o-ads",
-	"version": "13.3.0",
+	"version": "13.4.0",
 	"dependencies": {
@@ -31,0 +31,0 @@ "ftdomdelegate": ">=2.2.0 <4.0.0",

src/js/ad-servers/gpt.js

@@ -513,2 +513,6 @@ /*globals googletag: true */
 }
+//https://developers.google.com/doubleclick-gpt/common_implementation_mistakes#scenario-2:-checking-the-googletag-object-to-know-whether-gpt-is-ready
+function hasGPTLoaded () {
+	return window.googletag && window.googletag.apiReady;
+}
 
@@ -531,4 +535,5 @@ function debug() {
 	clearPageTargetingForKey,
-	debug,
-	loadGPT
+	hasGPTLoaded,
+	loadGPT,
+	debug
 };

src/js/slot.js

@@ -378,3 +378,7 @@ import utils from './utils';
 		this.destroySlot();
-		this.container.removeChild(this.outer);
+		if (this.outer.parentElement === this.container) {
+			this.container.removeChild(this.outer);
+		} else {
+			console.error('Error destroying ad slot. The parent node has already been removed.'); // eslint-disable-line no-console
+		}
 	}
@@ -381,0 +385,0 @@ return this;

src/js/version.js

 // generated by genversion
-module.exports = '13.3.0';
+module.exports = '13.4.0';

No alert changes

Improved metrics

Total package byte prevSize

203179

increased by0.44%

Lines of code

5762

increased by0.3%

No dependency changes