@financial-times/o-header - npm Package Compare versions

Comparing version 7.8.3 to 7.8.4

dist/js/drawer.js

@@ -85,3 +85,3 @@ "use strict";
 function addDrawerToggles(drawerEl) {
-  const controls = Array.from(document.body.querySelectorAll(`[aria-controls="${drawerEl.id}"]`));
+  const controls = Array.from(document.body.querySelectorAll("[aria-controls=\"".concat(drawerEl.id, "\"]")));
   let handleClose;
@@ -140,3 +140,3 @@ let openingControl;
   Array.from(submenus).forEach(submenu => {
-    const button = drawerEl.querySelector(`[aria-controls="${submenu.id}"]`);
+    const button = drawerEl.querySelector("[aria-controls=\"".concat(submenu.id, "\"]"));
     submenu.setAttribute('aria-hidden', 'true');
@@ -178,5 +178,10 @@ new _oToggle.default(button, {
   addSubmenuToggles(drawerEl);
-  addDrawerToggles(drawerEl);
-  drawerEl.removeAttribute('data-o-header-drawer--no-js');
-  drawerEl.setAttribute('data-o-header-drawer--js', 'true');
+  addDrawerToggles(drawerEl); // Wrap in a timeout to stop page load stall in Chrome v73 on Android
+  // toggleTabbing and the removal of the no-js attribute spikes the CPU
+  // and causes the main process to block for around 10 seconds.
+
+  setTimeout(() => {
+    drawerEl.removeAttribute('data-o-header-drawer--no-js');
+    drawerEl.setAttribute('data-o-header-drawer--js', 'true');
+  });
 }
@@ -183,0 +188,0 @@

dist/js/search.js

@@ -15,3 +15,3 @@ "use strict";
   const target = headerEl.querySelector('[data-o-header-search]');
-  const controls = target && headerEl.querySelectorAll(`[aria-controls="${target.id}"]`);
+  const controls = target && headerEl.querySelectorAll("[aria-controls=\"".concat(target.id, "\"]"));
 
@@ -18,0 +18,0 @@ if (controls === null || controls.length === 0) {

package.json

@@ -6,5 +6,6 @@ {
 		"dist/",
-		"index.js",
+		"browser.js",
 		"src/",
-		"main*",
+		"!src/**/*.js",
+		"main.scss",
 		"img",
@@ -26,3 +27,3 @@ "*.json",
 	"name": "@financial-times/o-header",
-	"version": "7.8.3",
+	"version": "7.8.4",
 	"dependencies": {
@@ -29,0 +30,0 @@ "@financial-times/o-colors": "^4.0.1",

README.md

@@ -26,3 +26,3 @@ # o-header [![CircleCI](https://circleci.com/gh/Financial-Times/o-header.png?style=shield&circle-token=41f2b7b7e669f2d4adb55ad97cf755d3ed4b93c3)](https://circleci.com/gh/Financial-Times/o-header) [![MIT licensed](https://img.shields.io/badge/license-MIT-blue.svg)](#licence)
 ```js
-const oHeader = require('o-header');
+import oHeader from 'o-header';
 
@@ -29,0 +29,0 @@ oHeader.init();

No alert changes

Worsened metrics

Total package byte prevSize

119585

decreased by-9.77%

Number of package files

45

decreased by-13.46%

Lines of code

562

decreased by-40.78%

No dependency changes