@finos/legend-application - npm Package Compare versions

Comparing version 15.1.21 to 15.1.22

lib/package.json

 {
     "name": "@finos/legend-application",
-    "version": "15.1.21",
+    "version": "15.1.22",
     "description": "Legend application core",
@@ -5,0 +5,0 @@ "keywords": [

lib/stores/NotificationService.d.ts

@@ -45,2 +45,3 @@ /**
     notifyError(content: Error | string, actions?: NotificationAction[]): void;
+    getErrorMessage(content: Error | string): string | undefined;
     notifyIllegalState(message: string, actions?: NotificationAction[], autoHideDuration?: number | null): void;
@@ -47,0 +48,0 @@ notifyUnsupportedFeature(featureName: string): void;

lib/stores/NotificationService.js

@@ -72,2 +72,8 @@ /**
     notifyError(content, actions) {
+        const message = this.getErrorMessage(content);
+        if (message) {
+            this.setNotification(new Notification(NOTIFCATION_SEVERITY.ERROR, message, actions ?? [], undefined));
+        }
+    }
+    getErrorMessage(content) {
         let message;
@@ -84,5 +90,3 @@ if (content instanceof ApplicationError) {
         }
-        if (message) {
-            this.setNotification(new Notification(NOTIFCATION_SEVERITY.ERROR, message, actions ?? [], undefined));
-        }
+        return message;
     }
@@ -89,0 +93,0 @@ notifyIllegalState(message, actions, autoHideDuration) {

package.json

 {
   "name": "@finos/legend-application",
-  "version": "15.1.21",
+  "version": "15.1.22",
   "description": "Legend application core",
@@ -48,4 +48,4 @@ "keywords": [
   "dependencies": {
-    "@finos/legend-art": "7.1.49",
-    "@finos/legend-shared": "10.0.50",
+    "@finos/legend-art": "7.1.50",
+    "@finos/legend-shared": "10.0.51",
     "@types/react": "18.3.3",
@@ -52,0 +52,0 @@ "@types/react-dom": "18.3.0",

src/stores/NotificationService.ts

@@ -132,11 +132,3 @@ /**
   notifyError(content: Error | string, actions?: NotificationAction[]): void {
-    let message: string | undefined;
-    if (content instanceof ApplicationError) {
-      message = content.detail;
-    } else if (content instanceof Error) {
-      message = content.message;
-    } else {
-      assertTrue(isString(content), `Can't display error`);
-      message = content;
-    }
+    const message = this.getErrorMessage(content);
     if (message) {
@@ -154,2 +146,15 @@ this.setNotification(
 
+  getErrorMessage(content: Error | string): string | undefined {
+    let message: string | undefined;
+    if (content instanceof ApplicationError) {
+      message = content.detail;
+    } else if (content instanceof Error) {
+      message = content.message;
+    } else {
+      assertTrue(isString(content), `Can't display error`);
+      message = content;
+    }
+    return message;
+  }
+
   notifyIllegalState(
@@ -156,0 +161,0 @@ message: string,

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

865495

increased by0.06%

Lines of code

14754

increased by0.06%

Published versions last year

67

increased by1.52%

Dependency changes

• + Added@finos/legend-art@7.1.50(transitive)

• + Added@finos/legend-shared@10.0.51(transitive)

• - Removed@finos/legend-art@7.1.49(transitive)

• - Removed@finos/legend-shared@10.0.50(transitive)

• Updated@finos/legend-art@7.1.50

• Updated@finos/legend-shared@10.0.51