@finos/legend-shared - npm Package Compare versions

Comparing version 6.1.0 to 6.1.1

lib/application/TestUtils.d.ts

@@ -34,17 +34,2 @@ /**
 /**
- * MobX makes some fields non-configurable or non-writable which would prevent spying/mocking/stubbing in your tests.
- * NOTE: Use with caution and only when needed - do not turn this off globally for all tests, otherwise you risk
- * false positives (passing tests with broken code).
- *
- * A small caveat is with the usage of `flow` with `makeObservable`, if we use the `flow(function* (args) { })` form,
- * the latter will treat these non-observable (stateless) fields (action, flow) as non-writable. So we have to call this
- * function at test environment setup (due to the fact that `flow` decorates the class property outside of `makeObservable`)
- * or change the function to use flow decorater form in `makeObservable`.
- *
- * See https://mobx.js.org/configuration.html#safedescriptors-boolean
- * See https://github.com/mobxjs/mobx/issues/2752
- */
-export declare const MOBX__enableSpyOrMock: () => void;
-export declare const MOBX__disableSpyOrMock: () => void;
-/**
  * Currently, `jest-extended` augments the matchers from @types/jest instead of expect (or @jest/expect)
@@ -51,0 +36,0 @@ * so we're stubbing this type for now.

lib/application/TestUtils.js

@@ -17,3 +17,2 @@ /**
 import { noop } from '../CommonUtils.js';
-import { configure as configureMobx } from 'mobx';
 /**
@@ -39,21 +38,2 @@ * This is a pass through worker, it will post message, but do not ever reply so `onmessage` and `onerror` are never called
 export const unitTest = (testName) => `[UNIT] ${testName}`;
-/**
- * MobX makes some fields non-configurable or non-writable which would prevent spying/mocking/stubbing in your tests.
- * NOTE: Use with caution and only when needed - do not turn this off globally for all tests, otherwise you risk
- * false positives (passing tests with broken code).
- *
- * A small caveat is with the usage of `flow` with `makeObservable`, if we use the `flow(function* (args) { })` form,
- * the latter will treat these non-observable (stateless) fields (action, flow) as non-writable. So we have to call this
- * function at test environment setup (due to the fact that `flow` decorates the class property outside of `makeObservable`)
- * or change the function to use flow decorater form in `makeObservable`.
- *
- * See https://mobx.js.org/configuration.html#safedescriptors-boolean
- * See https://github.com/mobxjs/mobx/issues/2752
- */
-export const MOBX__enableSpyOrMock = () => {
-    configureMobx({ safeDescriptors: false });
-};
-export const MOBX__disableSpyOrMock = () => {
-    configureMobx({ safeDescriptors: false });
-};
 //# sourceMappingURL=TestUtils.js.map

lib/error/ErrorUtils.d.ts

@@ -63,2 +63,4 @@ /**
  * See https://github.com/jsdom/jsdom/issues/2727
+ * See https://github.com/facebook/jest/issues/2549
+ *
  * Read more related discussions at:
@@ -65,0 +67,0 @@ * https://github.com/jsdom/jsdom/issues/1737

lib/error/ErrorUtils.js

@@ -106,2 +106,4 @@ /**
  * See https://github.com/jsdom/jsdom/issues/2727
+ * See https://github.com/facebook/jest/issues/2549
+ *
  * Read more related discussions at:
@@ -108,0 +110,0 @@ * https://github.com/jsdom/jsdom/issues/1737

lib/package.json

 {
     "name": "@finos/legend-shared",
-    "version": "6.1.0",
+    "version": "6.1.1",
     "description": "Legend Studio shared utilities and helpers",
@@ -65,3 +65,3 @@ "keywords": [
         "cross-env": "7.0.3",
-        "eslint": "8.23.0",
+        "eslint": "8.23.1",
         "jest": "29.0.3",
@@ -68,0 +68,0 @@ "lodash": "4.17.21",

package.json

 {
   "name": "@finos/legend-shared",
-  "version": "6.1.0",
+  "version": "6.1.1",
   "description": "Legend Studio shared utilities and helpers",
@@ -62,6 +62,6 @@ "keywords": [
   "devDependencies": {
-    "@finos/legend-dev-utils": "2.0.15",
+    "@finos/legend-dev-utils": "2.0.16",
     "@jest/globals": "29.0.3",
     "cross-env": "7.0.3",
-    "eslint": "8.23.0",
+    "eslint": "8.23.1",
     "jest": "29.0.3",
@@ -68,0 +68,0 @@ "lodash": "4.17.21",

src/application/TestUtils.ts

@@ -18,3 +18,2 @@ /**
 import { noop } from '../CommonUtils.js';
-import { configure as configureMobx } from 'mobx';
 
@@ -47,22 +46,2 @@ /**
 /**
- * MobX makes some fields non-configurable or non-writable which would prevent spying/mocking/stubbing in your tests.
- * NOTE: Use with caution and only when needed - do not turn this off globally for all tests, otherwise you risk
- * false positives (passing tests with broken code).
- *
- * A small caveat is with the usage of `flow` with `makeObservable`, if we use the `flow(function* (args) { })` form,
- * the latter will treat these non-observable (stateless) fields (action, flow) as non-writable. So we have to call this
- * function at test environment setup (due to the fact that `flow` decorates the class property outside of `makeObservable`)
- * or change the function to use flow decorater form in `makeObservable`.
- *
- * See https://mobx.js.org/configuration.html#safedescriptors-boolean
- * See https://github.com/mobxjs/mobx/issues/2752
- */
-export const MOBX__enableSpyOrMock = (): void => {
-  configureMobx({ safeDescriptors: false });
-};
-export const MOBX__disableSpyOrMock = (): void => {
-  configureMobx({ safeDescriptors: false });
-};
-
-/**
  * Currently, `jest-extended` augments the matchers from @types/jest instead of expect (or @jest/expect)
@@ -69,0 +48,0 @@ * so we're stubbing this type for now.

src/error/ErrorUtils.ts

@@ -122,2 +122,4 @@ /**
  * See https://github.com/jsdom/jsdom/issues/2727
+ * See https://github.com/facebook/jest/issues/2549
+ *
  * Read more related discussions at:
@@ -124,0 +126,0 @@ * https://github.com/jsdom/jsdom/issues/1737

No alert changes

Worsened metrics

Total package byte prevSize

340183

decreased by-0.99%

Lines of code

6188

decreased by-0.79%

No dependency changes