@firebase/installations - npm Package Compare versions

Comparing version 0.1.6-canary.9f109f8 to 0.1.6-canary.ae2698f

dist/index.cjs.js

@@ -12,3 +12,3 @@ 'use strict';
 
-var version = "0.1.6-canary.9f109f8";
+var version = "0.1.6-canary.ae2698f";
 
@@ -370,7 +370,8 @@ /**
                     tx = db.transaction(OBJECT_STORE_NAME, 'readwrite');
-                    // tslint:disable-next-line:no-floating-promises
-                    tx.objectStore(OBJECT_STORE_NAME).put(value, key);
-                    return [4 /*yield*/, tx.complete];
+                    return [4 /*yield*/, tx.objectStore(OBJECT_STORE_NAME).put(value, key)];
                 case 2:
                     _a.sent();
+                    return [4 /*yield*/, tx.complete];
+                case 3:
+                    _a.sent();
                     return [2 /*return*/, value];
@@ -393,5 +394,9 @@ }
                     tx = db.transaction(OBJECT_STORE_NAME, 'readwrite');
-                    // tslint:disable-next-line:no-floating-promises
-                    tx.objectStore(OBJECT_STORE_NAME).delete(key);
-                    return [2 /*return*/, tx.complete];
+                    return [4 /*yield*/, tx.objectStore(OBJECT_STORE_NAME).delete(key)];
+                case 2:
+                    _a.sent();
+                    return [4 /*yield*/, tx.complete];
+                case 3:
+                    _a.sent();
+                    return [2 /*return*/];
             }
@@ -426,13 +431,14 @@ });
                     }
-                    if (newValue === undefined) {
-                        // tslint:disable-next-line:no-floating-promises
-                        store.delete(key);
-                    }
-                    else {
-                        // tslint:disable-next-line:no-floating-promises
-                        store.put(newValue, key);
-                    }
-                    return [4 /*yield*/, tx.complete];
+                    if (!(newValue === undefined)) return [3 /*break*/, 4];
+                    return [4 /*yield*/, store.delete(key)];
                 case 3:
                     _a.sent();
+                    return [3 /*break*/, 6];
+                case 4: return [4 /*yield*/, store.put(newValue, key)];
+                case 5:
+                    _a.sent();
+                    _a.label = 6;
+                case 6: return [4 /*yield*/, tx.complete];
+                case 7:
+                    _a.sent();
                     return [2 /*return*/, newValue];
@@ -439,0 +445,0 @@ }

dist/index.esm.js

@@ -7,3 +7,3 @@ import firebase from '@firebase/app';
 
-var version = "0.1.6-canary.9f109f8";
+var version = "0.1.6-canary.ae2698f";
 
@@ -365,7 +365,8 @@ /**
                     tx = db.transaction(OBJECT_STORE_NAME, 'readwrite');
-                    // tslint:disable-next-line:no-floating-promises
-                    tx.objectStore(OBJECT_STORE_NAME).put(value, key);
-                    return [4 /*yield*/, tx.complete];
+                    return [4 /*yield*/, tx.objectStore(OBJECT_STORE_NAME).put(value, key)];
                 case 2:
                     _a.sent();
+                    return [4 /*yield*/, tx.complete];
+                case 3:
+                    _a.sent();
                     return [2 /*return*/, value];
@@ -388,5 +389,9 @@ }
                     tx = db.transaction(OBJECT_STORE_NAME, 'readwrite');
-                    // tslint:disable-next-line:no-floating-promises
-                    tx.objectStore(OBJECT_STORE_NAME).delete(key);
-                    return [2 /*return*/, tx.complete];
+                    return [4 /*yield*/, tx.objectStore(OBJECT_STORE_NAME).delete(key)];
+                case 2:
+                    _a.sent();
+                    return [4 /*yield*/, tx.complete];
+                case 3:
+                    _a.sent();
+                    return [2 /*return*/];
             }
@@ -421,13 +426,14 @@ });
                     }
-                    if (newValue === undefined) {
-                        // tslint:disable-next-line:no-floating-promises
-                        store.delete(key);
-                    }
-                    else {
-                        // tslint:disable-next-line:no-floating-promises
-                        store.put(newValue, key);
-                    }
-                    return [4 /*yield*/, tx.complete];
+                    if (!(newValue === undefined)) return [3 /*break*/, 4];
+                    return [4 /*yield*/, store.delete(key)];
                 case 3:
                     _a.sent();
+                    return [3 /*break*/, 6];
+                case 4: return [4 /*yield*/, store.put(newValue, key)];
+                case 5:
+                    _a.sent();
+                    _a.label = 6;
+                case 6: return [4 /*yield*/, tx.complete];
+                case 7:
+                    _a.sent();
                     return [2 /*return*/, newValue];
@@ -434,0 +440,0 @@ }

dist/index.esm2017.js

@@ -5,3 +5,3 @@ import firebase from '@firebase/app';
 
-const version = "0.1.6-canary.9f109f8";
+const version = "0.1.6-canary.ae2698f";
 
@@ -323,4 +323,3 @@ /**
     const tx = db.transaction(OBJECT_STORE_NAME, 'readwrite');
-    // tslint:disable-next-line:no-floating-promises
-    tx.objectStore(OBJECT_STORE_NAME).put(value, key);
+    await tx.objectStore(OBJECT_STORE_NAME).put(value, key);
     await tx.complete;
@@ -334,5 +333,4 @@ return value;
     const tx = db.transaction(OBJECT_STORE_NAME, 'readwrite');
-    // tslint:disable-next-line:no-floating-promises
-    tx.objectStore(OBJECT_STORE_NAME).delete(key);
-    return tx.complete;
+    await tx.objectStore(OBJECT_STORE_NAME).delete(key);
+    await tx.complete;
 }
@@ -356,8 +354,6 @@ /**
     if (newValue === undefined) {
-        // tslint:disable-next-line:no-floating-promises
-        store.delete(key);
+        await store.delete(key);
     }
     else {
-        // tslint:disable-next-line:no-floating-promises
-        store.put(newValue, key);
+        await store.put(newValue, key);
     }
@@ -364,0 +360,0 @@ await tx.complete;

package.json

 {
   "name": "@firebase/installations",
-  "version": "0.1.6-canary.9f109f8",
+  "version": "0.1.6-canary.ae2698f",
   "main": "dist/index.cjs.js",
@@ -50,8 +50,8 @@ "module": "dist/index.esm.js",
   "peerDependencies": {
-    "@firebase/app": "0.4.5-canary.9f109f8",
-    "@firebase/app-types": "0.4.0-canary.9f109f8"
+    "@firebase/app": "0.4.5-canary.ae2698f",
+    "@firebase/app-types": "0.4.0-canary.ae2698f"
   },
   "dependencies": {
-    "@firebase/installations-types": "0.1.1-canary.9f109f8",
-    "@firebase/util": "0.2.19-canary.9f109f8",
+    "@firebase/installations-types": "0.1.1-canary.ae2698f",
+    "@firebase/util": "0.2.19-canary.ae2698f",
     "idb": "3.0.2",
@@ -58,0 +58,0 @@ "tslib": "1.9.3"

src/functions/get-token.test.ts

@@ -40,4 +40,2 @@ /**
 
-// tslint:disable:no-floating-promises
-
 const FID = 'dont-talk-to-strangers';
@@ -105,2 +103,3 @@ const AUTH_TOKEN = 'authTokenFromServer';
       // Finish pending request after 500 ms
+      // tslint:disable-next-line:no-floating-promises
       sleep(500).then(async () => {
@@ -116,3 +115,3 @@ const updatedEntry: RegisteredInstallationEntry = {
         };
-        set(appConfig, updatedEntry);
+        await set(appConfig, updatedEntry);
       });
@@ -147,2 +146,3 @@ }
       // Finish pending request after 500 ms
+      // tslint:disable-next-line:no-floating-promises
       sleep(500).then(async () => {
@@ -160,3 +160,3 @@ const updatedEntry: RegisteredInstallationEntry = {
         };
-        set(appConfig, updatedEntry);
+        await set(appConfig, updatedEntry);
       });
@@ -163,0 +163,0 @@ }

src/helpers/extract-app-config.test.ts

@@ -38,3 +38,2 @@ /**
   it('throws if a necessary value is missing', () => {
-    // tslint:disable-next-line:no-any
     expect(() => extractAppConfig(undefined as any)).to.throw(FirebaseError);
@@ -41,0 +40,0 @@

src/helpers/idb-manager.ts

@@ -59,4 +59,3 @@ /**
   const tx = db.transaction(OBJECT_STORE_NAME, 'readwrite');
-  // tslint:disable-next-line:no-floating-promises
-  tx.objectStore(OBJECT_STORE_NAME).put(value, key);
+  await tx.objectStore(OBJECT_STORE_NAME).put(value, key);
   await tx.complete;
@@ -71,5 +70,4 @@ return value;
   const tx = db.transaction(OBJECT_STORE_NAME, 'readwrite');
-  // tslint:disable-next-line:no-floating-promises
-  tx.objectStore(OBJECT_STORE_NAME).delete(key);
-  return tx.complete;
+  await tx.objectStore(OBJECT_STORE_NAME).delete(key);
+  await tx.complete;
 }
@@ -99,7 +97,5 @@
   if (newValue === undefined) {
-    // tslint:disable-next-line:no-floating-promises
-    store.delete(key);
+    await store.delete(key);
   } else {
-    // tslint:disable-next-line:no-floating-promises
-    store.put(newValue, key);
+    await store.put(newValue, key);
   }
@@ -114,5 +110,4 @@
   const tx = db.transaction(OBJECT_STORE_NAME, 'readwrite');
-  // tslint:disable-next-line:no-floating-promises
-  tx.objectStore(OBJECT_STORE_NAME).clear();
-  return tx.complete;
+  await tx.objectStore(OBJECT_STORE_NAME).clear();
+  await tx.complete;
 }
@@ -119,0 +114,0 @@

New alerts

Unidentified License

License

(Experimental) Something that seems like a license was found, but its contents could not be matched with a known license.

Found 35 instances in 1 package

Fixed alerts

Unidentified License

License

(Experimental) Something that seems like a license was found, but its contents could not be matched with a known license.

Found 35 instances in 1 package

Improved metrics

Lines of code

7470

increased by0.04%

Worsened metrics

Total package byte prevSize

669134

decreased by-0.07%

Dependency changes

• + Added@firebase/[e-mail]2698f(transitive)

• + Added@firebase/[e-mail]2698f(transitive)

• + Added@firebase/[e-mail]2698f(transitive)

• + Added@firebase/[e-mail]2698f(transitive)

• + Added@firebase/[e-mail]2698f(transitive)

• - Removed@firebase/app@0.4.5-canary.9f109f8(transitive)

• - Removed@firebase/app-types@0.4.0-canary.9f109f8(transitive)

• - Removed@firebase/installations-types@0.1.1-canary.9f109f8(transitive)

• - Removed@firebase/logger@0.1.16-canary.9f109f8(transitive)

• - Removed@firebase/util@0.2.19-canary.9f109f8(transitive)

• Updated@firebase/[e-mail]2698f

• Updated@firebase/[e-mail]2698f