@firebase/installations - npm Package Compare versions

Comparing version 0.2.0-canary.c24ecf3 to 0.2.0-canary.c8bbad8

dist/index.cjs.js

@@ -12,3 +12,3 @@ 'use strict';
 
-var version = "0.2.0-canary.c24ecf3";
+var version = "0.2.0-canary.c8bbad8";
 
@@ -236,3 +236,3 @@ /**
                     registeredInstallationEntry = {
-                        fid: responseValue.fid,
+                        fid: responseValue.fid || fid,
                         registrationStatus: 2 /* COMPLETED */,
@@ -1069,4 +1069,3 @@ refreshToken: responseValue.refreshToken,
                     return [4 /*yield*/, update(appConfig, function (oldEntry) {
-                            if (oldEntry &&
-                                oldEntry.registrationStatus === 0 /* NOT_STARTED */) {
+                            if (oldEntry && oldEntry.registrationStatus === 0 /* NOT_STARTED */) {
                                 // Delete the unregistered entry without sending a deleteInstallation request.
@@ -1116,19 +1115,2 @@ return undefined;
  */
-
-/**
- * @license
- * Copyright 2019 Google Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
 function registerInstallations(instance) {
@@ -1135,0 +1117,0 @@ var installationsName = 'installations';

dist/index.esm.js

 import firebase from '@firebase/app';
-import * as tslib_1 from 'tslib';
 import { __awaiter, __generator, __spread, __assign } from 'tslib';
@@ -7,3 +6,3 @@ import { ErrorFactory, FirebaseError } from '@firebase/util';
 
-var version = "0.2.0-canary.c24ecf3";
+var version = "0.2.0-canary.c8bbad8";
 
@@ -231,3 +230,3 @@ /**
                     registeredInstallationEntry = {
-                        fid: responseValue.fid,
+                        fid: responseValue.fid || fid,
                         registrationStatus: 2 /* COMPLETED */,
@@ -1064,4 +1063,3 @@ refreshToken: responseValue.refreshToken,
                     return [4 /*yield*/, update(appConfig, function (oldEntry) {
-                            if (oldEntry &&
-                                oldEntry.registrationStatus === 0 /* NOT_STARTED */) {
+                            if (oldEntry && oldEntry.registrationStatus === 0 /* NOT_STARTED */) {
                                 // Delete the unregistered entry without sending a deleteInstallation request.
@@ -1111,19 +1109,2 @@ return undefined;
  */
-
-/**
- * @license
- * Copyright 2019 Google Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
 function registerInstallations(instance) {
@@ -1130,0 +1111,0 @@ var installationsName = 'installations';

dist/index.esm2017.js

@@ -5,3 +5,3 @@ import firebase from '@firebase/app';
 
-const version = "0.2.0-canary.c24ecf3";
+const version = "0.2.0-canary.c8bbad8";
 
@@ -197,3 +197,3 @@ /**
         const registeredInstallationEntry = {
-            fid: responseValue.fid,
+            fid: responseValue.fid || fid,
             registrationStatus: 2 /* COMPLETED */,
@@ -831,4 +831,3 @@ refreshToken: responseValue.refreshToken,
     const entry = await update(appConfig, (oldEntry) => {
-        if (oldEntry &&
-            oldEntry.registrationStatus === 0 /* NOT_STARTED */) {
+        if (oldEntry && oldEntry.registrationStatus === 0 /* NOT_STARTED */) {
             // Delete the unregistered entry without sending a deleteInstallation request.
@@ -872,19 +871,2 @@ return undefined;
  */
-
-/**
- * @license
- * Copyright 2019 Google Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
 function registerInstallations(instance) {
@@ -891,0 +873,0 @@ const installationsName = 'installations';

dist/src/interfaces/api-response.d.ts

@@ -20,3 +20,3 @@ /**
     readonly authToken: GenerateAuthTokenResponse;
-    readonly fid: string;
+    readonly fid?: string;
 }
@@ -23,0 +23,0 @@ export interface GenerateAuthTokenResponse {

package.json

 {
   "name": "@firebase/installations",
-  "version": "0.2.0-canary.c24ecf3",
+  "version": "0.2.0-canary.c8bbad8",
   "main": "dist/index.cjs.js",
@@ -26,4 +26,4 @@ "module": "dist/index.esm.js",
     "@types/chai-as-promised": "7.1.0",
-    "@types/mocha": "5.2.6",
-    "@types/sinon": "7.0.11",
+    "@types/mocha": "5.2.7",
+    "@types/sinon": "7.0.13",
     "@types/sinon-chai": "3.2.2",
@@ -34,28 +34,28 @@ "chai": "4.2.0",
     "mocha": "6.1.4",
-    "rollup": "1.11.0",
-    "rollup-plugin-commonjs": "9.3.4",
+    "rollup": "1.17.0",
+    "rollup-plugin-commonjs": "10.0.1",
     "rollup-plugin-json": "4.0.0",
-    "rollup-plugin-node-resolve": "4.2.3",
-    "rollup-plugin-typescript2": "0.21.0",
+    "rollup-plugin-node-resolve": "5.2.0",
+    "rollup-plugin-typescript2": "0.22.0",
     "rollup-plugin-uglify": "6.0.2",
     "sinon": "7.3.2",
     "sinon-chai": "3.3.0",
-    "tslint": "5.16.0",
-    "typescript": "3.4.5",
+    "tslint": "5.18.0",
+    "typescript": "3.5.3",
     "eslint": "5.16.0",
-    "@typescript-eslint/parser": "1.10.2",
-    "@typescript-eslint/eslint-plugin": "1.10.2",
-    "@typescript-eslint/eslint-plugin-tslint": "1.10.2",
-    "eslint-plugin-import": "2.17.3"
+    "@typescript-eslint/parser": "1.12.0",
+    "@typescript-eslint/eslint-plugin": "1.12.0",
+    "@typescript-eslint/eslint-plugin-tslint": "1.12.0",
+    "eslint-plugin-import": "2.18.0"
   },
   "peerDependencies": {
-    "@firebase/app": "0.4.8-canary.c24ecf3",
-    "@firebase/app-types": "0.4.0-canary.c24ecf3"
+    "@firebase/app": "0.4.10-canary.c8bbad8",
+    "@firebase/app-types": "0.4.0-canary.c8bbad8"
   },
   "dependencies": {
-    "@firebase/installations-types": "0.1.1-canary.c24ecf3",
-    "@firebase/util": "0.2.20-canary.c24ecf3",
+    "@firebase/installations-types": "0.1.1-canary.c8bbad8",
+    "@firebase/util": "0.2.21-canary.c8bbad8",
     "idb": "3.0.2",
-    "tslib": "1.9.3"
+    "tslib": "1.10.0"
   }
 }

src/api/create-installation.test.ts

@@ -108,2 +108,20 @@ /**
 
+  it('returns the FID from the request if the response does not contain one', async () => {
+    response = {
+      refreshToken: 'refreshToken',
+      authToken: {
+        token:
+          'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCeKKF2QT4fwpMeJf36POk6yJV_adQssw5c',
+        expiresIn: '604800s'
+      }
+    };
+    fetchSpy.resolves(new Response(JSON.stringify(response)));
+
+    const registeredInstallationEntry = await createInstallation(
+      appConfig,
+      inProgressInstallationEntry
+    );
+    expect(registeredInstallationEntry.fid).to.equal(FID);
+  });
+
   describe('failed request', () => {
@@ -110,0 +128,0 @@ it('throws a FirebaseError with the error information from the server', async () => {

src/api/create-installation.ts

@@ -58,3 +58,3 @@ /**
     const registeredInstallationEntry: RegisteredInstallationEntry = {
-      fid: responseValue.fid,
+      fid: responseValue.fid || fid,
       registrationStatus: RequestStatus.COMPLETED,
@@ -61,0 +61,0 @@ refreshToken: responseValue.refreshToken,

src/functions/delete-installation.ts

@@ -33,20 +33,12 @@ /**
 
-  const entry = await update(
-    appConfig,
-    (
-      oldEntry?: InstallationEntry
-    ):
-      | InProgressInstallationEntry
-      | RegisteredInstallationEntry
-      | undefined => {
-      if (
-        oldEntry &&
-        oldEntry.registrationStatus === RequestStatus.NOT_STARTED
-      ) {
-        // Delete the unregistered entry without sending a deleteInstallation request.
-        return undefined;
-      }
-      return oldEntry;
+  const entry = await update(appConfig, (oldEntry?: InstallationEntry):
+    | InProgressInstallationEntry
+    | RegisteredInstallationEntry
+    | undefined => {
+    if (oldEntry && oldEntry.registrationStatus === RequestStatus.NOT_STARTED) {
+      // Delete the unregistered entry without sending a deleteInstallation request.
+      return undefined;
     }
-  );
+    return oldEntry;
+  });
 
@@ -53,0 +45,0 @@ if (entry) {

src/interfaces/api-response.ts

@@ -21,3 +21,3 @@ /**
   readonly authToken: GenerateAuthTokenResponse;
-  readonly fid: string;
+  readonly fid?: string;
 }
@@ -24,0 +24,0 @@

tsconfig.json

@@ -6,4 +6,2 @@ {
     "resolveJsonModule": true,
-
-    "strict": true,
     "noUnusedLocals": true,
@@ -10,0 +8,0 @@ "noUnusedParameters": true,

New alerts

Unidentified License

License

(Experimental) Something that seems like a license was found, but its contents could not be matched with a known license.

Found 35 instances in 1 package

Fixed alerts

Unidentified License

License

(Experimental) Something that seems like a license was found, but its contents could not be matched with a known license.

Found 35 instances in 1 package

Worsened metrics

Total package byte prevSize

676720

decreased by-0.61%

Number of package files

265

decreased by-0.75%

Lines of code

7539

decreased by-0.59%

Dependency changes

• + Added@firebase/app@0.4.10-canary.c8bbad8(transitive)

• + Added@firebase/app-types@0.4.0-canary.c8bbad8(transitive)

• + Added@firebase/installations-types@0.1.1-canary.c8bbad8(transitive)

• + Added@firebase/logger@0.1.18-canary.c8bbad8(transitive)

• + Added@firebase/util@0.2.21-canary.c8bbad8(transitive)

• + Addedtslib@1.10.0(transitive)

• - Removed@firebase/app@0.4.8-canary.c24ecf3(transitive)

• - Removed@firebase/app-types@0.4.0-canary.c24ecf3(transitive)

• - Removed@firebase/installations-types@0.1.1-canary.c24ecf3(transitive)

• - Removed@firebase/logger@0.1.17-canary.c24ecf3(transitive)

• - Removed@firebase/util@0.2.20-canary.c24ecf3(transitive)

• - Removedtslib@1.9.3(transitive)

• Updated@firebase/installations-types@0.1.1-canary.c8bbad8

• Updated@firebase/util@0.2.21-canary.c8bbad8

• Updatedtslib@1.10.0