@fnmain/number - npm Package Compare versions

Comparing version 1.5.2 to 1.6.0

dist/index.d.ts

@@ -15,4 +15,6 @@ type Options = {
 export declare function isNotNumber(value: any): boolean;
-export declare function formatWithCommas(value: any): string;
+export declare function formatWithCommas(value: any, { strNaN }?: {
+    strNaN: string;
+}): string;
 export {};
 //# sourceMappingURL=index.d.ts.map

dist/index.js

@@ -114,4 +114,7 @@ "use strict";
 exports.isNotNumber = isNotNumber;
-function formatWithCommas(value) {
+function formatWithCommas(value, { strNaN } = { strNaN: "NaN" }) {
     const val = parseNumber(value);
+    if (isNaN(val)) {
+        return strNaN;
+    }
     return val.toString().replace(/(?<!\.\d*)(?=(\d{3})+(?!\d))/g, ",");
@@ -118,0 +121,0 @@ }

dist/test.js

@@ -33,2 +33,4 @@ "use strict";
 console.log((0, index_1.formatWithCommas)("12345.6789")); // 12,345.6789
+console.log((0, index_1.formatWithCommas)("abc")); // "NaN"
+console.log((0, index_1.formatWithCommas)("abc", { strNaN: "" })); // ""
 //# sourceMappingURL=test.js.map

package.json

 {
   "name": "@fnmain/number",
-  "version": "1.5.2",
+  "version": "1.6.0",
   "description": "number utils",
@@ -5,0 +5,0 @@ "main": "dist/index.js",

src/index.ts

@@ -138,5 +138,8 @@ type Options = {
 
-export function formatWithCommas(value: any): string {
+export function formatWithCommas(value: any, { strNaN } = { strNaN: "NaN" }): string {
   const val = parseNumber(value);
+  if (isNaN(val)) {
+    return strNaN;
+  }
   return val.toString().replace(/(?<!\.\d*)(?=(\d{3})+(?!\d))/g, ",");
 }

src/test.ts

@@ -37,1 +37,3 @@ import { formatWithCommas, isNotNumber, isNumber, parseNumber, toAuto, toPercent } from "./index";
 console.log(formatWithCommas("12345.6789")); // 12,345.6789
+console.log(formatWithCommas("abc")); // "NaN"
+console.log(formatWithCommas("abc", { strNaN: "" })); // ""

No alert changes

Improved metrics

Total package byte prevSize

21478

increased by3.61%

Lines of code

334

increased by3.73%

No dependency changes