@frontegg/injector - npm Package Compare versions

Comparing version 0.0.17 to 0.0.18

package.json

 {
   "name": "@frontegg/injector",
-  "version": "0.0.17",
+  "version": "0.0.18",
   "main": "dist/cjs/index.js",
@@ -19,3 +19,3 @@ "types": "dist/esm/index.d.ts",
   },
-  "gitHead": "12c4bfcc6bea137998f3d69545d094de090a543e"
+  "gitHead": "055d894c6ebcfbb239122dbc0a843965f5a22fb5"
 }

src/index.ts

@@ -101,41 +101,48 @@ import Logger from './logger';
 
-  injectJavascript(url: string | HTMLScriptElement): Promise<void> {
-    return new Promise(async (resolve) => {
+  injectJavascript(url: string | HTMLScriptElement) {
+    // if (typeof url === 'string') {
+
+    // }else{
+    // return this.shadowEl.appendChild(url);
+    // }
+    return (async () => {
       const logger = this.logger;
-      if (typeof url === 'string') {
-        logger.info('Loading JS file from ', url);
-        // const bundleScript = document.createElement('script');
-        // bundleScript.setAttribute('charset', 'utf-8');
-        // bundleScript.src = url;
-        // this.shadowEl.appendChild(bundleScript);
-        // bundleScript.onload = e => {
-        //   logger.info('JS loaded successfully', url);
-        //   resolve();
-        // };
+      if (typeof url !== 'string') {
+        url = url.src;
+      }
+      logger.info('Loading JS file from ', url);
+      // const bundleScript = document.createElement('script');
+      // bundleScript.setAttribute('charset', 'utf-8');
+      // bundleScript.src = url;
+      // this.shadowEl.appendChild(bundleScript);
+      // bundleScript.onload = e => {
+      //   logger.info('JS loaded successfully', url);
+      //   resolve();
+      // };
 
-        const res = await fetch(url, { method: 'GET', cache: 'default' });
-        let contentScript = await res.text();
-        const bundleScript = document.createElement('script');
-        bundleScript.setAttribute('charset', 'utf-8');
-        bundleScript.setAttribute('type', 'text/javascript');
+      const res = await fetch(url, { method: 'GET', cache: 'default' });
+      let contentScript = await res.text();
+      const bundleScript = document.createElement('script');
+      bundleScript.setAttribute('charset', 'utf-8');
+      bundleScript.setAttribute('type', 'text/javascript');
 
-        if (contentScript.indexOf('FRONTEGG_INJECTOR_CDN_HOST')) {
-          contentScript = contentScript.replace('/FRONTEGG_INJECTOR_CDN_HOST', this.cdn);
+      if (contentScript.indexOf('FRONTEGG_INJECTOR_CDN_HOST')) {
+        contentScript = contentScript.replace('/FRONTEGG_INJECTOR_CDN_HOST', this.cdn);
 
-          contentScript = `(()=> { const fronteggInjector = FronteggInjector.getInstance('${this.name}');
+        contentScript = `(()=> { const fronteggInjector = FronteggInjector.getInstance('${this.name}');
           ${contentScript}
           })();`;
 
-        }
-        bundleScript.innerHTML = contentScript;
+      }
+      bundleScript.innerHTML = contentScript;
 
-        this.shadowEl.appendChild(bundleScript);
-        logger.info('JS loaded successfully', url);
+      this.shadowEl.appendChild(bundleScript);
+      logger.info('JS loaded successfully', url);
 
-      } else {
-        logger.info('Loading lazy JS file from ', url.src);
-        this.shadowEl.appendChild(url);
-      }
-      resolve();
-    });
+      // } else {
+      //   logger.info('Loading lazy JS file from ', url.src);
+      //   this.shadowEl.appendChild(url);
+      // }
+      // resolve();
+    })();
   }
@@ -142,0 +149,0 @@

No alert changes

Improved metrics

Total package byte prevSize

153681

increased by0.05%

Lines of code

1497

increased by0.4%

No dependency changes