@gilt-tech/swig-bundle - npm Package Compare versions

Comparing version 2.6.0-vue.3 to 2.6.3

index.js

@@ -66,2 +66,3 @@
   const fs = require('fs');
+  const execa = require('execa');
   const merge = require('merge-stream');
@@ -71,3 +72,4 @@ const concat = require('./lib/concat-experience');
 
-  const basePublicPath = path.join(swig.target.path, '/public');
+  // Leaving path.join to protect from delimeters
+  const basePublicPath = path.join(swig.srcPath(swig));
   const basePath = path.join(basePublicPath, '/js', swig.target.name);
@@ -150,3 +152,5 @@
     ];
-    const raw = yield swig.exec(commands.join('; '));
+    const raw = yield execa.shell(commands.join('; '), {
+      preferLocal: false
+    });
     const result = JSON.parse(raw.stdout);
@@ -162,22 +166,12 @@
     const glob = [
-      path.join(swig.target.path, '/public/js/**/*.js'),
+      path.join(basePublicPath, '/js/**/*.js'),
 
-      // NOTE: For current node apps, `src/` folder contains untranspiled sources, which will be
-      // transpiled and put into `app/`. Therefore ignoring the `src/` altogether, as we don't want
-      // to send incompatible code to old browsers
-      `!${path.join(swig.target.path, '/public/js/**/src/**/*.js')}`,
+      // NOTE: exlcuding src/ as we want to fetch from the new app/ folder
+      `!${path.join(basePublicPath, '/js/**/src/**/*.js')}`,
 
-      // NOTE: Modern apps which want to leverage on smarter bundling mechanics, i.e. webpack based
-      // Can and should produce their artifacts in folder ignored by the swig bundling system,
-      // which could inadvertently nullify any possible dynamic loading strategy or similar.
-      // Choose one of the following: vue-app/ | artifacts/ | build/
-      `!${path.join(swig.target.path, '/public/js/**/vue-app/**/*.js')}`,
-      `!${path.join(swig.target.path, '/public/js/**/artifacts/**/*.js')}`,
-      `!${path.join(swig.target.path, '/public/js/**/build/**/*.js')}`,
-
-      `!${path.join(swig.target.path, '/public/js/**/internal/**/*.js')}`,
-      `!${path.join(swig.target.path, '/public/js/**/vendor/**/*.js')}`,
-      `!${path.join(swig.target.path, '/public/js/**/{main,bundles}*.js')}`,
-      `!${path.join(swig.target.path, '/public/js/**/*{src,min}.js')}`,
-      `!${path.join(swig.target.path, '/public/js/**/templates/**/*.js')}`,
+      `!${path.join(basePublicPath, '/js/**/internal/**/*.js')}`,
+      `!${path.join(basePublicPath, '/js/**/vendor/**/*.js')}`,
+      `!${path.join(basePublicPath, '/js/**/{main,bundles}*.js')}`,
+      `!${path.join(basePublicPath, '/js/**/*{src,min}.js')}`,
+      `!${path.join(basePublicPath, '/js/**/templates/**/*.js')}`,
     ];
@@ -184,0 +178,0 @@

package.json

 {
   "name": "@gilt-tech/swig-bundle",
   "description": "Bundles JavaScript assets.",
-  "version": "2.6.0-vue.3",
+  "version": "2.6.3",
   "repository": "https://github.com/gilt/swig/tree/master/packages/swig-bundle",
@@ -20,2 +20,3 @@ "keywords": [
     "concat-with-sourcemaps": "^1.0.0",
+    "execa": "^0.6.0",
     "globby": "^6.1.0",
@@ -30,4 +31,3 @@ "gulp-sourcemaps": "^2.0.0",
     "vinyl-sourcemaps-apply": "^0.2.1"
-  },
-  "devDependencies": {}
+  }
 }

Fixed alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Number of low quality alerts

1

decreased by-50%

Worsened metrics

Total package byte prevSize

20831

decreased by-3.31%

Dependency count

12

increased by9.09%

Lines of code

544

decreased by-0.91%

Dependency changes

• + Addedexeca@^0.6.0

• + Addedcross-spawn@5.1.0(transitive)

• + Addedexeca@0.6.3(transitive)

• + Addedget-stream@3.0.0(transitive)

• + Addedis-stream@1.1.0(transitive)

• + Addedisexe@2.0.0(transitive)

• + Addedlru-cache@4.1.5(transitive)

• + Addednpm-run-path@2.0.2(transitive)

• + Addedp-finally@1.0.0(transitive)

• + Addedpath-key@2.0.1(transitive)

• + Addedpseudomap@1.0.2(transitive)

• + Addedshebang-command@1.2.0(transitive)

• + Addedshebang-regex@1.0.0(transitive)

• + Addedsignal-exit@3.0.7(transitive)

• + Addedstrip-eof@1.0.0(transitive)

• + Addedwhich@1.3.1(transitive)

• + Addedyallist@2.1.2(transitive)