@gmod/cram - npm Package Compare versions

Comparing version 1.0.3 to 1.0.4

package.json

 {
   "name": "@gmod/cram",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "description": "read CRAM files with pure Javascript",
@@ -5,0 +5,0 @@ "license": "MIT",

src/cramFile/slice/index.js

@@ -395,13 +395,21 @@ const {
         const refStart = records[0].alignmentStart
-        const lastRecord = records[records.length - 1]
-        const refEnd = lastRecord.alignmentStart + lastRecord.lengthOnRef - 1
-        const seq = await this.file.fetchReferenceSequenceCallback(
-          sliceHeader.content.refSeqId,
-          refStart,
-          refEnd,
-        )
-        const refRegion = { seq, start: refStart, end: refEnd }
-        records.forEach(r => {
-          r.addReferenceSequence(refRegion, compressionScheme)
-        })
+
+        // need to iterate over the records to find the right end of the span
+        let refEnd = -Infinity
+        for (let i = 0; i < records.length; i += 1) {
+          const end = records[i].alignmentStart + records[i].lengthOnRef - 1
+          if (end > refEnd) refEnd = end
+        }
+
+        if (refStart <= refEnd) {
+          const seq = await this.file.fetchReferenceSequenceCallback(
+            sliceHeader.content.refSeqId,
+            refStart,
+            refEnd,
+          )
+          const refRegion = { seq, start: refStart, end: refEnd }
+          records.forEach(r => {
+            r.addReferenceSequence(refRegion, compressionScheme)
+          })
+        }
       }
@@ -408,0 +416,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

163199

increased by0.14%

Lines of code

4006

increased by0.15%

No dependency changes