@gooddata/js-utils - npm Package Compare versions

Comparing version 0.6.0-jza-one-2404-unify-cookies-2017-05-09T09-15-08-546Z to 0.6.0-jza-one-2404-unify-cookies-2017-05-09T12-28-51-152Z

lib/utils/cookies.js

@@ -48,5 +48,5 @@ 'use strict';
 function syncCookieWithBootstrap(state, data) {
-    var deps = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : {};
-    var messagesMap = arguments.length > 3 && arguments[3] !== undefined ? arguments[3] : {};
-    var localeDefault = arguments.length > 4 && arguments[4] !== undefined ? arguments[4] : 'en-US';
+    var messagesMap = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : {};
+    var localeDefault = arguments.length > 3 && arguments[3] !== undefined ? arguments[3] : 'en-US';
+    var deps = arguments.length > 4 && arguments[4] !== undefined ? arguments[4] : {};
     var _deps$getLocaleCookie = deps.getLocaleCookie,
@@ -53,0 +53,0 @@ getLocaleCookie = _deps$getLocaleCookie === undefined ? getLocale : _deps$getLocaleCookie,

package.json

 {
   "name": "@gooddata/js-utils",
-  "version": "0.6.0-jza-one-2404-unify-cookies-2017-05-09T09-15-08-546Z",
+  "version": "0.6.0-jza-one-2404-unify-cookies-2017-05-09T12-28-51-152Z",
   "description": "Various utils shared on GoodData frontend",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

src/utils/cookies.js

@@ -29,3 +29,3 @@ import Cookies from 'js-cookie';
 
-export function syncCookieWithBootstrap(state, data, deps = {}, messagesMap = {}, localeDefault = 'en-US') {
+export function syncCookieWithBootstrap(state, data, messagesMap = {}, localeDefault = 'en-US', deps = {}) {
     const {
@@ -32,0 +32,0 @@ getLocaleCookie = getLocale,

src/utils/test/cookies_test.js

@@ -6,2 +6,7 @@ import { syncCookieWithBootstrap } from '../cookies';
     const DE = 'de-DE';
+    const localeDefault = EN;
+    const messagesMap = {
+        [EN]: EN,
+        [DE]: DE
+    };
 
@@ -27,3 +32,3 @@ const getBootstrapDataWithLocale = language => ({
         const spySet = sinon.stub();
-        syncCookieWithBootstrap(stateEn, bootstrapEn, {
+        syncCookieWithBootstrap(stateEn, bootstrapEn, messagesMap, localeDefault, {
             getLocaleCookie: sinon.stub(),
@@ -39,3 +44,3 @@ setLocaleCookie: spySet,
         const spySet = sinon.stub();
-        syncCookieWithBootstrap(stateEn, bootstrapEn, {
+        syncCookieWithBootstrap(stateEn, bootstrapEn, messagesMap, localeDefault, {
             getLocaleCookie: () => EN,
@@ -51,3 +56,3 @@ setLocaleCookie: spySet,
         const spySet = sinon.stub();
-        syncCookieWithBootstrap(stateEn, bootstrapEn, {
+        syncCookieWithBootstrap(stateEn, bootstrapEn, messagesMap, localeDefault, {
             getLocaleCookie: () => DE,
@@ -54,0 +59,0 @@ setLocaleCookie: spySet,

No alert changes

Improved metrics

Total package byte prevSize

33444

increased by0.55%

Lines of code

744

increased by0.68%

No dependency changes