@gooddata/js-utils - npm Package Compare versions

Comparing version 3.10.1-alpha-khanh.le-kl-GD-1226-2020-04-06T09-41-13-641Z to 3.10.1-alpha-khanh.le-kl-SD-912-featureFlags-utils-2020-04-07T07-16-16-392Z

dist/utils/featureFlags.d.ts

 interface IFeatureFlags {
-    disablePPExperience?: boolean;
-    enablePPExperience?: boolean;
-    hidePixelPerfectExperience?: boolean;
-    platformEdition?: string;
+    [key: string]: number | boolean | string;
 }
 export declare function shouldHidePPExperience(featureFlags: IFeatureFlags): boolean;
-export declare function isFreemiumEdition(platformEdition: string | undefined): boolean;
+export declare function isFreemiumEdition(platformEdition: string): boolean;
 export {};

dist/utils/featureFlags.js

@@ -7,5 +7,7 @@ "use strict";
 function shouldHidePPExperience(featureFlags) {
-    var disablePPExperience = featureFlags.disablePPExperience, enablePPExperience = featureFlags.enablePPExperience, hidePixelPerfectExperience = featureFlags.hidePixelPerfectExperience, platformEdition = featureFlags.platformEdition;
+    var enablePPExperience = featureFlags.enablePPExperience;
+    var hidePixelPerfectExperience = featureFlags.hidePixelPerfectExperience;
+    var platformEdition = featureFlags.platformEdition;
     var isFreemiumUser = isFreemiumEdition(platformEdition);
-    return hidePixelPerfectExperience || disablePPExperience || (isFreemiumUser && !enablePPExperience);
+    return hidePixelPerfectExperience || (isFreemiumUser && !enablePPExperience);
 }
@@ -12,0 +14,0 @@ exports.shouldHidePPExperience = shouldHidePPExperience;

package.json

 {
   "name": "@gooddata/js-utils",
-  "version": "3.10.1-alpha-khanh.le-kl-GD-1226-2020-04-06T09-41-13-641Z",
+  "version": "3.10.1-alpha-khanh.le-kl-SD-912-featureFlags-utils-2020-04-07T07-16-16-392Z",
   "description": "Various utils shared on GoodData frontend",
@@ -5,0 +5,0 @@ "repository": {

src/utils/featureFlags.ts

@@ -6,16 +6,15 @@ // (C) 2020 GoodData Corporation
 interface IFeatureFlags {
-    disablePPExperience?: boolean;
-    enablePPExperience?: boolean;
-    hidePixelPerfectExperience?: boolean;
-    platformEdition?: string;
+    [key: string]: number | boolean | string;
 }
 
 export function shouldHidePPExperience(featureFlags: IFeatureFlags): boolean {
-    const {disablePPExperience, enablePPExperience, hidePixelPerfectExperience, platformEdition } = featureFlags;
-    const isFreemiumUser = isFreemiumEdition(platformEdition);
+    const enablePPExperience = featureFlags.enablePPExperience as boolean;
+    const hidePixelPerfectExperience = featureFlags.hidePixelPerfectExperience as boolean;
+    const platformEdition = featureFlags.platformEdition as string;
+    const isFreemiumUser = isFreemiumEdition(platformEdition as string);
 
-    return hidePixelPerfectExperience || disablePPExperience || (isFreemiumUser && !enablePPExperience);
+    return hidePixelPerfectExperience || (isFreemiumUser && !enablePPExperience);
 }
 
-export function isFreemiumEdition(platformEdition: string | undefined): boolean {
+export function isFreemiumEdition(platformEdition: string): boolean {
     if (!platformEdition) {
@@ -22,0 +21,0 @@ return false;

No alert changes

Improved metrics

Total package byte prevSize

61661

increased by2.36%

Number of package files

56

increased by1.82%

Lines of code

1212

increased by2.19%

No dependency changes