@gooddata/js-utils - npm Package Compare versions

Comparing version 3.10.14-alpha-ptquang86-qp-sd-1328-naming-2021-01-05T06-25-57-763Z to 3.10.14-alpha-ptquang86-qp-sd-1328-naming-2021-01-07T02-27-58-895Z

dist/utils/featureFlags.js

@@ -29,9 +29,12 @@ "use strict";
     var enableNewNavigationForResponsiveUi = featureFlags.enableNewNavigationForResponsiveUi;
-    var platformEdition = featureFlags.platformEdition;
-    if (platformEdition === FREE) {
-        return enableNewNavigationForResponsiveUi;
+    if (enableNewNavigationForResponsiveUi) {
+        var platformEdition = featureFlags.platformEdition;
+        // Free: always true
+        if (platformEdition === FREE) {
+            return true;
+        }
+        // Growth/Enterprise: with PP: false, without PP: On demand
+        return shouldHidePPExperience(featureFlags);
     }
-    // Growth/Enterprise: with PP: false, without PP: On demand
-    return (enableNewNavigationForResponsiveUi &&
-        shouldHidePPExperience(featureFlags));
+    return false;
 }
@@ -38,0 +41,0 @@ exports.shouldEnableNewNavigation = shouldEnableNewNavigation;

package.json

 {
   "name": "@gooddata/js-utils",
-  "version": "3.10.14-alpha-ptquang86-qp-sd-1328-naming-2021-01-05T06-25-57-763Z",
+  "version": "3.10.14-alpha-ptquang86-qp-sd-1328-naming-2021-01-07T02-27-58-895Z",
   "description": "Various utils shared on GoodData frontend",
@@ -5,0 +5,0 @@ "repository": {

src/utils/featureFlags.ts

@@ -43,13 +43,17 @@ // (C) 2020-2021 GoodData Corporation
     const enableNewNavigationForResponsiveUi = featureFlags.enableNewNavigationForResponsiveUi as boolean;
-    const platformEdition = featureFlags.platformEdition as string;
+    if (enableNewNavigationForResponsiveUi) {
+        const platformEdition = featureFlags.platformEdition as string;
 
-    if (platformEdition === FREE) {
-        return enableNewNavigationForResponsiveUi;
+        // Free: always true
+        if (platformEdition === FREE) {
+            return true;
+        }
+
+        // Growth/Enterprise: with PP: false, without PP: On demand
+        return shouldHidePPExperience(featureFlags);
     }
 
-    // Growth/Enterprise: with PP: false, without PP: On demand
-    return (
-        enableNewNavigationForResponsiveUi &&
-        shouldHidePPExperience(featureFlags)
-    );
+    return false;
+
+
 }
@@ -56,0 +60,0 @@

No alert changes

Improved metrics

Total package byte prevSize

108748

increased by0.11%

Lines of code

2196

increased by0.18%

No dependency changes