@gooddata/js-utils - npm Package Compare versions

Comparing version 3.10.2 to 3.10.3-lanhuynh-lhq-sd-884-rebuild-postmessages-typings-2020-04-10T02-07-47-378Z

dist/utils/featureFlags.d.ts

 interface IFeatureFlags {
     [key: string]: number | boolean | string;
-    hidePixelPerfectExperience: boolean;
-    enablePixelPerfectExperience: string;
-    platformEdition: string;
 }
@@ -7,0 +4,0 @@ interface INormalizedFeatureFlagContent {

dist/utils/featureFlags.js

@@ -16,5 +16,7 @@ "use strict";
 function shouldHidePPExperience(featureFlags) {
-    var hidePixelPerfectExperience = featureFlags.hidePixelPerfectExperience, enablePixelPerfectExperience = featureFlags.enablePixelPerfectExperience, platformEdition = featureFlags.platformEdition;
+    var hidePPExperience = featureFlags.hidePixelPerfectExperience;
+    var enablePPExperience = featureFlags.enablePixelPerfectExperience;
+    var platformEdition = featureFlags.platformEdition;
     var isFreemiumUser = isFreemiumEdition(platformEdition);
-    return hidePixelPerfectExperience || (isFreemiumUser && enablePixelPerfectExperience !== 'true');
+    return hidePPExperience || (isFreemiumUser && enablePPExperience !== 'true');
 }
@@ -21,0 +23,0 @@ exports.shouldHidePPExperience = shouldHidePPExperience;

dist/utils/post-events.d.ts

@@ -1,13 +0,2 @@
-export interface IGdcMessageEvent extends MessageEvent {
-    data: {
-        gdc: {
-            product: string;
-            event: {
-                name: string;
-                data: any;
-            };
-        };
-    };
-}
-export declare type GdcMessageEventListener = (event: IGdcMessageEvent) => boolean;
+import { GdcMessageEventListener } from '@gooddata/typings';
 export interface IHost {
@@ -14,0 +3,0 @@ postMessage?: Window['postMessage'];

dist/utils/post-events.js

@@ -6,3 +6,3 @@ "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-// (C) 2007-2019 GoodData Corporation
+// (C) 2007-2020 GoodData Corporation
 var get_1 = __importDefault(require("lodash/get"));
@@ -9,0 +9,0 @@ var host;

package.json

 {
   "name": "@gooddata/js-utils",
-  "version": "3.10.2",
+  "version": "3.10.3-lanhuynh-lhq-sd-884-rebuild-postmessages-typings-2020-04-10T02-07-47-378Z",
   "description": "Various utils shared on GoodData frontend",
@@ -49,2 +49,3 @@ "repository": {
   "dependencies": {
+    "@gooddata/typings": "2.23.0-lanhuynh-lhq-sd-884-post-event-typings-2020-04-10T02-05-34-382Z",
     "js-cookie": "^2.1.4",
@@ -51,0 +52,0 @@ "lodash": "^4.17.15"

src/utils/featureFlags.ts

@@ -14,5 +14,2 @@ // (C) 2020 GoodData Corporation
     [key: string]: number | boolean | string;
-    hidePixelPerfectExperience: boolean;
-    enablePixelPerfectExperience: string;
-    platformEdition: string;
 }
@@ -40,6 +37,8 @@
 export function shouldHidePPExperience(featureFlags: IFeatureFlags): boolean {
-    const { hidePixelPerfectExperience, enablePixelPerfectExperience, platformEdition } = featureFlags;
+    const hidePPExperience = featureFlags.hidePixelPerfectExperience as boolean;
+    const enablePPExperience = featureFlags.enablePixelPerfectExperience as string;
+    const platformEdition = featureFlags.platformEdition as string;
     const isFreemiumUser = isFreemiumEdition(platformEdition);
 
-    return hidePixelPerfectExperience || (isFreemiumUser && enablePixelPerfectExperience !== 'true');
+    return hidePPExperience || (isFreemiumUser && enablePPExperience !== 'true');
 }
@@ -46,0 +45,0 @@

src/utils/post-events.ts

@@ -1,17 +0,5 @@
-// (C) 2007-2019 GoodData Corporation
+// (C) 2007-2020 GoodData Corporation
 import get from 'lodash/get';
+import { IGdcMessageEvent, GdcMessageEventListener, IGdcMessageEventListenerConfig } from '@gooddata/typings';
 
-export interface IGdcMessageEvent extends MessageEvent {
-    data: {
-        gdc: {
-            product: string;
-            event: {
-                name: string;
-                data: any;
-            }
-        }
-    };
-}
-export type GdcMessageEventListener = (event: IGdcMessageEvent) => boolean;
-
 export interface IHost {
@@ -51,8 +39,6 @@ postMessage?: Window['postMessage'];
 }
+
 const receivers: IReceiverEntry[] = [];
-interface IConfig {
-    product: string;
-    validReceivedPostEvents: string[];
-}
-let config: IConfig = {
+
+let config: IGdcMessageEventListenerConfig = {
     product: '',
@@ -62,3 +48,5 @@ validReceivedPostEvents: []
 
-const receiveListener = (listener: GdcMessageEventListener): GdcMessageEventListener => (event: IGdcMessageEvent) => {
+const receiveListener = (
+    listener: GdcMessageEventListener
+): GdcMessageEventListener => (event: IGdcMessageEvent<string, string, any>) => {
     return (
@@ -65,0 +53,0 @@ get(event, 'data.gdc.product') === config.product &&

src/utils/test/post-events.test.ts

@@ -1,3 +0,4 @@
-// (C) 2007-2018 GoodData Corporation
-import { setHost, postEvent, setConfig, addListener, removeListener, IGdcMessageEvent } from '../post-events';
+// (C) 2007-2020 GoodData Corporation
+import { IGdcMessageEvent } from '@gooddata/typings';
+import { setHost, postEvent, setConfig, addListener, removeListener } from '../post-events';
 
@@ -34,3 +35,3 @@ describe('Post events', () => {
         beforeEach(() => {
-            listener = (e: IGdcMessageEvent) => e.data.gdc.event.data;
+            listener = (e: IGdcMessageEvent<string, string, any>) => e.data.gdc.event.data;
             target = {
@@ -37,0 +38,0 @@ addEventListener: jest.fn(),

New alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

66791

decreased by-0.44%

Dependency count

3

increased by50%

Lines of code

1317

decreased by-1.86%

Number of low quality alerts

2

increased by100%

Dependency changes

• + Added@gooddata/typings@2.23.0-lanhuynh-lhq-sd-884-post-event-typings-2020-04-10T02-05-34-382Z

• + Added@gooddata/typings@2.23.0-lanhuynh-lhq-sd-884-post-event-typings-2020-04-10T02-05-34-382Z(transitive)