@gooddata/js-utils - npm Package Compare versions

Comparing version 3.10.8 to 3.10.9

dist/utils/filterUtils.js

@@ -31,9 +31,11 @@ "use strict";
         var _b = getObjectUriIdentifier(displayForm), uri = _b.uri, identifier = _b.identifier;
-        return (lodash_1.isString(uri) || lodash_1.isString(identifier)) && attributeElements.length !== 0;
+        return (lodash_1.isString(uri) || lodash_1.isString(identifier))
+            && Array.isArray(attributeElements) && attributeElements.length !== 0;
     }
     else {
-        var displayForm = filterItem.negativeAttributeFilter.displayForm;
-        var _c = getObjectUriIdentifier(displayForm), uri = _c.uri, identifier = _c.identifier;
+        var _c = filterItem.negativeAttributeFilter, displayForm = _c.displayForm, attributeElements = _c.notIn;
+        var _d = getObjectUriIdentifier(displayForm), uri = _d.uri, identifier = _d.identifier;
         // attributeElements could be empty in case of setting All Value
-        return lodash_1.isString(uri) || lodash_1.isString(identifier);
+        return (lodash_1.isString(uri) || lodash_1.isString(identifier))
+            && Array.isArray(attributeElements);
     }
@@ -40,0 +42,0 @@ }

package.json

 {
   "name": "@gooddata/js-utils",
-  "version": "3.10.8",
+  "version": "3.10.9",
   "description": "Various utils shared on GoodData frontend",
@@ -5,0 +5,0 @@ "repository": {

src/utils/filterUtils.ts

@@ -60,10 +60,12 @@ // (C) 2020 GoodData Corporation
         const { uri, identifier } = getObjectUriIdentifier(displayForm);
-        return (isString(uri) || isString(identifier)) && attributeElements.length !== 0;
+        return (isString(uri) || isString(identifier))
+            && Array.isArray(attributeElements) && attributeElements.length !== 0;
     } else {
         const {
-            negativeAttributeFilter: { displayForm }
+            negativeAttributeFilter: { displayForm, notIn: attributeElements }
         } = filterItem;
         const { uri, identifier } = getObjectUriIdentifier(displayForm);
         // attributeElements could be empty in case of setting All Value
-        return isString(uri) || isString(identifier);
+        return (isString(uri) || isString(identifier))
+            && Array.isArray(attributeElements);
     }
@@ -70,0 +72,0 @@ }

No alert changes

Improved metrics

Total package byte prevSize

98205

increased by0.38%

Lines of code

1989

increased by0.2%

No dependency changes