@gooddata/js-utils - npm Package Compare versions

Comparing version 3.10.8 to 3.10.9-alpha-khanh-le-kl-sd-980-2020-07-16T09-01-17-571Z

dist/utils/filterUtils.d.ts

@@ -25,2 +25,4 @@ import { EmbeddedGdc } from '@gooddata/typings';
 export declare function isValidFiltersFormat(filters: any[]): boolean;
+export declare function isValidRemoveFilterItemFormat(filterItem: any): boolean;
+export declare function isValidRemoveFiltersFormat(filters: any[]): boolean;
 export declare function transformFilterContext(filters: EmbeddedGdc.FilterItem[]): IExternalFiltersObject;
@@ -31,1 +33,3 @@ export declare function isTransformedDateFilterItem(filterItem: ITransformedFilterItem): filterItem is ITransformedDateFilterItem;
 export declare function isAllValueAttributeFilterItem(filterItem: ITransformedFilterItem): boolean;
+export declare function isRemoveDateFilter(filter: any): filter is any;
+export declare function isRemoveAttributeFilter(filter: any): filter is any;

dist/utils/filterUtils.js

@@ -31,9 +31,11 @@ "use strict";
         var _b = getObjectUriIdentifier(displayForm), uri = _b.uri, identifier = _b.identifier;
-        return (lodash_1.isString(uri) || lodash_1.isString(identifier)) && attributeElements.length !== 0;
+        return (lodash_1.isString(uri) || lodash_1.isString(identifier))
+            && Array.isArray(attributeElements) && attributeElements.length !== 0;
     }
     else {
-        var displayForm = filterItem.negativeAttributeFilter.displayForm;
-        var _c = getObjectUriIdentifier(displayForm), uri = _c.uri, identifier = _c.identifier;
+        var _c = filterItem.negativeAttributeFilter, displayForm = _c.displayForm, attributeElements = _c.notIn;
+        var _d = getObjectUriIdentifier(displayForm), uri = _d.uri, identifier = _d.identifier;
         // attributeElements could be empty in case of setting All Value
-        return lodash_1.isString(uri) || lodash_1.isString(identifier);
+        return (lodash_1.isString(uri) || lodash_1.isString(identifier))
+            && Array.isArray(attributeElements);
     }
@@ -54,2 +56,19 @@ }
 exports.isValidFiltersFormat = isValidFiltersFormat;
+function isValidRemoveFilterItemFormat(filterItem) {
+    if (isRemoveDateFilter(filterItem)) {
+        var dataSet = filterItem.dataSet;
+        var _a = getObjectUriIdentifier(dataSet), uri = _a.uri, identifier = _a.identifier;
+        return lodash_1.isString(uri) || lodash_1.isString(identifier);
+    }
+    else {
+        var displayForm = filterItem.displayForm;
+        var _b = getObjectUriIdentifier(displayForm), uri = _b.uri, identifier = _b.identifier;
+        return lodash_1.isString(uri) || lodash_1.isString(identifier);
+    }
+}
+exports.isValidRemoveFilterItemFormat = isValidRemoveFilterItemFormat;
+function isValidRemoveFiltersFormat(filters) {
+    return !lodash_1.isEmpty(filters) && filters.every(isValidRemoveFilterItemFormat);
+}
+exports.isValidRemoveFiltersFormat = isValidRemoveFiltersFormat;
 function getObjectUriIdentifier(obj) {
@@ -148,2 +167,10 @@ return {
 exports.isAllValueAttributeFilterItem = isAllValueAttributeFilterItem;
+function isRemoveDateFilter(filter) {
+    return !lodash_1.isEmpty(filter) && filter.dataSet !== undefined;
+}
+exports.isRemoveDateFilter = isRemoveDateFilter;
+function isRemoveAttributeFilter(filter) {
+    return !lodash_1.isEmpty(filter) && filter.displayForm !== undefined;
+}
+exports.isRemoveAttributeFilter = isRemoveAttributeFilter;
 //# sourceMappingURL=filterUtils.js.map

package.json

 {
   "name": "@gooddata/js-utils",
-  "version": "3.10.8",
+  "version": "3.10.9-alpha-khanh-le-kl-sd-980-2020-07-16T09-01-17-571Z",
   "description": "Various utils shared on GoodData frontend",
@@ -49,3 +49,3 @@ "repository": {
   "dependencies": {
-    "@gooddata/typings": "^2.24.9",
+    "@gooddata/typings": "2.25.0-alpha-khanh-le-kl-sd-980-2020-07-16T08-58-49-507Z",
     "js-cookie": "^2.1.4",
@@ -52,0 +52,0 @@ "lodash": "^4.17.15"

src/utils/filterUtils.ts

@@ -60,10 +60,12 @@ // (C) 2020 GoodData Corporation
         const { uri, identifier } = getObjectUriIdentifier(displayForm);
-        return (isString(uri) || isString(identifier)) && attributeElements.length !== 0;
+        return (isString(uri) || isString(identifier))
+            && Array.isArray(attributeElements) && attributeElements.length !== 0;
     } else {
         const {
-            negativeAttributeFilter: { displayForm }
+            negativeAttributeFilter: { displayForm, notIn: attributeElements }
         } = filterItem;
         const { uri, identifier } = getObjectUriIdentifier(displayForm);
         // attributeElements could be empty in case of setting All Value
-        return isString(uri) || isString(identifier);
+        return (isString(uri) || isString(identifier))
+            && Array.isArray(attributeElements);
     }
@@ -84,2 +86,18 @@ }
 
+export function isValidRemoveFilterItemFormat(filterItem: any): boolean {
+    if (isRemoveDateFilter(filterItem)) {
+        const { dataSet } = filterItem;
+        const { uri, identifier } = getObjectUriIdentifier(dataSet);
+        return isString(uri) || isString(identifier);
+    } else {
+        const { displayForm } = filterItem;
+        const { uri, identifier } = getObjectUriIdentifier(displayForm);
+        return isString(uri) || isString(identifier);
+    }
+}
+
+export function isValidRemoveFiltersFormat(filters: any[]): boolean {
+    return !isEmpty(filters) && filters.every(isValidRemoveFilterItemFormat);
+}
+
 function getObjectUriIdentifier(obj: EmbeddedGdc.ObjQualifier): { uri?: string; identifier?: string } {
@@ -201,1 +219,9 @@ return {
 }
+
+export function isRemoveDateFilter(filter: any): filter is any {
+    return !isEmpty(filter) && (filter as any).dataSet !== undefined;
+}
+
+export function isRemoveAttributeFilter(filter: any): filter is any {
+    return !isEmpty(filter) && (filter as any).displayForm !== undefined;
+}

New alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

101412

increased by3.66%

Lines of code

2038

increased by2.67%

Worsened metrics

Number of low quality alerts

2

increased by100%

Dependency changes

• + Added@gooddata/typings@2.25.0-alpha-khanh-le-kl-sd-980-2020-07-16T08-58-49-507Z(transitive)

• - Removed@gooddata/typings@2.29.0(transitive)

• Updated@gooddata/typings@2.25.0-alpha-khanh-le-kl-sd-980-2020-07-16T08-58-49-507Z