@google-cloud/redis - npm Package Compare versions

Comparing version 1.4.1 to 1.4.2

build/src/v1/cloud_redis_client_config.json

@@ -16,5 +16,5 @@ {
                     "max_retry_delay_millis": 60000,
-                    "initial_rpc_timeout_millis": 20000,
+                    "initial_rpc_timeout_millis": 60000,
                     "rpc_timeout_multiplier": 1,
-                    "max_rpc_timeout_millis": 20000,
+                    "max_rpc_timeout_millis": 60000,
                     "total_timeout_millis": 600000
@@ -21,0 +21,0 @@ }

build/src/v1/cloud_redis_client.js

@@ -192,2 +192,5 @@ "use strict";
             const innerCallPromise = this.cloudRedisStub.then(stub => (...args) => {
+                if (this._terminated) {
+                    return Promise.reject('The client has already been closed.');
+                }
                 return stub[methodName].apply(stub, args);
@@ -201,5 +204,2 @@ }, (err) => () => {
             this._innerApiCalls[methodName] = (argument, callOptions, callback) => {
-                if (this._terminated) {
-                    return Promise.reject('The client has already been closed.');
-                }
                 return apiCall(argument, callOptions, callback);
@@ -563,9 +563,14 @@ };
      * @returns {Promise} - The promise which resolves to an array.
-     *   The first element of the array is an object representing [ListInstancesResponse]{@link google.cloud.redis.v1.ListInstancesResponse}.
+     *   The first element of the array is Array of [Instance]{@link google.cloud.redis.v1.Instance}.
+     *   The client library support auto-pagination by default: it will call the API as many
+     *   times as needed and will merge results from all the pages into this array.
      *
      *   When autoPaginate: false is specified through options, the array has three elements.
-     *   The first element is Array of [ListInstancesResponse]{@link google.cloud.redis.v1.ListInstancesResponse} in a single response.
-     *   The second element is the next request object if the response
-     *   indicates the next page exists, or null. The third element is
-     *   an object representing [ListInstancesResponse]{@link google.cloud.redis.v1.ListInstancesResponse}.
+     *   The first element is Array of [Instance]{@link google.cloud.redis.v1.Instance} that corresponds to
+     *   the one page received from the API server.
+     *   If the second element is not null it contains the request object of type [ListInstancesRequest]{@link google.cloud.redis.v1.ListInstancesRequest}
+     *   that can be used to obtain the next page of the results.
+     *   If it is null, the next page does not exist.
+     *   The third element contains the raw response received from the API server. Its type is
+     *   [ListInstancesResponse]{@link google.cloud.redis.v1.ListInstancesResponse}.
      *
@@ -572,0 +577,0 @@ *   The promise has a method named "cancel" which cancels the ongoing API call.

build/src/v1beta1/cloud_redis_client_config.json

@@ -16,5 +16,5 @@ {
                     "max_retry_delay_millis": 60000,
-                    "initial_rpc_timeout_millis": 20000,
+                    "initial_rpc_timeout_millis": 60000,
                     "rpc_timeout_multiplier": 1,
-                    "max_rpc_timeout_millis": 20000,
+                    "max_rpc_timeout_millis": 60000,
                     "total_timeout_millis": 600000
@@ -21,0 +21,0 @@ }

build/src/v1beta1/cloud_redis_client.js

@@ -192,2 +192,5 @@ "use strict";
             const innerCallPromise = this.cloudRedisStub.then(stub => (...args) => {
+                if (this._terminated) {
+                    return Promise.reject('The client has already been closed.');
+                }
                 return stub[methodName].apply(stub, args);
@@ -201,5 +204,2 @@ }, (err) => () => {
             this._innerApiCalls[methodName] = (argument, callOptions, callback) => {
-                if (this._terminated) {
-                    return Promise.reject('The client has already been closed.');
-                }
                 return apiCall(argument, callOptions, callback);
@@ -563,9 +563,14 @@ };
      * @returns {Promise} - The promise which resolves to an array.
-     *   The first element of the array is an object representing [ListInstancesResponse]{@link google.cloud.redis.v1beta1.ListInstancesResponse}.
+     *   The first element of the array is Array of [Instance]{@link google.cloud.redis.v1beta1.Instance}.
+     *   The client library support auto-pagination by default: it will call the API as many
+     *   times as needed and will merge results from all the pages into this array.
      *
      *   When autoPaginate: false is specified through options, the array has three elements.
-     *   The first element is Array of [ListInstancesResponse]{@link google.cloud.redis.v1beta1.ListInstancesResponse} in a single response.
-     *   The second element is the next request object if the response
-     *   indicates the next page exists, or null. The third element is
-     *   an object representing [ListInstancesResponse]{@link google.cloud.redis.v1beta1.ListInstancesResponse}.
+     *   The first element is Array of [Instance]{@link google.cloud.redis.v1beta1.Instance} that corresponds to
+     *   the one page received from the API server.
+     *   If the second element is not null it contains the request object of type [ListInstancesRequest]{@link google.cloud.redis.v1beta1.ListInstancesRequest}
+     *   that can be used to obtain the next page of the results.
+     *   If it is null, the next page does not exist.
+     *   The third element contains the raw response received from the API server. Its type is
+     *   [ListInstancesResponse]{@link google.cloud.redis.v1beta1.ListInstancesResponse}.
      *
@@ -572,0 +577,0 @@ *   The promise has a method named "cancel" which cancels the ongoing API call.

CHANGELOG.md

@@ -7,2 +7,10 @@ # Changelog
 
+### [1.4.2](https://www.github.com/googleapis/nodejs-redis/compare/v1.4.1...v1.4.2) (2020-01-05)
+
+
+### Bug Fixes
+
+* better client close(), update .nycrc, require mocha explicitly ([f7367eb](https://www.github.com/googleapis/nodejs-redis/commit/f7367eb9ce5db152c0b68e65aa81a1baab842d2b))
+* increase timeout from 20s to 60s ([#247](https://www.github.com/googleapis/nodejs-redis/issues/247)) ([bc939d9](https://www.github.com/googleapis/nodejs-redis/commit/bc939d9da53d9a13da0f382797ce11c8c77b4371))
+
 ### [1.4.1](https://www.github.com/googleapis/nodejs-redis/compare/v1.4.0...v1.4.1) (2019-12-11)
@@ -9,0 +17,0 @@

package.json

 {
   "name": "@google-cloud/redis",
   "description": "Google Cloud Memorystore for Redis API client for Node.js",
-  "version": "1.4.1",
+  "version": "1.4.2",
   "license": "Apache-2.0",
@@ -49,7 +49,7 @@ "author": "Google LLC",
     "@types/node": "^12.0.0",
-    "c8": "^6.0.0",
+    "c8": "^7.0.0",
     "codecov": "^3.1.0",
     "eslint": "^6.0.0",
     "eslint-config-prettier": "^6.0.0",
-    "eslint-plugin-node": "^10.0.0",
+    "eslint-plugin-node": "^11.0.0",
     "eslint-plugin-prettier": "^3.0.0",
@@ -56,0 +56,0 @@ "gts": "^1.0.0",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1996571

increased by0.06%

Lines of code

32712

increased by0.03%

No dependency changes