@google-cloud/redis - npm Package Compare versions

Comparing version 2.0.0 to 2.1.0

build/src/v1/cloud_redis_client.js

@@ -92,11 +92,14 @@ "use strict";
         opts.port = opts.port || port;
+        // users can override the config from client side, like retry codes name.
+        // The detailed structure of the clientConfig can be found here: https://github.com/googleapis/gax-nodejs/blob/master/src/gax.ts#L546
+        // The way to override client config for Showcase API:
+        //
+        // const customConfig = {"interfaces": {"google.showcase.v1beta1.Echo": {"methods": {"Echo": {"retry_codes_name": "idempotent", "retry_params_name": "default"}}}}}
+        // const showcaseClient = new showcaseClient({ projectId, customConfig });
         opts.clientConfig = opts.clientConfig || {};
-        const isBrowser = typeof window !== 'undefined';
-        if (isBrowser) {
-            opts.fallback = true;
-        }
-        // If we are in browser, we are already using fallback because of the
-        // "browser" field in package.json.
-        // But if we were explicitly requested to use fallback, let's do it now.
-        this._gaxModule = !isBrowser && opts.fallback ? gax.fallback : gax;
+        // If we're running in browser, it's OK to omit `fallback` since
+        // google-gax has `browser` field in its `package.json`.
+        // For Electron (which does not respect `browser` field),
+        // pass `{fallback: true}` to the CloudRedisClient constructor.
+        this._gaxModule = opts.fallback ? gax.fallback : gax;
         // Create a `gaxGrpc` object, with any grpc-specific options
@@ -313,3 +316,3 @@ // sent to the client.
      * By default, the instance is accessible from the project's
-     * [default network](https://cloud.google.com/compute/docs/networks-and-firewalls#networks).
+     * [default network](https://cloud.google.com/vpc/docs/vpc).
      *
@@ -316,0 +319,0 @@ * The creation is executed asynchronously and callers may check the returned

build/src/v1beta1/cloud_redis_client.js

@@ -92,11 +92,14 @@ "use strict";
         opts.port = opts.port || port;
+        // users can override the config from client side, like retry codes name.
+        // The detailed structure of the clientConfig can be found here: https://github.com/googleapis/gax-nodejs/blob/master/src/gax.ts#L546
+        // The way to override client config for Showcase API:
+        //
+        // const customConfig = {"interfaces": {"google.showcase.v1beta1.Echo": {"methods": {"Echo": {"retry_codes_name": "idempotent", "retry_params_name": "default"}}}}}
+        // const showcaseClient = new showcaseClient({ projectId, customConfig });
         opts.clientConfig = opts.clientConfig || {};
-        const isBrowser = typeof window !== 'undefined';
-        if (isBrowser) {
-            opts.fallback = true;
-        }
-        // If we are in browser, we are already using fallback because of the
-        // "browser" field in package.json.
-        // But if we were explicitly requested to use fallback, let's do it now.
-        this._gaxModule = !isBrowser && opts.fallback ? gax.fallback : gax;
+        // If we're running in browser, it's OK to omit `fallback` since
+        // google-gax has `browser` field in its `package.json`.
+        // For Electron (which does not respect `browser` field),
+        // pass `{fallback: true}` to the CloudRedisClient constructor.
+        this._gaxModule = opts.fallback ? gax.fallback : gax;
         // Create a `gaxGrpc` object, with any grpc-specific options
@@ -317,3 +320,3 @@ // sent to the client.
      * By default, the instance is accessible from the project's
-     * [default network](https://cloud.google.com/compute/docs/networks-and-firewalls#networks).
+     * [default network](https://cloud.google.com/vpc/docs/vpc).
      *
@@ -320,0 +323,0 @@ * The creation is executed asynchronously and callers may check the returned

CHANGELOG.md

@@ -7,2 +7,14 @@ # Changelog
 
+## [2.1.0](https://www.github.com/googleapis/nodejs-redis/compare/v2.0.0...v2.1.0) (2020-06-12)
+
+
+### Features
+
+* **secrets:** begin migration to secret manager from keystore ([#399](https://www.github.com/googleapis/nodejs-redis/issues/399)) ([55a1e13](https://www.github.com/googleapis/nodejs-redis/commit/55a1e1375a27aa016fcdbe8b7b32ada072f4927a))
+
+
+### Bug Fixes
+
+* handle fallback option properly ([#402](https://www.github.com/googleapis/nodejs-redis/issues/402)) ([65eded7](https://www.github.com/googleapis/nodejs-redis/commit/65eded7aea3b857a84ace8c6394e66b345440a27))
+
 ## [2.0.0](https://www.github.com/googleapis/nodejs-redis/compare/v1.6.0...v2.0.0) (2020-05-08)
@@ -9,0 +21,0 @@

package.json

 {
   "name": "@google-cloud/redis",
   "description": "Google Cloud Memorystore for Redis API client for Node.js",
-  "version": "2.0.0",
+  "version": "2.1.0",
   "license": "Apache-2.0",
@@ -60,3 +60,3 @@ "author": "Google LLC",
     "linkinator": "^2.0.0",
-    "mocha": "^7.0.0",
+    "mocha": "^8.0.0",
     "null-loader": "^4.0.0",
@@ -63,0 +63,0 @@ "pack-n-play": "^1.0.0-2",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

2097651

increased by0.15%

Lines of code

34064

increased by0.1%

No dependency changes