@guardian/bridget - npm Package Compare versions

Comparing version 0.56.0 to 0.57.0

Notifications.d.ts

@@ -60,10 +60,10 @@ /// <reference types="node" />
 export interface IFollow__Result {
-    success?: boolean;
+    success?: void;
 }
 export interface IFollow__ResultArgs {
-    success?: boolean;
+    success?: void;
 }
 export declare const Follow__ResultCodec: thrift.IStructCodec<IFollow__ResultArgs, IFollow__Result>;
 export declare class Follow__Result extends thrift.StructLike implements IFollow__Result {
-    success?: boolean;
+    success?: void;
     readonly _annotations: thrift.IThriftAnnotations;
@@ -77,10 +77,10 @@ readonly _fieldAnnotations: thrift.IFieldAnnotations;
 export interface IUnfollow__Result {
-    success?: boolean;
+    success?: void;
 }
 export interface IUnfollow__ResultArgs {
-    success?: boolean;
+    success?: void;
 }
 export declare const Unfollow__ResultCodec: thrift.IStructCodec<IUnfollow__ResultArgs, IUnfollow__Result>;
 export declare class Unfollow__Result extends thrift.StructLike implements IUnfollow__Result {
-    success?: boolean;
+    success?: void;
     readonly _annotations: thrift.IThriftAnnotations;
@@ -121,9 +121,9 @@ readonly _fieldAnnotations: thrift.IFieldAnnotations;
     };
-    follow(topic: Topic.ITopicArgs, context?: Context): Promise<boolean>;
-    unfollow(topic: Topic.ITopicArgs, context?: Context): Promise<boolean>;
+    follow(topic: Topic.ITopicArgs, context?: Context): Promise<void>;
+    unfollow(topic: Topic.ITopicArgs, context?: Context): Promise<void>;
     isFollowing(topic: Topic.ITopicArgs, context?: Context): Promise<boolean>;
 }
 export interface IHandler<Context = any> {
-    follow(topic: Topic.ITopic, context?: Context): boolean | Promise<boolean>;
-    unfollow(topic: Topic.ITopic, context?: Context): boolean | Promise<boolean>;
+    follow(topic: Topic.ITopic, context?: Context): void | Promise<void>;
+    unfollow(topic: Topic.ITopic, context?: Context): void | Promise<void>;
     isFollowing(topic: Topic.ITopic, context?: Context): boolean | Promise<boolean>;
@@ -130,0 +130,0 @@ }

Notifications.js

@@ -279,11 +279,3 @@ "use strict";
     encode(args, output) {
-        const obj = {
-            success: args.success
-        };
         output.writeStructBegin("Follow__Result");
-        if (obj.success != null) {
-            output.writeFieldBegin("success", thrift.TType.BOOL, 0);
-            output.writeBool(obj.success);
-            output.writeFieldEnd();
-        }
         output.writeFieldStop();
@@ -305,5 +297,4 @@ output.writeStructEnd();
                 case 0:
-                    if (fieldType === thrift.TType.BOOL) {
-                        const value_7 = input.readBool();
-                        _args.success = value_7;
+                    if (fieldType === thrift.TType.VOID) {
+                        input.skip(fieldType);
                     }
@@ -332,4 +323,4 @@ else {
         if (args.success != null) {
-            const value_8 = args.success;
-            this.success = value_8;
+            const value_7 = undefined;
+            this.success = value_7;
         }
@@ -350,11 +341,3 @@ }
     encode(args, output) {
-        const obj = {
-            success: args.success
-        };
         output.writeStructBegin("Unfollow__Result");
-        if (obj.success != null) {
-            output.writeFieldBegin("success", thrift.TType.BOOL, 0);
-            output.writeBool(obj.success);
-            output.writeFieldEnd();
-        }
         output.writeFieldStop();
@@ -376,5 +359,4 @@ output.writeStructEnd();
                 case 0:
-                    if (fieldType === thrift.TType.BOOL) {
-                        const value_9 = input.readBool();
-                        _args.success = value_9;
+                    if (fieldType === thrift.TType.VOID) {
+                        input.skip(fieldType);
                     }
@@ -403,4 +385,4 @@ else {
         if (args.success != null) {
-            const value_10 = args.success;
-            this.success = value_10;
+            const value_8 = undefined;
+            this.success = value_8;
         }
@@ -447,4 +429,4 @@ }
                     if (fieldType === thrift.TType.BOOL) {
-                        const value_11 = input.readBool();
-                        _args.success = value_11;
+                        const value_9 = input.readBool();
+                        _args.success = value_9;
                     }
@@ -473,4 +455,4 @@ else {
         if (args.success != null) {
-            const value_12 = args.success;
-            this.success = value_12;
+            const value_10 = args.success;
+            this.success = value_10;
         }
@@ -519,8 +501,3 @@ }
                         input.readMessageEnd();
-                        if (result.success != null) {
-                            return Promise.resolve(result.success);
-                        }
-                        else {
-                            return Promise.reject(new thrift.TApplicationException(thrift.TApplicationExceptionType.UNKNOWN, "follow failed: unknown result"));
-                        }
+                        return Promise.resolve(result.success);
                     }
@@ -558,8 +535,3 @@ }
                         input.readMessageEnd();
-                        if (result.success != null) {
-                            return Promise.resolve(result.success);
-                        }
-                        else {
-                            return Promise.reject(new thrift.TApplicationException(thrift.TApplicationExceptionType.UNKNOWN, "unfollow failed: unknown result"));
-                        }
+                        return Promise.resolve(result.success);
                     }
@@ -566,0 +538,0 @@ }

package.json

 {
   "name": "@guardian/bridget",
-  "version": "0.56.0",
+  "version": "0.57.0",
   "description": "",
@@ -5,0 +5,0 @@ "main": "index.js",

No alert changes

Worsened metrics

Total package byte prevSize

164354

decreased by-0.78%

Lines of code

4190

decreased by-0.66%

No dependency changes