@highpoint/get-ps-token - npm Package Compare versions

Comparing version 0.1.0 to 0.1.1

CHANGELOG.md

@@ -0,2 +1,6 @@
+# v0.1.1
+* Throw an exception if PS_TOKEN is not set, i.e. the username/password was 
+  wrong.
+
 # v0.1.0
 * Initial release

package.json

 {
   "name": "@highpoint/get-ps-token",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "description": "Populate cookie jar with PeopleSoft token",
@@ -5,0 +5,0 @@ "main": "src/index.js",

src/index.js

@@ -12,23 +12,23 @@ const request = require('request-promise');
   const jar = request.jar();
+  const uri = `https://${PS_HOSTNAME}/psp/${PS_ENVIRONMENT}/?cmd=login`;
 
-  try {
-    await request
-      .post({
-        uri: `https://${PS_HOSTNAME}/psp/${PS_ENVIRONMENT}/?cmd=login`,
-        headers: { 'User-Agent': 'request' },
-        jar,
-        resolveWithFullResponse: true,
-        simple: false
-      })
-      .form({ userid: PS_USERNAME, pwd: PS_PASSWORD })
-      .auth(HTTP_USERNAME, HTTP_PASSWORD, false)
-      .then(response => {
-        if (response.statusCode >= 400) {
-          return Promise.reject(new Error(response.message));
-        }
-      });
-  } catch ({ message }) {
-    console.error(message);
+  const response = await request
+    .post({
+      uri,
+      headers: { 'User-Agent': 'request' },
+      jar,
+      resolveWithFullResponse: true,
+      simple: false
+    })
+    .form({ userid: PS_USERNAME, pwd: PS_PASSWORD })
+    .auth(HTTP_USERNAME, HTTP_PASSWORD, false);
+
+  if (response.statusCode >= 400) {
+    throw new Error(response.message);
   }
 
+  if (!jar.getCookieString(uri).includes('PS_TOKEN')) {
+    throw new Error('Invalid username and/or password');
+  }
+
   return jar;
@@ -35,0 +35,0 @@ };

No alert changes

Improved metrics

Total package byte prevSize

4416

increased by2.08%

Worsened metrics

Lines of code

30

decreased by-6.25%

No dependency changes