@hixme-ui/bullet-list - npm Package Compare versions

Comparing version 2.0.0-alpha.0 to 2.0.0-alpha.1

lib/BulletList.js

@@ -15,3 +15,4 @@ 'use strict';
 
-var _templateObject = (0, _taggedTemplateLiteral3.default)(['\n  border-radius: 3px;\n  width: 6px;\n  height: 6px;\n  background: ', ';\n  margin-right: 15px;\n'], ['\n  border-radius: 3px;\n  width: 6px;\n  height: 6px;\n  background: ', ';\n  margin-right: 15px;\n']);
+var _templateObject = (0, _taggedTemplateLiteral3.default)(['\n  border-radius: 50%;\n  width: 6px;\n  height: 6px;\n  background: #2eae8f;\n  margin: 10px 10px 2px 10px;\n'], ['\n  border-radius: 50%;\n  width: 6px;\n  height: 6px;\n  background: #2eae8f;\n  margin: 10px 10px 2px 10px;\n']),
+    _templateObject2 = (0, _taggedTemplateLiteral3.default)(['\n  line-height: 25px;\n'], ['\n  line-height: 25px;\n']);
 
@@ -41,10 +42,8 @@ // hixme-ui
 
-var _themeProps = require('@hixme-ui/theme-props');
-
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
-var Circle = _styledComponents2.default.div(_templateObject, function (props) {
-  return (0, _themeProps.getBackgroundColor)(props);
-});
+var Circle = _styledComponents2.default.span(_templateObject);
 
+var LineContainer = _styledComponents2.default.div(_templateObject2);
+
 /* eslint-disable react/no-array-index-key */
@@ -55,3 +54,3 @@ var BulletList = function BulletList(_ref) {
   return _react2.default.createElement(
-    'div',
+    LineContainer,
     null,
@@ -61,11 +60,11 @@ bulletArray.map(function (item, index) {
         _container2.default,
-        { flex: true, noPadding: true, id: 'bullet-item', key: 'bullet-list-' + index, alignItems: 'center' },
+        { flex: true, noPadding: true, id: 'bullet-item', key: 'bullet-list-' + index },
         _react2.default.createElement(
-          'div',
-          null,
-          _react2.default.createElement(Circle, restProps)
+          _container2.default,
+          { flex: true, noPadding: true },
+          _react2.default.createElement(Circle, null)
         ),
         _react2.default.createElement(
           _text2.default,
-          null,
+          restProps,
           item
@@ -72,0 +71,0 @@ )

package.json

 {
   "name": "@hixme-ui/bullet-list",
-  "version": "2.0.0-alpha.0",
+  "version": "2.0.0-alpha.1",
   "description": "hixme-ui BulletList component",
@@ -82,6 +82,6 @@ "publishConfig": {
   "dependencies": {
-    "@hixme-ui/container": "^2.0.0-alpha.0",
-    "@hixme-ui/text": "^2.0.0-alpha.0",
-    "@hixme-ui/theme": "^2.0.0-alpha.0",
-    "@hixme-ui/theme-props": "^2.0.0-alpha.0",
+    "@hixme-ui/container": "^2.0.0-alpha.1",
+    "@hixme-ui/text": "^2.0.0-alpha.1",
+    "@hixme-ui/theme": "^2.0.0-alpha.1",
+    "@hixme-ui/theme-props": "^2.0.0-alpha.1",
     "styled-components": "^2.3.3"
@@ -88,0 +88,0 @@ },

src/BulletList.js

@@ -9,12 +9,14 @@ import React from 'react'
 
-import { getBackgroundColor } from '@hixme-ui/theme-props'
-
-const Circle = styled.div`
-  border-radius: 3px;
+const Circle = styled.span`
+  border-radius: 50%;
   width: 6px;
   height: 6px;
-  background: ${props => getBackgroundColor(props)};
-  margin-right: 15px;
+  background: #2eae8f;
+  margin: 10px 10px 2px 10px;
 `
 
+const LineContainer = styled.div`
+  line-height: 25px;
+`
+
 /* eslint-disable react/no-array-index-key */
@@ -25,12 +27,14 @@ const BulletList = ({
 }) => (
-  <div>
+  <LineContainer>
     {bulletArray.map((item, index) => (
-      <Container flex noPadding id='bullet-item' key={`bullet-list-${index}`} alignItems='center'>
-        <div>
-          <Circle {...restProps} />
-        </div>
-        <Text>{item}</Text>
+      <Container flex noPadding id='bullet-item' key={`bullet-list-${index}`}>
+        <Container flex noPadding>
+          <Circle />
+        </Container>
+        <Text {...restProps}>
+          {item}
+        </Text>
       </Container>
     ))}
-  </div>
+  </LineContainer>
 )
@@ -43,1 +47,2 @@
 export default BulletList
+

No alert changes

Improved metrics

Total package byte prevSize

10000

increased by2.55%

Lines of code

101

increased by3.06%

Dependency changes

• Updated@hixme-ui/container@^2.0.0-alpha.1

• Updated@hixme-ui/text@^2.0.0-alpha.1

• Updated@hixme-ui/theme@^2.0.0-alpha.1

• Updated@hixme-ui/theme-props@^2.0.0-alpha.1