@hmcts/one-per-page - npm Package Compare versions

Comparing version 3.3.3 to 3.3.6

package.json

@@ -5,3 +5,3 @@ {
   "homepage": "https://github.com/hmcts/one-per-page#readme",
-  "version": "3.3.3",
+  "version": "3.3.6",
   "main": "./src/main.js",
@@ -8,0 +8,0 @@ "repository": {

src/i18n/contentProxy.js

@@ -23,2 +23,6 @@ const util = require('util');
     }
+    if (name === 'keys') {
+      const content = target.getResourceBundle(target.language, `${step.name}`);
+      return Object.keys(content);
+    }
     const key = `${step.name}:${prefix}`;
@@ -25,0 +29,0 @@ if (toStringKeys.includes(name)) {

src/i18n/loadStepContent.js

@@ -79,2 +79,3 @@ const { fileExists, readJson, glob } = require('../util/fs');
   const promises = [
+    glob('common/*.json').then(loadContents),
     glob(`${step.dirname}/content.json`).then(loadContents),
@@ -81,0 +82,0 @@ glob(`${step.dirname}/content.@(*).json`).then(loadContents),

src/session/index.js

@@ -18,6 +18,6 @@ const expressSession = require('express-session');
   const userCookie = userOpts.cookie || {};
-  const cookie = Object.assign({}, userCookie, {
+  const cookie = Object.assign({}, {
     secure: defaultIfUndefined(userCookie.secure, !isTest),
     expires: defaultIfUndefined(userCookie.expires, false)
-  });
+  }, userCookie);
 
@@ -24,0 +24,0 @@ return {

test/i18n/contentProxy.test.js

@@ -16,4 +16,9 @@ const util = require('util');
     const exists = sinon.stub();
+    const getResourceBundle = sinon.stub().returns({ key: 'key' });
     const fakeStep = { name: 'FakeStep' };
-    const proxy = new Proxy({ t, exists }, contentProxy(fakeStep));
+    const proxy = new Proxy({
+      t,
+      exists,
+      getResourceBundle
+    }, contentProxy(fakeStep));
 
@@ -99,3 +104,9 @@ beforeEach(() => {
     });
+
+    describe('#keys (used by one-per-page-test-suite)', () => {
+      it('returns all keys for properties', () => {
+        expect(proxy.foo.keys).to.eql(['key']);
+      });
+    });
   });
 });

test/util/supertest.js

@@ -73,2 +73,7 @@ const express = require('express');
   };
+  supertestObj.text = assertions => {
+    return supertestObj.then(res => {
+      return assertions(res.text);
+    });
+  };
   supertestObj.session = assertions => {
@@ -75,0 +80,0 @@ return supertestObj.then(res => {

New alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Number of package files

252

increased by0.8%

Worsened metrics

Total package byte prevSize

1329383

decreased by-3.07%

Lines of code

8542

decreased by-60.91%

Number of medium supply chain risk alerts

14

increased by7.69%

No dependency changes