@instana/core - npm Package Compare versions

Comparing version 1.137.3 to 1.137.4

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+## [1.137.4](https://github.com/instana/nodejs/compare/v1.137.3...v1.137.4) (2022-01-11)
+
+
+### Bug Fixes
+
+* **tracing:** fix vendoring of emitter-listener for legacy cls context ([440fd32](https://github.com/instana/nodejs/commit/440fd3218a37bc333da26c2365bfc1116a931b9b))
+
+
+
+
+
 ## [1.137.3](https://github.com/instana/nodejs/compare/v1.137.2...v1.137.3) (2021-12-16)
@@ -8,0 +19,0 @@

package.json

 {
   "name": "@instana/core",
-  "version": "1.137.3",
+  "version": "1.137.4",
   "description": "Core library for Instana's Node.js packages",
@@ -139,3 +139,3 @@ "main": "src/index.js",
   },
-  "gitHead": "c95b2f696a354c76ee8ab500e7b81cb91f8450e1"
+  "gitHead": "eb8440ec768cebfb83def798da5770b874d00b4c"
 }

src/tracing/clsHooked/context-legacy.js

@@ -18,3 +18,3 @@ /*
 // @ts-ignore
-const wrapEmitter = require('emitter-listener');
+const wrapEmitter = require('./emitter-listener');
 // @ts-ignore
@@ -21,0 +21,0 @@ const asyncHook = require('async-hook-jl');

src/tracing/instrumentation/messaging/nats.js

@@ -90,2 +90,10 @@ /*
     try {
+      // Up until 1.4.9, nats would throw the error synchronously when no callback is provided. With 1.4.12 (the next
+      // published version after 1.4.9), this will no longer happen. Instead, it will only be emitted via the nats event
+      // emitter. To capture those publisher errors, we would need to register our own event emitter. However, that is
+      // too invasive just for the sake of capturing publisher errors. Thus, for version ^1.4.12, we will not capture
+      // publisher errors in the span.
+      //
+      // See https://github.com/nats-io/nats.js/commit/9f34226823ffbd63c6f139a9d12b368a4a8adb93
+      // #diff-eb672f729dbb809e0a46163f59b4f93a76975fd0b7461640db7527ecfc346749R1687
       return originalPublish.apply(ctx, originalArgs);
@@ -92,0 +100,0 @@ } catch (e) {

No alert changes

Improved metrics

Total package byte prevSize

570003

increased by0.17%

Lines of code

15924

increased by0.05%

No dependency changes