@instana/core - npm Package Compare versions

Comparing version 1.92.4 to 1.92.5

package.json

 {
   "name": "@instana/core",
-  "version": "1.92.4",
+  "version": "1.92.5",
   "description": "Core library for Instana's Node.js packages",
@@ -133,6 +133,6 @@ "main": "src/index.js",
     "eslint-plugin-mocha": "^5.3.0",
-    "mocha": "^6.0.2",
+    "mocha": "^6.2.2",
     "prettier": "^1.17.1"
   },
-  "gitHead": "b4d4d9c222e8dcf85d22444366a9d421feecb785"
+  "gitHead": "50bec8353a5973e8a59ae92e65a74c02d40d730a"
 }

src/tracing/cls.js

@@ -188,4 +188,2 @@ 'use strict';
   }
-  this.async = false;
-  this.error = false;
   this.ec = 0;
@@ -192,0 +190,0 @@ this.ts = Date.now();

src/tracing/instrumentation/database/elasticsearch.js

@@ -109,3 +109,2 @@ 'use strict';
       span.d = Date.now() - span.ts;
-      span.error = false;
       span.transmit();
@@ -117,3 +116,2 @@ return response;
       span.d = Date.now() - span.ts;
-      span.error = true;
       span.ec = 1;
@@ -120,0 +118,0 @@ span.data.elasticsearch.error = tracingUtil.getErrorDetails(error);

src/tracing/instrumentation/database/ioredis.js

@@ -85,3 +85,2 @@ 'use strict';
         if (error) {
-          span.error = true;
           span.ec = 1;
@@ -176,3 +175,2 @@ span.data.redis.error = error.message;
   if (error) {
-    span.error = true;
     span.ec = commandCount;
@@ -198,3 +196,2 @@ span.data.redis.error = error.message;
     // ioredis docs mention that this should never be possible, but better be safe than sorry
-    span.error = true;
     span.ec = commandCount;
@@ -216,3 +213,2 @@ span.data.redis.error = tracingUtil.getErrorDetails(error);
     if (numberOfErrors > 0) {
-      span.error = true;
       span.ec = numberOfErrors;
@@ -219,0 +215,0 @@ span.data.redis.error = tracingUtil.getErrorDetails(sampledError);

src/tracing/instrumentation/database/mongodb.js

@@ -150,3 +150,2 @@ 'use strict';
         span.ec = 1;
-        span.error = true;
         span.data.mongo.error = tracingUtil.getErrorDetails(error);
@@ -153,0 +152,0 @@ }

src/tracing/instrumentation/database/mssql.js

@@ -160,3 +160,2 @@ 'use strict';
     span.ec = 1;
-    span.error = true;
     span.data.mssql.error = tracingUtil.getErrorDetails(error);
@@ -163,0 +162,0 @@ }

src/tracing/instrumentation/database/mysql.js

@@ -161,3 +161,2 @@ 'use strict';
           span.ec = 1;
-          span.error = true;
           span.data.mysql.error = tracingUtil.getErrorDetails(error);
@@ -178,3 +177,2 @@
         span.ec = 1;
-        span.error = true;
         span.data.mysql.error = tracingUtil.getErrorDetails(error);
@@ -181,0 +179,0 @@ }

src/tracing/instrumentation/database/pg.js

@@ -100,3 +100,2 @@ 'use strict';
     span.ec = 1;
-    span.error = true;
     span.data.pg.error = tracingUtil.getErrorDetails(error);
@@ -103,0 +102,0 @@ }

src/tracing/instrumentation/database/pgNative.js

@@ -187,3 +187,2 @@ 'use strict';
     span.ec = 1;
-    span.error = true;
     span.data.pg.error = tracingUtil.getErrorDetails(error);
@@ -190,0 +189,0 @@ }

src/tracing/instrumentation/database/redis.js

@@ -102,3 +102,2 @@ 'use strict';
       if (error) {
-        span.error = true;
         span.ec = 1;
@@ -167,3 +166,2 @@ span.data.redis.error = tracingUtil.getErrorDetails(error);
     span.ec = 0;
-    span.error = false;
 
@@ -192,3 +190,2 @@ return original.apply(this, args);
       span.ec++;
-      span.error = true;
 
@@ -195,0 +192,0 @@ if (!span.data.redis.error) {

src/tracing/instrumentation/loggers/bunyan.js

@@ -85,3 +85,2 @@ /* eslint-disable max-len */
       span.ec = 1;
-      span.error = true;
     }
@@ -88,0 +87,0 @@ try {

src/tracing/instrumentation/loggers/log4js.js

@@ -77,3 +77,2 @@ 'use strict';
       span.ec = 1;
-      span.error = true;
     }
@@ -80,0 +79,0 @@ try {

src/tracing/instrumentation/loggers/pino.js

@@ -57,3 +57,2 @@ /* eslint-disable max-len */
                 span.ec = 1;
-                span.error = true;
               }
@@ -60,0 +59,0 @@ try {

src/tracing/instrumentation/loggers/winston.js

@@ -172,3 +172,2 @@ 'use strict';
       span.ec = 1;
-      span.error = true;
     }
@@ -175,0 +174,0 @@ try {

src/tracing/instrumentation/messaging/kafkaJs.js

@@ -80,3 +80,2 @@ 'use strict';
         span.ec = 1;
-        span.error = true;
         span.data.kafka.error = error.message;
@@ -153,3 +152,2 @@ span.d = Date.now() - span.ts;
         span.ec = 1;
-        span.error = true;
         span.data.kafka.error = error.message;
@@ -156,0 +154,0 @@ span.d = Date.now() - span.ts;

src/tracing/instrumentation/messaging/kafkaNode.js

@@ -70,3 +70,2 @@ 'use strict';
           span.ec = 1;
-          span.error = true;
           span.data.kafka.error = err.message;
@@ -73,0 +72,0 @@ }

src/tracing/instrumentation/messaging/nats.js

@@ -183,4 +183,3 @@ 'use strict';
   if (err) {
-    span.error = true;
-    span.ec++;
+    span.ec = 1;
 
@@ -187,0 +186,0 @@ var errMsg = null;

src/tracing/instrumentation/messaging/natsStreaming.js

@@ -174,4 +174,3 @@ 'use strict';
   if (err) {
-    span.error = true;
-    span.ec++;
+    span.ec = 1;
 
@@ -178,0 +177,0 @@ var errMsg = null;

src/tracing/instrumentation/protocols/graphql.js

@@ -263,4 +263,3 @@ 'use strict';
 function finishSpan(span, result) {
-  span.ec = result.errors ? result.errors.length : 0;
-  span.error = span.ec > 0;
+  span.ec = result.errors && result.errors.length >= 1 ? 1 : 0;
   span.d = Date.now() - span.ts;
@@ -284,3 +283,2 @@ if (Array.isArray(result.errors)) {
   span.ec = 1;
-  span.error = true;
   span.d = Date.now() - span.ts;
@@ -287,0 +285,0 @@ span.data.graphql.errors = err.message;

src/tracing/instrumentation/protocols/grpc.js

@@ -97,3 +97,2 @@ 'use strict';
           if (err) {
-            span.error = true;
             span.ec = 1;
@@ -121,3 +120,2 @@ if (err.message || err.details) {
         call.on('error', function(err) {
-          span.error = true;
           span.ec = 1;
@@ -257,3 +255,2 @@ if (err.message || err.details) {
         if (errorMessage !== 'Cancelled') {
-          span.error = true;
           span.ec = 1;
@@ -308,3 +305,2 @@ if (errorMessage) {
         if (errorMessage !== 'Cancelled') {
-          span.error = true;
           span.ec = 1;
@@ -311,0 +307,0 @@ if (errorMessage) {

src/tracing/instrumentation/protocols/httpClient.js

@@ -150,4 +150,3 @@ 'use strict';
         span.d = Date.now() - span.ts;
-        span.error = res.statusCode >= 500;
-        span.ec = span.error ? 1 : 0;
+        span.ec = res.statusCode >= 500 ? 1 : 0;
         span.transmit();
@@ -177,3 +176,2 @@
         span.d = Date.now() - span.ts;
-        span.error = true;
         span.ec = 1;
@@ -226,3 +224,2 @@ span.transmit();
         span.d = Date.now() - span.ts;
-        span.error = true;
         span.ec = 1;
@@ -229,0 +226,0 @@ span.transmit();

src/tracing/instrumentation/protocols/httpServer.js

@@ -153,4 +153,3 @@ 'use strict';
           );
-          span.error = res.statusCode >= 500;
-          span.ec = span.error ? 1 : 0;
+          span.ec = res.statusCode >= 500 ? 1 : 0;
           span.d = Date.now() - span.ts;
@@ -157,0 +156,0 @@ span.transmit();

src/tracing/opentracing/Span.js

@@ -43,4 +43,2 @@ 'use strict';
     p: parentId,
-    async: false,
-    error: false,
     ec: 0,
@@ -112,3 +110,2 @@ ts: (fields ? fields.startTime : null) || Date.now(),
     if (value) {
-      this.span.error = true;
       this.span.ec = 1;
@@ -115,0 +112,0 @@ }

src/tracing/sdk/sdk.js

@@ -1,3 +0,1 @@
-/* global Promise */
-
 'use strict';
@@ -240,3 +238,2 @@
       span.ec = 1;
-      span.error = true;
     }
@@ -243,0 +240,0 @@

src/tracing/spanHandle.js

@@ -109,5 +109,2 @@ 'use strict';
     this.span.ec = errorCount;
-    if (errorCount > 0) {
-      this.span.error = true;
-    }
   }
@@ -114,0 +111,0 @@ this.span.transmitManual();

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

322146

decreased by-0.34%

Lines of code

8720

decreased by-0.5%

No dependency changes