@instructure/ui-testable - npm Package Compare versions

Comparing version 5.35.0-rc.12 to 5.35.0-rc.13

CHANGELOG.md

@@ -6,4 +6,4 @@ # Change Log
 
-<a name="5.35.0-rc.12"></a>
-# [5.35.0-rc.12](https://github.com/instructure/instructure-ui/compare/v5.34.0...v5.35.0-rc.12) (2018-11-28)
+<a name="5.35.0-rc.13"></a>
+# [5.35.0-rc.13](https://github.com/instructure/instructure-ui/compare/v5.34.0...v5.35.0-rc.13) (2018-11-29)
 
@@ -10,0 +10,0 @@

es/index.js

@@ -81,2 +81,3 @@ 'use strict';
         value: function componentWillUnmount() {
+          this._testableUnmounted = true;
           if ((0, _get6.default)(TestableComponent.prototype.__proto__ || Object.getPrototypeOf(TestableComponent.prototype), 'componentWillUnmount', this)) {
@@ -101,2 +102,6 @@ var _get4;
 
+            if (_this2._testableUnmounted) {
+              return;
+            }
+
             try {
@@ -119,3 +124,3 @@ // Use this.DOMNode for components that render as non-native Portals...
             }
-          }, 0);
+          });
         }
@@ -122,0 +127,0 @@ }]);

lib/index.js

@@ -81,2 +81,3 @@ 'use strict';
         value: function componentWillUnmount() {
+          this._testableUnmounted = true;
           if ((0, _get6.default)(TestableComponent.prototype.__proto__ || Object.getPrototypeOf(TestableComponent.prototype), 'componentWillUnmount', this)) {
@@ -101,2 +102,6 @@ var _get4;
 
+            if (_this2._testableUnmounted) {
+              return;
+            }
+
             try {
@@ -119,3 +124,3 @@ // Use this.DOMNode for components that render as non-native Portals...
             }
-          }, 0);
+          });
         }
@@ -122,0 +127,0 @@ }]);

package.json

 {
   "name": "@instructure/ui-testable",
-  "version": "5.35.0-rc.12",
+  "version": "5.35.0-rc.13",
   "description": "A UI component test utility made by Instructure Inc.",
@@ -24,4 +24,4 @@ "author": "Instructure, Inc. Engineering and Product Design",
   "devDependencies": {
-    "@instructure/ui-presets": "^5.35.0-rc.12",
-    "@instructure/ui-test-utils": "^5.35.0-rc.12",
+    "@instructure/ui-presets": "^5.35.0-rc.13",
+    "@instructure/ui-test-utils": "^5.35.0-rc.13",
     "prop-types": "^15.6.2"
@@ -36,3 +36,3 @@ },
   },
-  "gitHead": "e212f64f2d19aa258b22e2b1c6f790688f513c29"
+  "gitHead": "b959a9b1d3b55d68ba32e26fbea2f5f61c2f5d44"
 }

src/index.js

@@ -55,2 +55,3 @@ /*
       componentWillUnmount (...args) {
+        this._testableUnmounted = true
         if (super.componentWillUnmount) {
@@ -66,2 +67,6 @@ super.componentWillUnmount(...args)
 
+          if (this._testableUnmounted) {
+            return
+          }
+
           try {
@@ -84,3 +89,3 @@ // Use this.DOMNode for components that render as non-native Portals...
           }
-        }, 0)
+        })
       }
@@ -87,0 +92,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

19782

increased by1.81%

Lines of code

323

increased by3.86%

No dependency changes