@internetarchive/ia-item-navigator - npm Package Compare versions

Comparing version 2.1.1-alpha1 to 2.1.1-alpha2

dist/src/iaux-item-navigator.js

@@ -319,2 +319,7 @@ import { __decorate } from "tslib";
 
+      button:focus,
+      button:active {
+        outline: none;
+      }
+
       .menu-and-reader {
@@ -321,0 +326,0 @@ position: relative;

dist/src/menu-slider/styles/menu-button.js

@@ -28,2 +28,6 @@ import { css } from 'lit';
 
+  .menu-item:focus {
+    outline: none;
+  }
+
   .label {
@@ -30,0 +34,0 @@ display: var(--menuButtonLabelDisplay, none);

dist/src/menu-slider/styles/menu-slider.js

@@ -35,2 +35,3 @@ import { css } from 'lit';
   button {
+    outline: none;
     cursor: pointer;
@@ -48,2 +49,3 @@ }
   header button {
+    outline: none;
     cursor: pointer;
@@ -50,0 +52,0 @@ }

dist/src/menus/viewable-files.js

@@ -209,7 +209,13 @@ import { __decorate } from "tslib";
             // scroll active file into view if needed
-            // note: `scrollIntoViewIfNeeded` handles auto-scroll gracefully for Chrome, Safari
-            // Firefox does not have this capability yet as it does not support `scrollIntoViewIfNeeded`
-            activeFile === null || activeFile === void 0 ? void 0 : activeFile.scrollIntoViewIfNeeded(true);
-            // Todo: support `scrollIntoView` or `parentContainer.crollTop = x` for FF & "IE 11"
-            // currently, the hard `position: absolutes` misaligns subpanel when `scrollIntoView` is applied :(
+            // note:
+            // - `scrollIntoViewIfNeeded` handles auto-scroll gracefully for Chrome, Safari
+            // - `scrollIntoView` handles auto-scroll for almost all the browsers. specifially FF.
+            if (activeFile === null || activeFile === void 0 ? void 0 : activeFile.scrollIntoViewIfNeeded) {
+                // `scrollIntoViewIfNeeded` auto-scroll only if element not is visible area 
+                activeFile === null || activeFile === void 0 ? void 0 : activeFile.scrollIntoViewIfNeeded(true);
+            }
+            else {
+                // `scrollIntoView` always auto-scroll to center of visible area
+                activeFile === null || activeFile === void 0 ? void 0 : activeFile.scrollIntoView({ behavior: 'auto', block: 'center' });
+            }
         }, 350);
@@ -314,2 +320,3 @@ }
         cursor: pointer;
+        outline: none;
         position: relative;
@@ -316,0 +323,0 @@ }

dist/src/no-theater-available.js

@@ -54,2 +54,3 @@ import { __decorate } from "tslib";
         min-height: 35px;
+        outline: none;
         cursor: pointer;
@@ -56,0 +57,0 @@ line-height: normal;

package.json

 {
   "name": "@internetarchive/ia-item-navigator",
-  "version": "2.1.1-alpha1",
+  "version": "2.1.1-alpha2",
   "description": "Internet Archive's Item Navigator, visually explore an item's contents.",
@@ -5,0 +5,0 @@ "repository": {

src/iaux-item-navigator.ts

@@ -418,2 +418,7 @@ import {
 
+      button:focus,
+      button:active {
+        outline: none;
+      }
+
       .menu-and-reader {
@@ -420,0 +425,0 @@ position: relative;

src/menu-slider/styles/menu-button.ts

@@ -29,2 +29,6 @@ import { css } from 'lit';
 
+  .menu-item:focus {
+    outline: none;
+  }
+
   .label {
@@ -31,0 +35,0 @@ display: var(--menuButtonLabelDisplay, none);

src/menu-slider/styles/menu-slider.ts

@@ -37,2 +37,3 @@ import { css } from 'lit';
   button {
+    outline: none;
     cursor: pointer;
@@ -50,2 +51,3 @@ }
   header button {
+    outline: none;
     cursor: pointer;
@@ -52,0 +54,0 @@ }

src/menus/viewable-files.ts

@@ -225,8 +225,12 @@ /* eslint-disable max-classes-per-file */
       // scroll active file into view if needed
-      // note: `scrollIntoViewIfNeeded` handles auto-scroll gracefully for Chrome, Safari
-      // Firefox does not have this capability yet as it does not support `scrollIntoViewIfNeeded`
-      activeFile?.scrollIntoViewIfNeeded(true);
-
-      // Todo: support `scrollIntoView` or `parentContainer.crollTop = x` for FF & "IE 11"
-      // currently, the hard `position: absolutes` misaligns subpanel when `scrollIntoView` is applied :(
+      // note:
+      // - `scrollIntoViewIfNeeded` handles auto-scroll gracefully for Chrome, Safari
+      // - `scrollIntoView` handles auto-scroll for almost all the browsers. specifially FF.
+      if (activeFile?.scrollIntoViewIfNeeded) {
+        // `scrollIntoViewIfNeeded` auto-scroll only if element not is visible area 
+        activeFile?.scrollIntoViewIfNeeded(true);
+      } else {
+        // `scrollIntoView` always auto-scroll to center of visible area
+        activeFile?.scrollIntoView({ behavior: 'auto', block:   'center' });
+      }
     }, 350);
@@ -343,2 +347,3 @@ }
         cursor: pointer;
+        outline: none;
         position: relative;
@@ -345,0 +350,0 @@ }

src/no-theater-available.ts

@@ -66,2 +66,3 @@ import {
         min-height: 35px;
+        outline: none;
         cursor: pointer;
@@ -68,0 +69,0 @@ line-height: normal;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

424612

increased by0.31%

Lines of code

6494

increased by0.51%

No dependency changes